consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use milestoneable to find/create a milestone

Browse Source 
This way we simplify the code and avoid strange cases like `params[:id]`
having an ID which doesn't belong to the current milestoneable.
This commit is contained in:
Javi Martín
2018-11-13 11:13:59 +01:00
parent c4448faf70
commit ae22cd247a
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/controllers/admin/milestones_controller.rb
View File

@@ -14,8 +14,7 @@ class Admin::MilestonesController < Admin::BaseController
end end
def create def create
@milestone = Milestone.new(milestone_params) @milestone = @milestoneable.milestones.new(milestone_params)
@milestone.milestoneable = @milestoneable
if @milestone.save if @milestone.save
redirect_to milestoneable_path, notice: t('admin.milestones.create.notice') redirect_to milestoneable_path, notice: t('admin.milestones.create.notice')
else else
@@ -64,7 +63,7 @@ class Admin::MilestonesController < Admin::BaseController
end end
def get_milestone def get_milestone
Milestone.find(params[:id]) @milestoneable.milestones.find(params[:id])
end end
def load_statuses def load_statuses