updates controller specs deprecation warnings

This commit is contained in:
rgarcia
2016-10-26 03:05:52 +02:00
committed by Julian Herrero
parent a910eb69cd
commit 9a49716f22
3 changed files with 8 additions and 8 deletions

View File

@@ -10,7 +10,7 @@ describe HasOrders do
has_orders ->(c) { ["votes_count", "flags_count"] }, only: :new
def index
render text: "#{@current_order} (#{@valid_orders.join(" ")})"
render plain: "#{@current_order} (#{@valid_orders.join(" ")})"
end
def new
@@ -48,12 +48,12 @@ describe HasOrders do
end
it "can be changed by the order param" do
get :index, order: "votes_count"
get :index, params: { order: "votes_count" }
expect(response.body).to eq("votes_count (created_at votes_count flags_count)")
end
it "defaults to the first one on the list if given a bogus order" do
get :index, order: "foobar"
get :index, params: { order: "foobar" }
expect(response.body).to eq("created_at (created_at votes_count flags_count)")
end
end

View File

@@ -15,7 +15,7 @@ describe DebatesController do
sign_in create(:user)
post :create, debate: { title: "A sample debate", description: "this is a sample debate", terms_of_service: 1 }
post :create, params: { debate: { title: "A sample debate", description: "this is a sample debate", terms_of_service: 1 }}
expect(Ahoy::Event.where(name: :debate_created).count).to eq 1
expect(Ahoy::Event.last.properties["debate_id"]).to eq Debate.last.id
end
@@ -32,7 +32,7 @@ describe DebatesController do
sign_in create(:user)
expect do
xhr :post, :vote, id: debate.id, value: "yes"
post :vote, xhr: true, params: { id: debate.id, value: "yes" }
end.to change { debate.reload.votes_for.size }.by(1)
end
@@ -42,7 +42,7 @@ describe DebatesController do
sign_in create(:user)
expect do
xhr :post, :vote, id: debate.id, value: "yes"
post :vote, xhr: true, params: { id: debate.id, value: "yes" }
end.not_to change { debate.reload.votes_for.size }
end
end

View File

@@ -5,7 +5,7 @@ describe Management::SessionsController do
describe "Sign in" do
it "denies access if wrong manager credentials" do
allow_any_instance_of(ManagerAuthenticator).to receive(:auth).and_return(false)
expect { get :create, login: "nonexistent", clave_usuario: "wrong"}.to raise_error CanCan::AccessDenied
expect { get :create, params: { login: "nonexistent" , clave_usuario: "wrong" }}.to raise_error CanCan::AccessDenied
expect(session[:manager]).to be_nil
end
@@ -13,7 +13,7 @@ describe Management::SessionsController do
manager = {login: "JJB033", user_key: "31415926", date: "20151031135905"}
allow_any_instance_of(ManagerAuthenticator).to receive(:auth).and_return(manager)
get :create, login: "JJB033", clave_usuario: "31415926", fecha_conexion: "20151031135905"
get :create, params: { login: "JJB033" , clave_usuario: "31415926", fecha_conexion: "20151031135905" }
expect(response).to be_redirect
expect(session[:manager][:login]).to eq "JJB033"
end