consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove redundant "Manage" in admin menu entries

Browse Source 
This is the admin section; it's obvious that every link in the menu will
take you to a page to manage something.

We're going to add a new item to either the "Settings" or the "Site
content" section, so it's a good time to improve what's already there.
This commit is contained in:
Javi Martín
2024-04-06 23:21:23 +02:00
parent 6de4737b70
commit 999d5c2f67
6 changed files with 25 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spec/system/admin/banners_spec.rb
View File

@@ -65,7 +65,7 @@ describe "Admin banners magement", :admin do
within("#side_menu") do
click_button "Site content"
click_link "Manage banners"
click_link "Banners"
end
click_link "Create banner"
@@ -134,7 +134,7 @@ describe "Admin banners magement", :admin do
within("#side_menu") do
click_button "Site content"
click_link "Manage banners"
click_link "Banners"
end
click_link "Edit"

2
spec/system/admin/geozones_spec.rb
View File

@@ -16,7 +16,7 @@ describe "Admin geozones", :admin do
within("#side_menu") do
click_button "Settings"
click_link "Manage geozones"
click_link "Geozones"
end
click_link "Create geozone"

6
spec/system/admin/poll/booths_spec.rb
View File

@@ -39,7 +39,7 @@ describe "Admin booths", :admin do
within("#side_menu") do
click_button "Voting booths"
click_link "Manage shifts"
click_link "Shifts Assignments"
end
expect(page).to have_css(".booth", count: 1)
@@ -80,7 +80,7 @@ describe "Admin booths", :admin do
visit admin_booths_path
within("#booth_#{booth.id}") do
expect(page).not_to have_link "Manage shifts"
expect(page).not_to have_link "Shifts Assignments"
click_link "Edit"
end
@@ -105,7 +105,7 @@ describe "Admin booths", :admin do
visit available_admin_booths_path
within("#booth_#{booth.id}") do
click_link "Manage shifts"
click_link "Shifts Assignments"
end
click_link "Go back"

14
spec/system/admin/poll/shifts_spec.rb
View File

@@ -44,7 +44,7 @@ describe "Admin shifts", :admin do
visit available_admin_booths_path
within("#booth_#{booth.id}") do
click_link "Manage shifts"
click_link "Shifts Assignments"
end
expect(page).to have_content "This booth has no shifts"
@@ -71,7 +71,7 @@ describe "Admin shifts", :admin do
visit available_admin_booths_path
within("#booth_#{booth.id}") do
click_link "Manage shifts"
click_link "Shifts Assignments"
end
expect(page).to have_css(".shift", count: 1)
@@ -117,7 +117,7 @@ describe "Admin shifts", :admin do
visit available_admin_booths_path
within("#booth_#{booth.id}") do
click_link "Manage shifts"
click_link "Shifts Assignments"
end
expect(page).to have_css(".shift", count: 2)
@@ -159,7 +159,7 @@ describe "Admin shifts", :admin do
visit available_admin_booths_path
within("#booth_#{booth.id}") do
click_link "Manage shifts"
click_link "Shifts Assignments"
end
expect(page).to have_content "This booth has no shifts"
@@ -182,7 +182,7 @@ describe "Admin shifts", :admin do
visit available_admin_booths_path
within("#booth_#{booth.id}") do
click_link "Manage shifts"
click_link "Shifts Assignments"
end
expect(page).to have_css(".shift", count: 1)
@@ -208,7 +208,7 @@ describe "Admin shifts", :admin do
visit available_admin_booths_path
within("#booth_#{booth.id}") do
click_link "Manage shifts"
click_link "Shifts Assignments"
end
expect(page).to have_css(".shift", count: 1)
@@ -237,7 +237,7 @@ describe "Admin shifts", :admin do
visit available_admin_booths_path
within("#booth_#{booth.id}") do
click_link "Manage shifts"
click_link "Shifts Assignments"
end
expect(page).to have_css(".shift", count: 1)