From 999d5c2f67f817aebdbd35c0dc11a7194ff8bf52 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Sat, 6 Apr 2024 23:21:23 +0200 Subject: [PATCH] Remove redundant "Manage" in admin menu entries This is the admin section; it's obvious that every link in the menu will take you to a page to manage something. We're going to add a new item to either the "Settings" or the "Site content" section, so it's a good time to improve what's already there. --- config/locales/en/admin.yml | 14 +++++++------- config/locales/es/admin.yml | 10 +++++----- spec/system/admin/banners_spec.rb | 4 ++-- spec/system/admin/geozones_spec.rb | 2 +- spec/system/admin/poll/booths_spec.rb | 6 +++--- spec/system/admin/poll/shifts_spec.rb | 14 +++++++------- 6 files changed, 25 insertions(+), 25 deletions(-) diff --git a/config/locales/en/admin.yml b/config/locales/en/admin.yml index 66ff65ea1..09d07d33a 100644 --- a/config/locales/en/admin.yml +++ b/config/locales/en/admin.yml @@ -727,11 +727,11 @@ en: menu: activity: Moderator activity admin: Admin menu - banner: Manage banners + banner: Banners proposals: Proposals proposals_topics: Proposals topics budgets: Participatory budgets - geozones: Manage geozones + geozones: Geozones hidden_comments: Hidden comments hidden_debates: Hidden debates hidden_proposals: Hidden proposals @@ -752,7 +752,7 @@ en: polls: Polls poll_booths: Booths location poll_booth_assignments: Booths Assignments - poll_shifts: Manage shifts + poll_shifts: Shifts Assignments officials: Officials organizations: Organisations settings: Global settings @@ -794,7 +794,7 @@ en: dashboard_actions: Resources and actions debates: "Debates" comments: "Comments" - local_census_records: Manage local census + local_census_records: Local census machine_learning: "AI / Machine learning" multitenancy: Multitenancy administrators: @@ -1232,7 +1232,7 @@ en: show: location: "Location" booth: - shifts: "Manage shifts" + shifts: "Shifts Assignments" officials: edit: destroy: Remove "Official" status @@ -1713,7 +1713,7 @@ en: empty: "There are no changes logged" local_census_records: index: - title: Manage local census + title: Local census create: Create new local census record no_local_census_records: There are no local census records. document_type: Document type @@ -1738,7 +1738,7 @@ en: create: notice: Local census records import process executed successfully! show: - title: Manage local census + title: Local census subtitle: Import process results import: Import again errored: Errored rows diff --git a/config/locales/es/admin.yml b/config/locales/es/admin.yml index 81297a548..e5d11242c 100644 --- a/config/locales/es/admin.yml +++ b/config/locales/es/admin.yml @@ -727,11 +727,11 @@ es: menu: activity: Actividad de moderadores admin: Menú de administración - banner: Gestionar banners + banner: Banners proposals: Propuestas proposals_topics: Temas de propuestas budgets: Presupuestos participativos - geozones: Gestionar zonas + geozones: Zonas hidden_comments: Comentarios ocultos hidden_debates: Debates ocultos hidden_proposals: Propuestas ocultas @@ -794,7 +794,7 @@ es: dashboard_actions: Recursos y acciones debates: "Debates" comments: "Comentarios" - local_census_records: Gestionar censo local + local_census_records: Censo local machine_learning: "IA / Machine learning" multitenancy: Multientidad administrators: @@ -1713,7 +1713,7 @@ es: empty: "No hay cambios registrados" local_census_records: index: - title: Gestionar censo local + title: Censo local create: Crear nuevo registro en el censo local no_local_census_records: No hay registros de censo local document_type: Tipo de documento @@ -1738,7 +1738,7 @@ es: create: notice: ¡Proceso de import de registros del censo local ejecutado correctamente! show: - title: Gestionar censo local + title: Censo local subtitle: Resultados del proceso de importación import: Importar otro fichero errored: Filas erróneas diff --git a/spec/system/admin/banners_spec.rb b/spec/system/admin/banners_spec.rb index c604f6d6e..33d67c405 100644 --- a/spec/system/admin/banners_spec.rb +++ b/spec/system/admin/banners_spec.rb @@ -65,7 +65,7 @@ describe "Admin banners magement", :admin do within("#side_menu") do click_button "Site content" - click_link "Manage banners" + click_link "Banners" end click_link "Create banner" @@ -134,7 +134,7 @@ describe "Admin banners magement", :admin do within("#side_menu") do click_button "Site content" - click_link "Manage banners" + click_link "Banners" end click_link "Edit" diff --git a/spec/system/admin/geozones_spec.rb b/spec/system/admin/geozones_spec.rb index 384cccc73..3ece9f6f4 100644 --- a/spec/system/admin/geozones_spec.rb +++ b/spec/system/admin/geozones_spec.rb @@ -16,7 +16,7 @@ describe "Admin geozones", :admin do within("#side_menu") do click_button "Settings" - click_link "Manage geozones" + click_link "Geozones" end click_link "Create geozone" diff --git a/spec/system/admin/poll/booths_spec.rb b/spec/system/admin/poll/booths_spec.rb index 392f01b62..9462358df 100644 --- a/spec/system/admin/poll/booths_spec.rb +++ b/spec/system/admin/poll/booths_spec.rb @@ -39,7 +39,7 @@ describe "Admin booths", :admin do within("#side_menu") do click_button "Voting booths" - click_link "Manage shifts" + click_link "Shifts Assignments" end expect(page).to have_css(".booth", count: 1) @@ -80,7 +80,7 @@ describe "Admin booths", :admin do visit admin_booths_path within("#booth_#{booth.id}") do - expect(page).not_to have_link "Manage shifts" + expect(page).not_to have_link "Shifts Assignments" click_link "Edit" end @@ -105,7 +105,7 @@ describe "Admin booths", :admin do visit available_admin_booths_path within("#booth_#{booth.id}") do - click_link "Manage shifts" + click_link "Shifts Assignments" end click_link "Go back" diff --git a/spec/system/admin/poll/shifts_spec.rb b/spec/system/admin/poll/shifts_spec.rb index a5e25a554..ad55359f8 100644 --- a/spec/system/admin/poll/shifts_spec.rb +++ b/spec/system/admin/poll/shifts_spec.rb @@ -44,7 +44,7 @@ describe "Admin shifts", :admin do visit available_admin_booths_path within("#booth_#{booth.id}") do - click_link "Manage shifts" + click_link "Shifts Assignments" end expect(page).to have_content "This booth has no shifts" @@ -71,7 +71,7 @@ describe "Admin shifts", :admin do visit available_admin_booths_path within("#booth_#{booth.id}") do - click_link "Manage shifts" + click_link "Shifts Assignments" end expect(page).to have_css(".shift", count: 1) @@ -117,7 +117,7 @@ describe "Admin shifts", :admin do visit available_admin_booths_path within("#booth_#{booth.id}") do - click_link "Manage shifts" + click_link "Shifts Assignments" end expect(page).to have_css(".shift", count: 2) @@ -159,7 +159,7 @@ describe "Admin shifts", :admin do visit available_admin_booths_path within("#booth_#{booth.id}") do - click_link "Manage shifts" + click_link "Shifts Assignments" end expect(page).to have_content "This booth has no shifts" @@ -182,7 +182,7 @@ describe "Admin shifts", :admin do visit available_admin_booths_path within("#booth_#{booth.id}") do - click_link "Manage shifts" + click_link "Shifts Assignments" end expect(page).to have_css(".shift", count: 1) @@ -208,7 +208,7 @@ describe "Admin shifts", :admin do visit available_admin_booths_path within("#booth_#{booth.id}") do - click_link "Manage shifts" + click_link "Shifts Assignments" end expect(page).to have_css(".shift", count: 1) @@ -237,7 +237,7 @@ describe "Admin shifts", :admin do visit available_admin_booths_path within("#booth_#{booth.id}") do - click_link "Manage shifts" + click_link "Shifts Assignments" end expect(page).to have_css(".shift", count: 1)