Merge pull request #901 from consul/popular_links

Adds new links on popular section

app/views/proposals/_popular.html.erb

@@ -1,4 +1,6 @@
 <div class="sidebar-divider"></div>
 <h3 class="sidebar-title"><%= t("proposals.index.top") %></h3>
-<br>
-<%= link_to t("proposals.index.top_link"), "/proposals/summary", class: "small" %>
+
+<p>
+  <%= link_to t("proposals.index.top_link_proposals"), summary_proposals_path, class: "small" %><br>
+</p>

config/locales/en.yml

@@ -301,8 +301,8 @@ en:
       select_order_long: 'You are viewing proposals according to:'
       start_proposal: Create a proposal
       title: Proposals
-      top: Weekly selection
-      top_link: See the best proposals
+      top: Top weekly
+      top_link_proposals: The most supported proposals by category
     new:
       back_link: Go back
       form:

config/locales/es.yml

@@ -302,8 +302,8 @@ es:
       select_order_long: Estas viendo las propuestas
       start_proposal: Crea una propuesta
       title: Propuestas ciudadanas
-      top: Selección semanal
-      top_link: Ver las mejores propuestas
+      top: Top semanal
+      top_link_proposals: Propuestas más apoyadas por categoría
     new:
       back_link: Volver
       form:

spec/features/proposals_spec.rb

@@ -1175,7 +1175,7 @@ feature 'Proposals' do
       create(:proposal, tag_list: 'Random')
 
       visit proposals_path
-      click_link "See the best proposals"
+      click_link "The most supported proposals by category"
 
       within("#culture") do
         expect(page).to have_content("Culture")

spec/models/proposal_spec.rb

@@ -691,7 +691,10 @@ describe Proposal do
       proposal2.update_column(:confidence_score, 100)
       proposal3 = create(:proposal, tag_list: 'Health')
 
-      expect(Proposal.for_summary).to include('Culture' => [proposal2, proposal1], 'Health' => [proposal3])
+      proposal1.update_column(:confidence_score, 10)
+      proposal2.update_column(:confidence_score, 9)
+
+      expect(Proposal.for_summary).to include('Culture' => [proposal1, proposal2], 'Health' => [proposal3])
     end
   end