Remove duplicate map location translations

We were using the same texts twice. For the remove marker label text,
however, we were using the text defined in proposals for both proposals
and investments.

Ideally the translation keys for these texts would go in another
namespace, since they no longer refer to just proposals. However,
renaming the translation keys would mean losing the existing
translations in every language we manage through Crowdin. So we aren't
doing so.

app/components/budgets/investments/form_component.html.erb

@@ -44,12 +44,7 @@
       <%= render Documents::NestedComponent.new(f) %>
     <% end %>
 
-    <%= render MapLocations::FormFieldsComponent.new(
+    <%= render MapLocations::FormFieldsComponent.new(f, map_location: map_location) %>
-      f,
-      map_location: map_location,
-      label: t("budgets.investments.form.map_location"),
-      help: t("budgets.investments.form.map_location_instructions")
-    ) %>
 
     <div>
       <%= f.text_field :location %>

app/components/map_locations/form_fields_component.rb

@@ -1,15 +1,23 @@
 class MapLocations::FormFieldsComponent < ApplicationComponent
-  attr_reader :form, :map_location, :label, :help
+  attr_reader :form, :map_location
   use_helpers :render_map
 
-  def initialize(form, map_location:, label:, help:)
+  def initialize(form, map_location:)
     @form = form
     @map_location = map_location
-    @label = label
-    @help = help
   end
 
   def render?
     feature?(:map)
   end
+
+  private
+
+    def label
+      t("proposals.form.map_location")
+    end
+
+    def help
+      t("proposals.form.map_location_instructions")
+    end
 end

app/components/proposals/form_component.html.erb

@@ -52,12 +52,7 @@
       </div>
     <% end %>
 
-    <%= render MapLocations::FormFieldsComponent.new(
+    <%= render MapLocations::FormFieldsComponent.new(f, map_location: map_location) %>
-      f,
-      map_location: proposal.map_location || MapLocation.new,
-      label: t("proposals.form.map_location"),
-      help: t("proposals.form.map_location_instructions")
-    ) %>
 
     <div>
       <%= f.label :tag_list, t("proposals.form.tags_label") %>

config/locales/en/budgets.yml

@@ -80,8 +80,6 @@ en:
         tags_instructions: "Tag this proposal. You can choose from proposed categories or add your own"
         tags_label: Tags
         tags_placeholder: "Enter the tags you would like to use, separated by commas (',')"
-        map_location: "Map location"
-        map_location_instructions: "Navigate the map to the location and place the marker."
       index:
         title: Participatory budgeting
         unfeasible: Unfeasible investment projects

config/locales/es/budgets.yml

@@ -80,8 +80,6 @@ es:
         tags_instructions: "Etiqueta este proyecto. Puedes elegir entre las categorías propuestas o introducir las que desees"
         tags_label: Etiquetas
         tags_placeholder: "Escribe las etiquetas que desees separadas por coma (',')"
-        map_location: "Ubicación en el mapa"
-        map_location_instructions: "Navega por el mapa hasta la ubicación y coloca el marcador."
       index:
         title: Presupuestos participativos
         unfeasible: Proyectos de gasto no viables

spec/components/map_locations/form_fields_component_spec.rb

@@ -4,11 +4,7 @@ describe MapLocations::FormFieldsComponent do
   let(:proposal) { Proposal.new }
   let(:map_location) { MapLocation.new }
   let(:form) { ConsulFormBuilder.new(:proposal, proposal, ApplicationController.new.view_context, {}) }
-  let(:label) { "Map location" }
+  let(:component) { MapLocations::FormFieldsComponent.new(form, map_location: map_location) }
-  let(:help) { "Add a marker" }
-  let(:component) do
-    MapLocations::FormFieldsComponent.new(form, map_location: map_location, label: label, help: help)
-  end
 
   it "is rendered when the map feature is enabled" do
     Setting["feature.map"] = true