consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Removes condition to allow images and data equalizer on proposals

Browse Source 
The proposal image only can be present if feature :allow_images is enabled, so there is no need to include both conditions. The data-equalizer also is unnecessary because the :thumb image already has an fix height.
This commit is contained in:
decabeza
2018-10-18 18:40:58 +02:00
parent 0c34e66478
commit 8964888711
1 changed files with 10 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
app/views/proposals/_proposal.html.erb
View File

@@ -1,17 +1,15 @@
<div id="<%= dom_id(proposal) %>"
class="proposal clear <%= ("successful" if proposal.total_votes > Proposal.votes_needed_for_success) %>"
class="proposal clear
<%= ("successful" if proposal.total_votes > Proposal.votes_needed_for_success) %>"
data-type="proposal">
<div class="panel <%= ('with-image' if feature?(:allow_images) && proposal.image.present?) %>">
<div class="panel <%= 'with-image' if proposal.image.present? %>">
<div class="icon-successful"></div>
<% if feature?(:allow_images) && proposal.image.present? %>
<div class="row" data-equalizer>
<% if proposal.image.present? %>
<div class="row">
<div class="small-12 medium-3 large-2 column text-center">
<div data-equalizer-watch>
<%= image_tag proposal.image_url(:thumb),
alt: proposal.image.title.unicode_normalize %>
</div>
<%= image_tag proposal.image_url(:thumb),
alt: proposal.image.title.unicode_normalize %>
</div>
<div class="small-12 medium-6 large-7 column">
@@ -24,7 +22,8 @@
<h3><%= link_to proposal.title, namespaced_proposal_path(proposal) %></h3>
<p class="proposal-info">
<span class="icon-comments"></span>&nbsp;
<%= link_to t("proposals.proposal.comments", count: proposal.comments_count), namespaced_proposal_path(proposal, anchor: "comments") %>
<%= link_to t("proposals.proposal.comments", count: proposal.comments_count),
namespaced_proposal_path(proposal, anchor: "comments") %>
<span class="bullet">&nbsp;&bull;&nbsp;</span>
<%= l proposal.created_at.to_date %>
@@ -64,8 +63,7 @@
</div>
<div id="<%= dom_id(proposal) %>_votes"
class="small-12 medium-3 column supports-container"
<%= 'data-equalizer-watch' if feature?(:allow_images) && proposal.image.present? %>>
class="small-12 medium-3 column supports-container">
<% if proposal.successful? %>
<div class="padding text-center">