consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use a button to mark debates as featured

Browse Source 
As mentioned in commit 5311daadf, there are several reasons to use
buttons in these situations. And, as mentioned in the previous commits,
using buttons instead of links for actions requiring confirmation will
help us test for accessibility issues.
This commit is contained in:
Javi Martín
2024-10-11 05:06:22 +02:00
parent 68744f110e
commit 87a5dd8ee5
3 changed files with 22 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/assets/stylesheets/debates/mark_featured_action.scss
View File

@@ -4,4 +4,12 @@
&::before {
@include vertical-separator;
}
form {
display: inline;
}
button {
@include link;
}
}

24
app/components/debates/mark_featured_action_component.html.erb
View File

@@ -1,17 +1,17 @@
<div class="mark-featured-action">
<% if debate.featured? %>
<%= link_to t("admin.actions.unmark_featured").capitalize,
unmark_featured_debate_path(debate),
method: :put,
data: { confirm: t("admin.actions.confirm_action",
action: t("admin.actions.unmark_featured"),
name: debate.title) } %>
<%= button_to t("admin.actions.unmark_featured").capitalize,
unmark_featured_debate_path(debate),
method: :put,
data: { confirm: t("admin.actions.confirm_action",
action: t("admin.actions.unmark_featured"),
name: debate.title) } %>
<% else %>
<%= link_to t("admin.actions.mark_featured").capitalize,
mark_featured_debate_path(debate),
method: :put,
data: { confirm: t("admin.actions.confirm_action",
action: t("admin.actions.mark_featured"),
name: debate.title) } %>
<%= button_to t("admin.actions.mark_featured").capitalize,
mark_featured_debate_path(debate),
method: :put,
data: { confirm: t("admin.actions.confirm_action",
action: t("admin.actions.mark_featured"),
name: debate.title) } %>
<% end %>
</div>

4
spec/system/debates_spec.rb
View File

@@ -748,7 +748,7 @@ describe "Debates" do
end
click_link debate.title
accept_confirm("Are you sure? Featured") { click_link "Featured" }
accept_confirm("Are you sure? Featured") { click_button "Featured" }
within("#debates") do
expect(page).to have_content "FEATURED"
@@ -760,7 +760,7 @@ describe "Debates" do
click_link debate.title
end
accept_confirm("Are you sure? Unmark featured") { click_link "Unmark featured" }
accept_confirm("Are you sure? Unmark featured") { click_button "Unmark featured" }
within("#debates") do
expect(page).not_to have_content "FEATURED"