consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unnecessary <div> tag

Browse Source 
The `proposal-show` HTML class was only used in this context to style
the whatsapp icon, which is now styled the same way as other social
share icons. The `proposal-show` class should be reserved for the actual
proposal show action.
This commit is contained in:
Javi Martín
2020-08-23 22:00:50 +02:00
parent 0d8119a1e3
commit 86cac524b2
1 changed files with 33 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

68
app/views/proposals/share.html.erb
View File

@@ -10,47 +10,45 @@
<% end %>
<% cache [locale_and_user_status(@proposal), @proposal, @proposal.author, Flag.flagged?(current_user, @proposal), @proposal_votes] do %>
<div class="proposal-show">
<div id="<%= dom_id(@proposal) %>" class="row">
<div class="small-12 medium-8 column">
<div id="<%= dom_id(@proposal) %>" class="row">
<div class="small-12 medium-8 column">
<h1><%= t("proposals.proposal.created") %></h1>
<h1><%= t("proposals.proposal.created") %></h1>
<p>
<span class="lead"><%= t("proposals.proposal.share.guide") %></span><br>
<%= t("proposals.proposal.share.edit") %>
</p>
<p>
<span class="lead"><%= t("proposals.proposal.share.guide") %></span><br>
<%= t("proposals.proposal.share.edit") %>
</p>
<%= render "shared/social_share",
title: @proposal.title,
url: proposal_url(@proposal),
description: @proposal.summary,
mobile: @proposal.title %>
<%= render "shared/social_share",
title: @proposal.title,
url: proposal_url(@proposal),
description: @proposal.summary,
mobile: @proposal.title %>
<% if can?(:dashboard, @proposal) %>
<div class="callout light margin">
<p class="text-center">
<strong><%= t("proposals.share.improve_it") %></strong>
</p>
<div class="small-12 medium-6 large-4 column small-centered">
<%= link_to t("proposals.share.dashboard"),
progress_proposal_dashboard_path(@proposal), class: "button expanded" %>
</div>
</div>
<% end %>
<div class="small margin-bottom">
<%= link_to t("proposals.proposal.share.view_proposal"), proposal_path(@proposal) %>
</div>
</div>
<div class="small-12 medium-4 column">
<div class="callout light">
<p>
<strong><%= @proposal.title %></strong><br>
<%= t("proposals.show.code") %> <%= @proposal.code %>
<% if can?(:dashboard, @proposal) %>
<div class="callout light margin">
<p class="text-center">
<strong><%= t("proposals.share.improve_it") %></strong>
</p>
<div class="small-12 medium-6 large-4 column small-centered">
<%= link_to t("proposals.share.dashboard"),
progress_proposal_dashboard_path(@proposal), class: "button expanded" %>
</div>
</div>
<% end %>
<div class="small margin-bottom">
<%= link_to t("proposals.proposal.share.view_proposal"), proposal_path(@proposal) %>
</div>
</div>
<div class="small-12 medium-4 column">
<div class="callout light">
<p>
<strong><%= @proposal.title %></strong><br>
<%= t("proposals.show.code") %> <%= @proposal.code %>
</p>
</div>
</div>
</div>