consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #3405 from consul/remove_obsolete_test

Browse Source 
Fix investment pagination tests
This commit is contained in:
Javier Martín
2019-04-03 21:13:07 +02:00
committed by GitHub
parent 62233191cf f6da20da64
commit 844ab5fb0e
1 changed files with 49 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

95
spec/features/budgets/investments_spec.rb
View File

@@ -583,43 +583,46 @@ feature "Budget Investments" do
context "Orders" do
before { budget.update(phase: "selecting") }
let(:per_page) { Budgets::InvestmentsController::PER_PAGE }
scenario "Default order is random" do
per_page = Kaminari.config.default_per_page
(per_page + 100).times { create(:budget_investment) }
visit budget_investments_path(budget, heading_id: heading.id)
order = all(".budget-investment h3").collect {|i| i.text }
visit budget_investments_path(budget, heading_id: heading.id)
new_order = eq(all(".budget-investment h3").collect {|i| i.text })
expect(order).not_to eq(new_order)
end
scenario "Random order after another order" do
per_page = Kaminari.config.default_per_page
(per_page + 2).times { create(:budget_investment) }
visit budget_investments_path(budget, heading_id: heading.id)
click_link "highest rated"
click_link "random"
order = all(".budget-investment h3").collect {|i| i.text }
visit budget_investments_path(budget, heading_id: heading.id)
new_order = eq(all(".budget-investment h3").collect {|i| i.text })
expect(order).not_to eq(new_order)
end
scenario "Random order maintained with pagination" do
per_page = Kaminari.config.default_per_page
(per_page + 2).times { create(:budget_investment, heading: heading) }
visit budget_investments_path(budget, heading_id: heading.id)
order = all(".budget-investment h3").collect {|i| i.text }
within(".submenu .is-active") { expect(page).to have_content "random" }
order = all(".budget-investment h3").collect { |i| i.text }
expect(order).not_to be_empty
visit budget_investments_path(budget, heading_id: heading.id)
new_order = all(".budget-investment h3").collect { |i| i.text }
expect(order).to eq(new_order)
end
scenario "Random order after another order" do
(per_page + 2).times { create(:budget_investment, heading: heading) }
visit budget_investments_path(budget, heading_id: heading.id)
order = all(".budget-investment h3").collect { |i| i.text }
expect(order).not_to be_empty
click_link "highest rated"
click_link "random"
visit budget_investments_path(budget, heading_id: heading.id)
new_order = all(".budget-investment h3").collect { |i| i.text }
expect(order).to eq(new_order)
end
scenario "Random order maintained with pagination" do
(per_page + 2).times { create(:budget_investment, heading: heading) }
visit budget_investments_path(budget, heading_id: heading.id)
order = all(".budget-investment h3").collect { |i| i.text }
expect(order).not_to be_empty
click_link "Next"
expect(page).to have_content "You're on page 2"
@@ -627,27 +630,27 @@ feature "Budget Investments" do
click_link "Previous"
expect(page).to have_content "You're on page 1"
new_order = all(".budget-investment h3").collect {|i| i.text }
new_order = all(".budget-investment h3").collect { |i| i.text }
expect(order).to eq(new_order)
end
scenario "Random order maintained when going back from show" do
10.times { |i| create(:budget_investment, heading: heading) }
per_page.times { |i| create(:budget_investment, heading: heading) }
visit budget_investments_path(budget, heading_id: heading.id)
order = all(".budget-investment h3").collect {|i| i.text }
order = all(".budget-investment h3").collect { |i| i.text }
expect(order).not_to be_empty
click_link Budget::Investment.first.title
click_link "Go back"
new_order = all(".budget-investment h3").collect {|i| i.text }
new_order = all(".budget-investment h3").collect { |i| i.text }
expect(order).to eq(new_order)
end
scenario "Investments are not repeated with random order" do
12.times { create(:budget_investment, heading: heading) }
# 12 instead of per_page + 2 because in each page there are 10 (in this case), not 25
(per_page + 2).times { create(:budget_investment, heading: heading) }
visit budget_investments_path(budget, order: "random")
@@ -661,7 +664,6 @@ feature "Budget Investments" do
common_values = first_page_investments & second_page_investments
expect(common_values.length).to eq(0)
end
scenario "Proposals are ordered by confidence_score" do
@@ -686,7 +688,7 @@ feature "Budget Investments" do
end
scenario "Each user has a different and consistent random budget investment order" do
(Kaminari.config.default_per_page * 1.3).to_i.times { create(:budget_investment, heading: heading) }
(per_page * 1.3).to_i.times { create(:budget_investment, heading: heading) }
in_browser(:one) do
visit budget_investments_path(budget, heading: heading)
@@ -722,7 +724,7 @@ feature "Budget Investments" do
end
scenario "Each user has a equal and consistent budget investment order when the random_seed is equal" do
(Kaminari.config.default_per_page * 1.3).to_i.times { create(:budget_investment, heading: heading) }
(per_page * 1.3).to_i.times { create(:budget_investment, heading: heading) }
in_browser(:one) do
visit budget_investments_path(budget, heading: heading, random_seed: "1")
@@ -741,10 +743,10 @@ feature "Budget Investments" do
voter = create(:user, :level_two)
login_as(voter)
10.times { create(:budget_investment, heading: heading) }
per_page.times { create(:budget_investment, heading: heading) }
voted_investments = []
10.times do
per_page.times do
investment = create(:budget_investment, heading: heading)
create(:vote, votable: investment, voter: voter)
voted_investments << investment
@@ -762,17 +764,18 @@ feature "Budget Investments" do
end
scenario "Order is random if budget is finished" do
10.times { create(:budget_investment) }
per_page.times { create(:budget_investment, :winner, heading: heading) }
budget.update(phase: "finished")
visit budget_investments_path(budget, heading_id: heading.id)
order = all(".budget-investment h3").collect {|i| i.text }
order = all(".budget-investment h3").collect { |i| i.text }
expect(order).not_to be_empty
visit budget_investments_path(budget, heading_id: heading.id)
new_order = eq(all(".budget-investment h3").collect {|i| i.text })
new_order = all(".budget-investment h3").collect { |i| i.text }
expect(order).not_to eq(new_order)
expect(order).to eq(new_order)
end
scenario "Order always is random for unfeasible and unselected investments" do