consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Simplify legislation process specs

Browse Source 
We kill two birds with one stone and also make each line less than 100
characters long.
This commit is contained in:
Javi Martín
2018-09-24 19:53:04 +02:00
parent 66fc49f9ed
commit 81871a56f8
2 changed files with 22 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
spec/features/admin/legislation/proposals_spec.rb
View File

@@ -31,12 +31,12 @@ feature 'Admin legislation processes' do
end
scenario 'Sorting legislation proposals by title', js: true do
legislation_process = create(:legislation_process)
create(:legislation_proposal, title: 'bbbb', cached_votes_up: 10, legislation_process_id: legislation_process.id)
create(:legislation_proposal, title: 'aaaa', cached_votes_up: 20, legislation_process_id: legislation_process.id)
create(:legislation_proposal, title: 'cccc', cached_votes_up: 30, legislation_process_id: legislation_process.id)
visit admin_legislation_process_proposals_path(legislation_process.id)
process = create(:legislation_process)
create(:legislation_proposal, title: 'bbbb', legislation_process_id: process.id)
create(:legislation_proposal, title: 'aaaa', legislation_process_id: process.id)
create(:legislation_proposal, title: 'cccc', legislation_process_id: process.id)
visit admin_legislation_process_proposals_path(process.id)
select "Title", from: "order-selector-participation"
within('#proposals_table') do
@@ -53,12 +53,12 @@ feature 'Admin legislation processes' do
end
scenario 'Sorting legislation proposals by supports', js: true do
legislation_process = create(:legislation_process)
create(:legislation_proposal, title: 'bbbb', cached_votes_up: 10, legislation_process_id: legislation_process.id)
create(:legislation_proposal, title: 'aaaa', cached_votes_up: 20, legislation_process_id: legislation_process.id)
create(:legislation_proposal, title: 'cccc', cached_votes_up: 30, legislation_process_id: legislation_process.id)
visit admin_legislation_process_proposals_path(legislation_process.id)
process = create(:legislation_process)
create(:legislation_proposal, cached_votes_up: 10, legislation_process_id: process.id)
create(:legislation_proposal, cached_votes_up: 30, legislation_process_id: process.id)
create(:legislation_proposal, cached_votes_up: 20, legislation_process_id: process.id)
visit admin_legislation_process_proposals_path(process.id)
select "Supports", from: "order-selector-participation"
within('#proposals_table') do
@@ -69,12 +69,12 @@ feature 'Admin legislation processes' do
end
scenario 'Sorting legislation proposals by Id', js: true do
legislation_process = create(:legislation_process)
proposal1 = create(:legislation_proposal, title: 'bbbb', cached_votes_up: 10, legislation_process_id: legislation_process.id)
proposal2 = create(:legislation_proposal, title: 'aaaa', cached_votes_up: 20, legislation_process_id: legislation_process.id)
proposal3 = create(:legislation_proposal, title: 'cccc', cached_votes_up: 30, legislation_process_id: legislation_process.id)
visit admin_legislation_process_proposals_path(legislation_process.id, order: :title)
process = create(:legislation_process)
proposal1 = create(:legislation_proposal, title: 'bbbb', legislation_process_id: process.id)
proposal2 = create(:legislation_proposal, title: 'aaaa', legislation_process_id: process.id)
proposal3 = create(:legislation_proposal, title: 'cccc', legislation_process_id: process.id)
visit admin_legislation_process_proposals_path(process.id, order: :title)
select "Id", from: "order-selector-participation"
within('#proposals_table') do

16
spec/features/legislation/proposals_spec.rb
View File

@@ -65,25 +65,23 @@ feature 'Legislation Proposals' do
end
scenario 'Selected filter apperars only if exists any selected poposal' do
legislation_process = create(:legislation_process)
create(:legislation_proposal, legislation_process_id: legislation_process.id)
create(:legislation_proposal, legislation_process_id: process.id)
visit legislation_process_proposals_path(legislation_process.id)
visit legislation_process_proposals_path(process)
expect(page).not_to have_content('Selected')
create(:legislation_proposal, legislation_process_id: legislation_process.id, selected: true)
create(:legislation_proposal, legislation_process_id: process.id, selected: true)
visit legislation_process_proposals_path(legislation_process.id)
visit legislation_process_proposals_path(process)
expect(page).to have_content('Selected')
end
scenario 'Selected filter works correctly' do
legislation_process = create(:legislation_process)
proposal1 = create(:legislation_proposal, legislation_process_id: legislation_process.id)
proposal2 = create(:legislation_proposal, legislation_process_id: legislation_process.id, selected: true)
visit legislation_process_proposals_path(legislation_process.id)
proposal1 = create(:legislation_proposal, legislation_process_id: process.id)
proposal2 = create(:legislation_proposal, legislation_process_id: process.id, selected: true)
visit legislation_process_proposals_path(process)
click_link 'Selected'