consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unneeded login in settings specs

Browse Source 
It looks like these lines were added on a branch which didn't include
commit 3da4ee00b but were merged after that commit was merged.

In any case, since we're already using the `:admin` tag in the whole
file, these lines aren't necessary.
This commit is contained in:
Javi Martín
2022-05-05 18:10:29 +02:00
parent ba5893e755
commit 80bb2f2d97
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spec/system/admin/settings_spec.rb
View File

@@ -264,7 +264,6 @@ describe "Admin settings", :admin do
scenario "On #tab-sdg-configuration" do scenario "On #tab-sdg-configuration" do
Setting["feature.sdg"] = true Setting["feature.sdg"] = true
Setting.create!(key: "sdg.whatever") Setting.create!(key: "sdg.whatever")
login_as(create(:administrator).user)
visit admin_settings_path visit admin_settings_path
click_link "SDG configuration" click_link "SDG configuration"
@@ -311,7 +310,6 @@ describe "Admin settings", :admin do
describe "SDG configuration tab" do describe "SDG configuration tab" do
scenario "is enabled when the sdg feature is enabled" do scenario "is enabled when the sdg feature is enabled" do
Setting["feature.sdg"] = true Setting["feature.sdg"] = true
login_as(create(:administrator).user)
visit admin_settings_path visit admin_settings_path
click_link "SDG configuration" click_link "SDG configuration"
@@ -321,7 +319,6 @@ describe "Admin settings", :admin do
scenario "is disabled when the sdg feature is disabled" do scenario "is disabled when the sdg feature is disabled" do
Setting["feature.sdg"] = false Setting["feature.sdg"] = false
login_as(create(:administrator).user)
visit admin_settings_path visit admin_settings_path
click_link "SDG configuration" click_link "SDG configuration"
@@ -333,7 +330,6 @@ describe "Admin settings", :admin do
scenario "is enabled right after enabling the feature" do scenario "is enabled right after enabling the feature" do
Setting["feature.sdg"] = false Setting["feature.sdg"] = false
login_as(create(:administrator).user)
visit admin_settings_path visit admin_settings_path