From 80bb2f2d971aa1a54819bca390d4f8ce0150e845 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Thu, 5 May 2022 18:10:29 +0200 Subject: [PATCH] Remove unneeded login in settings specs It looks like these lines were added on a branch which didn't include commit 3da4ee00b but were merged after that commit was merged. In any case, since we're already using the `:admin` tag in the whole file, these lines aren't necessary. --- spec/system/admin/settings_spec.rb | 4 ---- 1 file changed, 4 deletions(-) diff --git a/spec/system/admin/settings_spec.rb b/spec/system/admin/settings_spec.rb index 8160d4043..d839241d4 100644 --- a/spec/system/admin/settings_spec.rb +++ b/spec/system/admin/settings_spec.rb @@ -264,7 +264,6 @@ describe "Admin settings", :admin do scenario "On #tab-sdg-configuration" do Setting["feature.sdg"] = true Setting.create!(key: "sdg.whatever") - login_as(create(:administrator).user) visit admin_settings_path click_link "SDG configuration" @@ -311,7 +310,6 @@ describe "Admin settings", :admin do describe "SDG configuration tab" do scenario "is enabled when the sdg feature is enabled" do Setting["feature.sdg"] = true - login_as(create(:administrator).user) visit admin_settings_path click_link "SDG configuration" @@ -321,7 +319,6 @@ describe "Admin settings", :admin do scenario "is disabled when the sdg feature is disabled" do Setting["feature.sdg"] = false - login_as(create(:administrator).user) visit admin_settings_path click_link "SDG configuration" @@ -333,7 +330,6 @@ describe "Admin settings", :admin do scenario "is enabled right after enabling the feature" do Setting["feature.sdg"] = false - login_as(create(:administrator).user) visit admin_settings_path