consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #3030 from consul/fix-poll-results-accuracy

Browse Source 
Fix poll results accuracy
This commit is contained in:
Raimond Garcia
2018-11-13 14:03:49 +01:00
committed by GitHub
parent 56a2978b87 d8df2c1fa8
commit 6cfd0c2e13
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/poll/question/answer.rb
View File

@@ -46,7 +46,7 @@ class Poll::Question::Answer < ActiveRecord::Base
end
def total_votes_percentage
question.answers_total_votes.zero? ? 0 : (total_votes * 100) / question.answers_total_votes
question.answers_total_votes.zero? ? 0 : (total_votes * 100.0) / question.answers_total_votes
end
def set_most_voted

10
spec/features/polls/results_spec.rb
View File

@@ -42,14 +42,14 @@ feature 'Poll Results' do
expect(page).to have_content(question2.title)
within("#question_#{question1.id}_results_table") do
expect(find("#answer_#{answer1.id}_result")).to have_content("2 (66.0%)")
expect(find("#answer_#{answer2.id}_result")).to have_content("1 (33.0%)")
expect(find("#answer_#{answer1.id}_result")).to have_content("2 (66.67%)")
expect(find("#answer_#{answer2.id}_result")).to have_content("1 (33.33%)")
end
within("#question_#{question2.id}_results_table") do
expect(find("#answer_#{answer3.id}_result")).to have_content("1 (33.0%)")
expect(find("#answer_#{answer4.id}_result")).to have_content("1 (33.0%)")
expect(find("#answer_#{answer5.id}_result")).to have_content("1 (33.0%)")
expect(find("#answer_#{answer3.id}_result")).to have_content("1 (33.33%)")
expect(find("#answer_#{answer4.id}_result")).to have_content("1 (33.33%)")
expect(find("#answer_#{answer5.id}_result")).to have_content("1 (33.33%)")
end
end
end