consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fixes specs

Browse Source
This commit is contained in:
rgarcia
2016-02-17 20:14:23 +01:00
parent 9a767caa27
commit 6c6773aeb7
2 changed files with 33 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
spec/features/proposals_spec.rb
View File

@@ -1166,11 +1166,11 @@ feature 'Proposals' do
context "Summary" do
scenario "Displays proposals grouped by category" do
create(:tag, kind: 'category', name: 'Culture')
create(:tag, kind: 'category', name: 'Social Services')
create(:tag, kind: 'category', name: 'culture')
create(:tag, kind: 'category', name: 'social services')
3.times { create(:proposal, tag_list: 'Culture') }
3.times { create(:proposal, tag_list: 'Social Services') }
3.times { create(:proposal, tag_list: 'culture') }
3.times { create(:proposal, tag_list: 'social services') }
create(:proposal, tag_list: 'Random')
@@ -1183,14 +1183,14 @@ feature 'Proposals' do
end
within("#social-services") do
expect(page).to have_content("Social Services")
expect(page).to have_content("Social services")
expect(page).to have_css(".proposal", count: 3)
end
end
scenario "Displays a maximum of 3 proposals per category" do
create(:tag, kind: 'category', name: 'Culture')
4.times { create(:proposal, tag_list: 'Culture') }
create(:tag, kind: 'category', name: 'culture')
4.times { create(:proposal, tag_list: 'culture') }
visit summary_proposals_path
@@ -1198,10 +1198,10 @@ feature 'Proposals' do
end
scenario "Orders proposals by votes" do
create(:tag, kind: 'category', name: 'Culture')
create(:proposal, title: 'Best', tag_list: 'Culture').update_column(:confidence_score, 10)
create(:proposal, title: 'Worst', tag_list: 'Culture').update_column(:confidence_score, 2)
create(:proposal, title: 'Medium', tag_list: 'Culture').update_column(:confidence_score, 5)
create(:tag, kind: 'category', name: 'culture')
create(:proposal, title: 'Best', tag_list: 'culture').update_column(:confidence_score, 10)
create(:proposal, title: 'Worst', tag_list: 'culture').update_column(:confidence_score, 2)
create(:proposal, title: 'Medium', tag_list: 'culture').update_column(:confidence_score, 5)
visit summary_proposals_path
@@ -1210,10 +1210,10 @@ feature 'Proposals' do
end
scenario "Displays proposals from last week" do
create(:tag, kind: 'category', name: 'Culture')
proposal1 = create(:proposal, tag_list: 'Culture', created_at: 1.day.ago)
proposal2 = create(:proposal, tag_list: 'Culture', created_at: 5.days.ago)
proposal3 = create(:proposal, tag_list: 'Culture', created_at: 8.days.ago)
create(:tag, kind: 'category', name: 'culture')
proposal1 = create(:proposal, tag_list: 'culture', created_at: 1.day.ago)
proposal2 = create(:proposal, tag_list: 'culture', created_at: 5.days.ago)
proposal3 = create(:proposal, tag_list: 'culture', created_at: 8.days.ago)
visit summary_proposals_path

36
spec/models/proposal_spec.rb
View File

@@ -644,36 +644,36 @@ describe Proposal do
describe "for_summary" do
it "should return proposals tagged with a category" do
create(:tag, kind: 'category', name: 'Culture')
proposal = create(:proposal, tag_list: 'Culture')
create(:tag, kind: 'category', name: 'culture')
proposal = create(:proposal, tag_list: 'culture')
expect(Proposal.for_summary.values.flatten).to include(proposal)
end
it "should not return proposals tagged without a category" do
create(:tag, kind: 'category', name: 'Culture')
proposal = create(:proposal, tag_list: 'Parks')
create(:tag, kind: 'category', name: 'culture')
proposal = create(:proposal, tag_list: 'parks')
expect(Proposal.for_summary.values.flatten).to_not include(proposal)
end
it "should return proposals created this week" do
create(:tag, kind: 'category', name: 'Culture')
proposal = create(:proposal, tag_list: 'Culture')
create(:tag, kind: 'category', name: 'culture')
proposal = create(:proposal, tag_list: 'culture')
expect(Proposal.for_summary.values.flatten).to include(proposal)
end
it "should not return proposals created more than a week ago" do
create(:tag, kind: 'category', name: 'Culture')
proposal = create(:proposal, tag_list: 'Culture', created_at: 8.days.ago)
create(:tag, kind: 'category', name: 'culture')
proposal = create(:proposal, tag_list: 'culture', created_at: 8.days.ago)
expect(Proposal.for_summary.values.flatten).to_not include(proposal)
end
it "should order by votes" do
create(:tag, kind: 'category', name: 'Culture')
create(:proposal, tag_list: 'Culture').update_column(:confidence_score, 2)
create(:proposal, tag_list: 'Culture').update_column(:confidence_score, 10)
create(:proposal, tag_list: 'Culture').update_column(:confidence_score, 5)
create(:tag, kind: 'category', name: 'culture')
create(:proposal, tag_list: 'culture').update_column(:confidence_score, 2)
create(:proposal, tag_list: 'culture').update_column(:confidence_score, 10)
create(:proposal, tag_list: 'culture').update_column(:confidence_score, 5)
results = Proposal.for_summary.values.flatten
@@ -683,18 +683,18 @@ describe Proposal do
end
it "should return proposals grouped by tag" do
create(:tag, kind: 'category', name: 'Culture')
create(:tag, kind: 'category', name: 'Health')
create(:tag, kind: 'category', name: 'culture')
create(:tag, kind: 'category', name: 'health')
proposal1 = create(:proposal, tag_list: 'Culture')
proposal2 = create(:proposal, tag_list: 'Culture')
proposal1 = create(:proposal, tag_list: 'culture')
proposal2 = create(:proposal, tag_list: 'culture')
proposal2.update_column(:confidence_score, 100)
proposal3 = create(:proposal, tag_list: 'Health')
proposal3 = create(:proposal, tag_list: 'health')
proposal1.update_column(:confidence_score, 10)
proposal2.update_column(:confidence_score, 9)
expect(Proposal.for_summary).to include('Culture' => [proposal1, proposal2], 'Health' => [proposal3])
expect(Proposal.for_summary).to include('culture' => [proposal1, proposal2], 'health' => [proposal3])
end
end