consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Clarify the meaning of max "votable" headings

Browse Source 
The word "vote" is confusing because this option does not apply to the
voting phase, but to the selecting projects phase.
This commit is contained in:
Javi Martín
2020-09-09 11:44:07 +02:00
parent cd418e45be
commit 602daced6b
6 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/views/admin/budget_groups/_form.html.erb
View File

@@ -15,7 +15,9 @@
<% if @group.persisted? %>
<div class="row">
<div class="small-12 medium-6 column">
<%= f.select :max_votable_headings, (1..@group.headings.count) %>
<%= f.select :max_votable_headings,
(1..@group.headings.count),
hint: t("admin.budget_groups.form.max_votable_headings_info") %>
</div>
</div>
<% end %>

2
config/locales/en/activerecord.yml
View File

@@ -196,7 +196,7 @@ en:
primary: "Primary"
secondary: "Secondary"
budget/group:
max_votable_headings: "Maximum number of headings in which a user can vote"
max_votable_headings: "Maximum number of headings in which a user can select projects"
budget/group/translation:
name: "Group name"
budget/heading:

1
config/locales/en/admin.yml
View File

@@ -133,6 +133,7 @@ en:
form:
create: "Create new group"
edit: "Edit group"
max_votable_headings_info: "Only applies to the selecting projects phase. During the voting projects phase users can only vote in one heading per group."
submit: "Save group"
index:
back: "Go back to budgets"

2
config/locales/es/activerecord.yml
View File

@@ -198,7 +198,7 @@ es:
primary: "Principal"
secondary: "Secundaria"
budget/group:
max_votable_headings: "Máximo número de partidas en que un usuario puede votar"
max_votable_headings: "Máximo número de partidas en que un usuario puede seleccionar proyectos"
budget/group/translation:
name: "Nombre del grupo"
budget/heading:

1
config/locales/es/admin.yml
View File

@@ -133,6 +133,7 @@ es:
form:
create: "Crear nuevo grupo"
edit: "Editar grupo"
max_votable_headings_info: "Solo se aplica en la fase de apoyos. Durante la votación final un usuario solo puede votar en una partida por grupo."
submit: "Guardar grupo"
index:
back: "Volver a presupuestos"

6
spec/system/admin/budget_groups_spec.rb
View File

@@ -160,7 +160,7 @@ describe "Admin budget groups" do
within("#budget_group_#{group.id}") { click_link "Edit" }
expect(page).to have_field "Group name", with: group.name
expect(page).to have_field "Maximum number of headings in which a user can vote", with: "2"
expect(page).to have_field "Maximum number of headings in which a user can select projects", with: "2"
end
scenario "Changing name for current locale will update the slug if budget is in draft phase", :js do
@@ -198,14 +198,14 @@ describe "Admin budget groups" do
expect(page).to have_field "Group name", with: "All City"
fill_in "Group name", with: "Districts"
select "2", from: "Maximum number of headings in which a user can vote"
select "2", from: "Maximum number of headings in which a user can select projects"
click_button "Save group"
expect(page).to have_content "Group updated successfully"
visit edit_admin_budget_group_path(budget, group)
expect(page).to have_field "Group name", with: "Districts"
expect(page).to have_field "Maximum number of headings in which a user can vote", with: "2"
expect(page).to have_field "Maximum number of headings in which a user can select projects", with: "2"
end
scenario "Group name is already used" do