Remove question option uniqueness validation

Having translations makes this validation too complex and not worth the
effort, since now we can't just scope in a single column but we need to
scope in the translations locale and the question ID.
This commit is contained in:
Javi Martín
2018-10-16 19:51:15 +02:00
parent 9105ac3a69
commit 5e8746f026
2 changed files with 1 additions and 10 deletions

View File

@@ -9,5 +9,5 @@ class Legislation::QuestionOption < ActiveRecord::Base
has_many :answers, class_name: 'Legislation::Answer', foreign_key: 'legislation_question_id', dependent: :destroy, inverse_of: :question has_many :answers, class_name: 'Legislation::Answer', foreign_key: 'legislation_question_id', dependent: :destroy, inverse_of: :question
validates :question, presence: true validates :question, presence: true
validates_translation :value, presence: true # TODO: add uniqueness again validates_translation :value, presence: true
end end

View File

@@ -6,13 +6,4 @@ RSpec.describe Legislation::QuestionOption, type: :model do
it "is valid" do it "is valid" do
expect(legislation_question_option).to be_valid expect(legislation_question_option).to be_valid
end end
it "is unique per question" do
question = create(:legislation_question)
valid_question_option = create(:legislation_question_option, question: question, value: "uno")
invalid_question_option = build(:legislation_question_option, question: question, value: "uno")
expect(invalid_question_option).not_to be_valid
end
end end