From 5e8746f026f7f3ba1c77317d603af7a6b41f2ae2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Tue, 16 Oct 2018 19:51:15 +0200 Subject: [PATCH] Remove question option uniqueness validation Having translations makes this validation too complex and not worth the effort, since now we can't just scope in a single column but we need to scope in the translations locale and the question ID. --- app/models/legislation/question_option.rb | 2 +- spec/models/legislation/question_option_spec.rb | 9 --------- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/app/models/legislation/question_option.rb b/app/models/legislation/question_option.rb index a02d41554..35520b35b 100644 --- a/app/models/legislation/question_option.rb +++ b/app/models/legislation/question_option.rb @@ -9,5 +9,5 @@ class Legislation::QuestionOption < ActiveRecord::Base has_many :answers, class_name: 'Legislation::Answer', foreign_key: 'legislation_question_id', dependent: :destroy, inverse_of: :question validates :question, presence: true - validates_translation :value, presence: true # TODO: add uniqueness again + validates_translation :value, presence: true end diff --git a/spec/models/legislation/question_option_spec.rb b/spec/models/legislation/question_option_spec.rb index 1fd7eb307..eb23961ec 100644 --- a/spec/models/legislation/question_option_spec.rb +++ b/spec/models/legislation/question_option_spec.rb @@ -6,13 +6,4 @@ RSpec.describe Legislation::QuestionOption, type: :model do it "is valid" do expect(legislation_question_option).to be_valid end - - it "is unique per question" do - question = create(:legislation_question) - valid_question_option = create(:legislation_question_option, question: question, value: "uno") - - invalid_question_option = build(:legislation_question_option, question: question, value: "uno") - - expect(invalid_question_option).not_to be_valid - end end