Skip spec before doing any requests

Skipping a spec in the middle of it, particularly after doing some
requests, caused Capybara to keep using the same driver in the following
spec.

Since the current spec uses the JavaScript driver, the next test would
also use the JavaScript driver, causing apparently random failures if
that test was supposed to use the Rack driver.
This commit is contained in:
Javi Martín
2018-08-09 17:40:38 +02:00
parent 3e6b87df04
commit 5ae7a5512d

View File

@@ -175,15 +175,14 @@ shared_examples "nested imageable" do |imageable_factory_name, path,
end
scenario "Should show successful notice when resource filled correctly without any nested images", :js do
login_as user
visit send(path, arguments)
send(fill_resource_method_name) if fill_resource_method_name
click_on submit_button
if has_many_images
skip "no need to test, there are no attributes for the parent resource"
else
login_as user
visit send(path, arguments)
send(fill_resource_method_name) if fill_resource_method_name
click_on submit_button
expect(page).to have_content imageable_success_notice
end
end