consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Simplify selector in tracking test

Browse Source 
Using `have_selector` makes the test more robust since it matches all
the following HTML:

* <div data-track-event-category=verification>
* <div data-track-event-category='verification'>
* <div data-track-event-category="verification">

Our former expectation only matched the first one.
This commit is contained in:
Javi Martín
2021-03-27 16:44:32 +01:00
parent 0ec8878db9
commit 5ab1ed57ea
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
spec/system/tracks_spec.rb
View File

@@ -47,8 +47,8 @@ describe "Tracking" do
visit account_path
click_link "Verify my account"
expect(page.html).to include "data-track-event-category=verification"
expect(page.html).to include "data-track-event-action=start_census"
expect(page).to have_selector "[data-track-event-category='verification']", visible: :all
expect(page).to have_selector "[data-track-event-action='start_census']", visible: :all
end
scenario "Verification: success census & start sms" do
@@ -64,8 +64,8 @@ describe "Tracking" do
fill_in "sms_phone", with: "611111111"
click_button "Send"
expect(page.html).to include "data-track-event-category=verification"
expect(page.html).to include "data-track-event-action=start_sms"
expect(page).to have_selector "[data-track-event-category='verification']", visible: :all
expect(page).to have_selector "[data-track-event-action='start_sms']", visible: :all
end
scenario "Verification: success sms" do
@@ -85,8 +85,8 @@ describe "Tracking" do
fill_in "sms_confirmation_code", with: user.sms_confirmation_code
click_button "Send"
expect(page.html).to include "data-track-event-category=verification"
expect(page.html).to include "data-track-event-action=success_sms"
expect(page).to have_selector "[data-track-event-category='verification']", visible: :all
expect(page).to have_selector "[data-track-event-action='success_sms']", visible: :all
end
scenario "Verification: letter" do
@@ -108,8 +108,8 @@ describe "Tracking" do
click_link "Send me a letter with the code"
expect(page.html).to include "data-track-event-category=verification"
expect(page.html).to include "data-track-event-action=start_letter"
expect(page).to have_selector "[data-track-event-category='verification']", visible: :all
expect(page).to have_selector "[data-track-event-action='start_letter']", visible: :all
end
end
end