consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix exception when no available milestones

Browse Source 
We were getting an exception when quering[1] for milestones which were not present, due to for example having a publication date later than today

Adding a `try` statement and spec to avoid this situation

[1] 82efc3dd66/app/controllers/budgets/executions_controller.rb (L16)
This commit is contained in:
voodoorai2000
2018-09-10 18:36:04 +02:00
committed by decabeza
parent 7d55f64aac
commit 5856af03a5
2 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/budgets/executions_controller.rb
View File

@@ -13,7 +13,7 @@ module Budgets
.joins(:milestones).includes(:milestones)
.select { |i| i.milestones.published.with_status
.order_by_publication_date.last
.status_id == params[:status].to_i }
.try(:status_id) == params[:status].to_i }
.uniq
.group_by(&:heading)
else

14
spec/features/budgets/executions_spec.rb
View File

@@ -249,4 +249,18 @@ feature 'Executions' do
expect(m_heading.name).to appear_before(z_heading.name)
end
end
context 'No milestones' do
scenario 'Milestone not yet published' do
status = create(:budget_investment_status)
unpublished_milestone = create(:budget_investment_milestone, investment: investment1,
status: status, publication_date: Date.tomorrow)
visit custom_budget_executions_path(budget, status: status.id)
expect(page).to have_content('No winner investments in this state')
end
end
end