consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use let for stats in budget stats spec

Browse Source 
The rest of the `before` block still uses instance variables, but at
least the rest of the file doesn't use instance variables anymore.
This commit is contained in:
Javi Martín
2018-12-20 16:50:09 +01:00
parent 1a1ca13525
commit 57a2945590
1 changed files with 31 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

62
spec/models/budget/stats_spec.rb
View File

@@ -2,7 +2,7 @@ require "rails_helper"
describe Budget::Stats do
before(:each) do
before do
@budget = create(:budget)
@group = create(:budget_group, budget: @budget)
@heading = create(:budget_heading, group: @group, price: 1000)
@@ -40,14 +40,14 @@ describe Budget::Stats do
@budget_ballot4 = create(:budget_ballot, budget: @budget, physical: true, user: nil)
@budget_ballot_line4 = create(:budget_ballot_line, ballot: @budget_ballot4,
investment: @investment4)
@stats = Budget::Stats.new(@budget).generate
end
let(:stats) { Budget::Stats.new(@budget).generate }
context "#total_participants" do
it "returns the number of total participants" do
expect(@stats[:total_participants]).to be 11
expect(stats[:total_participants]).to be 11
end
end
@@ -55,7 +55,7 @@ describe Budget::Stats do
context "#total_participants_support_phase" do
it "returns the number of total participants in the support phase" do
expect(@stats[:total_participants_support_phase]).to be 2
expect(stats[:total_participants_support_phase]).to be 2
end
end
@@ -63,7 +63,7 @@ describe Budget::Stats do
context "#total_participants_vote_phase" do
it "returns the number of total participants in the votes phase" do
expect(@stats[:total_participants_vote_phase]).to be 4
expect(stats[:total_participants_vote_phase]).to be 4
end
end
@@ -71,7 +71,7 @@ describe Budget::Stats do
context "#total_participants_web" do
it "returns the number of total participants in the votes phase via web" do
expect(@stats[:total_participants_web]).to be 3
expect(stats[:total_participants_web]).to be 3
end
end
@@ -79,7 +79,7 @@ describe Budget::Stats do
context "#total_participants_booths" do
it "returns the number of total participants in the votes phase in booths" do
expect(@stats[:total_participants_booths]).to be 1
expect(stats[:total_participants_booths]).to be 1
end
end
@@ -87,7 +87,7 @@ describe Budget::Stats do
context "#total_budget_investments" do
it "returns the number of total budget investments" do
expect(@stats[:total_budget_investments]).to be 5
expect(stats[:total_budget_investments]).to be 5
end
end
@@ -95,7 +95,7 @@ describe Budget::Stats do
context "#total_votes" do
it "returns the number of total votes" do
expect(@stats[:total_votes]).to be 4
expect(stats[:total_votes]).to be 4
end
end
@@ -103,7 +103,7 @@ describe Budget::Stats do
context "#total_selected_investments" do
it "returns the number of total selected investments" do
expect(@stats[:total_selected_investments]).to be 4
expect(stats[:total_selected_investments]).to be 4
end
end
@@ -111,7 +111,7 @@ describe Budget::Stats do
context "#total_unfeasible_investments" do
it "returns the number of total unfeasible investments" do
expect(@stats[:total_unfeasible_investments]).to be 1
expect(stats[:total_unfeasible_investments]).to be 1
end
end
@@ -119,7 +119,7 @@ describe Budget::Stats do
context "#total_male_participants" do
it "returns the number of total male participants" do
expect(@stats[:total_male_participants]).to be 4
expect(stats[:total_male_participants]).to be 4
end
end
@@ -127,7 +127,7 @@ describe Budget::Stats do
context "#total_female_participants" do
it "returns the number of total female participants" do
expect(@stats[:total_female_participants]).to be 6
expect(stats[:total_female_participants]).to be 6
end
end
@@ -135,7 +135,7 @@ describe Budget::Stats do
context "#total_supports" do
it "returns the number of total supports" do
expect(@stats[:total_supports]).to be 2
expect(stats[:total_supports]).to be 2
end
end
@@ -143,7 +143,7 @@ describe Budget::Stats do
context "#total_unknown_gender_or_age" do
it "returns the number of total unknown participants' gender or age" do
expect(@stats[:total_unknown_gender_or_age]).to be 1
expect(stats[:total_unknown_gender_or_age]).to be 1
end
end
@@ -151,18 +151,18 @@ describe Budget::Stats do
context "#age_groups" do
it "returns the age groups hash" do
expect(@stats[:age_groups]["16 - 19"][:count]).to be 0
expect(@stats[:age_groups]["20 - 24"][:count]).to be 7
expect(@stats[:age_groups]["25 - 29"][:count]).to be 1
expect(@stats[:age_groups]["30 - 34"][:count]).to be 0
expect(@stats[:age_groups]["35 - 39"][:count]).to be 1
expect(@stats[:age_groups]["40 - 44"][:count]).to be 1
expect(@stats[:age_groups]["45 - 49"][:count]).to be 0
expect(@stats[:age_groups]["50 - 54"][:count]).to be 1
expect(@stats[:age_groups]["55 - 59"][:count]).to be 0
expect(@stats[:age_groups]["60 - 64"][:count]).to be 0
expect(@stats[:age_groups]["65 - 69"][:count]).to be 0
expect(@stats[:age_groups]["70 - 74"][:count]).to be 0
expect(stats[:age_groups]["16 - 19"][:count]).to be 0
expect(stats[:age_groups]["20 - 24"][:count]).to be 7
expect(stats[:age_groups]["25 - 29"][:count]).to be 1
expect(stats[:age_groups]["30 - 34"][:count]).to be 0
expect(stats[:age_groups]["35 - 39"][:count]).to be 1
expect(stats[:age_groups]["40 - 44"][:count]).to be 1
expect(stats[:age_groups]["45 - 49"][:count]).to be 0
expect(stats[:age_groups]["50 - 54"][:count]).to be 1
expect(stats[:age_groups]["55 - 59"][:count]).to be 0
expect(stats[:age_groups]["60 - 64"][:count]).to be 0
expect(stats[:age_groups]["65 - 69"][:count]).to be 0
expect(stats[:age_groups]["70 - 74"][:count]).to be 0
end
end
@@ -170,7 +170,7 @@ describe Budget::Stats do
context "#male_percentage" do
it "returns the percentage of male participants" do
expect(@stats[:male_percentage]).to be 40.0
expect(stats[:male_percentage]).to be 40.0
end
end
@@ -178,7 +178,7 @@ describe Budget::Stats do
context "#female_percentage" do
it "returns the percentage of female participants" do
expect(@stats[:female_percentage]).to be 60.0
expect(stats[:female_percentage]).to be 60.0
end
end
@@ -186,7 +186,7 @@ describe Budget::Stats do
context "#headings" do
it "returns headings data" do
heading_stats = @stats[:headings][@heading.id]
heading_stats = stats[:headings][@heading.id]
expect(heading_stats[:total_investments_count]).to be 5
expect(heading_stats[:total_participants_support_phase]).to be 2
expect(heading_stats[:total_participants_vote_phase]).to be 4