consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #4050 from consul/stemming_spec

Browse Source 
Improve test checking order by relevance
This commit is contained in:
Javier Martín
2020-07-14 18:12:21 +02:00
committed by GitHub
parent ae0fb131d4 d9eeb1ad15
commit 53f054ff69
3 changed files with 10 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
spec/models/debate_spec.rb
View File

@@ -503,7 +503,8 @@ describe Debate do
end
context "stemming" do
it "searches word stems in Spanish", :spanish_search do
it "searches word stems in Spanish" do
allow(SearchDictionarySelector).to receive(:call).and_return("spanish")
debate = create(:debate, title: "limpiar")
results = Debate.search("limpiará")

4
spec/spec_helper.rb
View File

@@ -99,10 +99,6 @@ RSpec.configure do |config|
allow(Time).to receive(:zone).and_return(application_zone)
end
config.before(:each, :spanish_search) do |example|
allow(SearchDictionarySelector).to receive(:call).and_return("spanish")
end
# Allows RSpec to persist some state between runs in order to support
# the `--only-failures` and `--next-failure` CLI options.
config.example_status_persistence_file_path = "spec/examples.txt"

16
spec/system/proposals_spec.rb
View File

@@ -1409,21 +1409,21 @@ describe "Proposals" do
end
end
scenario "Order by relevance by default", :spanish_search, :js do
create(:proposal, title: "Show you got", cached_votes_up: 10)
create(:proposal, title: "Show what you got", cached_votes_up: 1)
create(:proposal, title: "Show you got", cached_votes_up: 100)
scenario "Order by relevance by default", :js do
create(:proposal, title: "In summary", summary: "Title content too", cached_votes_up: 10)
create(:proposal, title: "Title content", summary: "Summary", cached_votes_up: 1)
create(:proposal, title: "Title here", summary: "Content here", cached_votes_up: 100)
visit proposals_path
fill_in "search", with: "Show what you got"
fill_in "search", with: "Title content"
click_button "Search"
expect(page).to have_selector("a.is-active", text: "relevance")
within("#proposals") do
expect(all(".proposal")[0].text).to match "Show what you got"
expect(all(".proposal")[1].text).to match "Show you got"
expect(all(".proposal")[2].text).to match "Show you got"
expect(all(".proposal")[0].text).to match "Title content"
expect(all(".proposal")[1].text).to match "Title here"
expect(all(".proposal")[2].text).to match "In summary"
end
end