Don't create featured proposals if disabled

Before we disabled featured proposals by default, there were many tests
creating them because they were needed in order to create non-featured
proposals.

But now these tests don't need to create featured proposals anymore.

spec/features/official_positions_spec.rb

@@ -49,8 +49,6 @@ describe "Official positions" do
       before do
         @proposal1 = create(:proposal, author: @user1)
         @proposal2 = create(:proposal, author: @user2)
-
-        create_featured_proposals
       end
 
       scenario "Index" do

spec/features/proposals_spec.rb

@@ -572,7 +572,6 @@ describe "Proposals" do
     end
 
     scenario "Index has a link to retired proposals list" do
-      create_featured_proposals
       not_retired = create(:proposal)
       retired = create(:proposal, :retired)
 
@@ -689,8 +688,6 @@ describe "Proposals" do
   describe "Proposal index order filters" do
 
     scenario "Default order is hot_score", :js do
-      create_featured_proposals
-
       best_proposal = create(:proposal, title: "Best proposal")
       best_proposal.update_column(:hot_score, 10)
       worst_proposal = create(:proposal, title: "Worst proposal")
@@ -705,8 +702,6 @@ describe "Proposals" do
     end
 
     scenario "Proposals are ordered by confidence_score", :js do
-      create_featured_proposals
-
       best_proposal = create(:proposal, title: "Best proposal")
       best_proposal.update_column(:confidence_score, 10)
       worst_proposal = create(:proposal, title: "Worst proposal")
@@ -728,8 +723,6 @@ describe "Proposals" do
     end
 
     scenario "Proposals are ordered by newest", :js do
-      create_featured_proposals
-
       best_proposal = create(:proposal, title: "Best proposal", created_at: Time.current)
       medium_proposal = create(:proposal, title: "Medium proposal", created_at: Time.current - 1.hour)
       worst_proposal = create(:proposal, title: "Worst proposal", created_at: Time.current - 1.day)
@@ -864,7 +857,6 @@ describe "Proposals" do
   describe "Archived proposals" do
 
     scenario "show on proposals list" do
-      create_featured_proposals
       archived_proposals = create_archived_proposals
 
       visit proposals_path
@@ -878,7 +870,6 @@ describe "Proposals" do
     end
 
     scenario "do not show in other index tabs" do
-      create_featured_proposals
       archived_proposal = create(:proposal, :archived)
 
       visit proposals_path
@@ -898,7 +889,6 @@ describe "Proposals" do
     end
 
     scenario "do not show support buttons in index" do
-      create_featured_proposals
       archived_proposals = create_archived_proposals
 
       visit proposals_path(order: "archival_date")

spec/features/tags/budget_investments_spec.rb

@@ -40,8 +40,7 @@ describe "Tags" do
     end
   end
 
-  scenario "Index shows up to 5 tags per proposal" do
-    create_featured_proposals
+  scenario "Index shows up to 5 tags per investment" do
     tag_list = ["Hacienda", "Economía", "Medio Ambiente", "Corrupción", "Fiestas populares", "Prensa"]
     create :budget_investment, heading: heading, tag_list: tag_list
 

spec/features/tags/proposals_spec.rb

@@ -3,7 +3,6 @@ require "rails_helper"
 describe "Tags" do
 
   scenario "Index" do
-    create_featured_proposals
     earth = create(:proposal, tag_list: "Medio Ambiente")
     money = create(:proposal, tag_list: "Economía")
 
@@ -19,7 +18,6 @@ describe "Tags" do
   end
 
   scenario "Index shows up to 5 tags per proposal" do
-    create_featured_proposals
     tag_list = ["Hacienda", "Economía", "Medio Ambiente", "Corrupción", "Fiestas populares", "Prensa"]
     create :proposal, tag_list: tag_list
 
@@ -31,7 +29,6 @@ describe "Tags" do
   end
 
   scenario "Index featured proposals does not show tags" do
-    featured_proposals = create_featured_proposals
     proposal = create(:proposal, tag_list: "123")
 
     visit proposals_path(tag: "123")
@@ -41,7 +38,6 @@ describe "Tags" do
   end
 
   scenario "Index shows 3 tags with no plus link" do
-    create_featured_proposals
     tag_list = ["Medio Ambiente", "Corrupción", "Fiestas populares"]
     create :proposal, tag_list: tag_list
 
@@ -192,7 +188,6 @@ describe "Tags" do
   context "Filter" do
 
     scenario "From index" do
-      create_featured_proposals
       proposal1 = create(:proposal, tag_list: "Education")
       proposal2 = create(:proposal, tag_list: "Health")
 

spec/features/votes_spec.rb

@@ -254,7 +254,6 @@ describe "Votes" do
       end
 
       scenario "Create in listed proposal in index", :js do
-        create_featured_proposals
         visit proposals_path
 
         within("#proposal_#{@proposal.id}") do