consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Extract method to render number and info

Browse Source 
We're going to use it in many places, so removing duplication is useful.
This commit is contained in:
Javi Martín
2019-01-04 19:19:07 +01:00
parent 1c9552b922
commit 4ade857a1b
2 changed files with 21 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/helpers/stats_helper.rb
View File

@@ -34,4 +34,10 @@ module StatsHelper
def number_to_stats_percentage(number, options = {})
number_to_percentage(number, { strip_insignificant_zeros: true, precision: 2 }.merge(options))
end
def number_with_info_tags(number, text, html_class: "")
content_tag :p, class: "number-with-info #{html_class}".strip do
content_tag(:span, number, class: "number") + content_tag(:span, text, class: "info")
end
end
end

33
app/views/shared/stats/_participation.html.erb
View File

@@ -4,30 +4,27 @@
<div id="total_participants" class="stats-group">
<h4><%= t("stats.total_participants") %></h4>
<p class="number-with-info participants total-participants">
<span class="number"><%= stats[:total_participants] %></span>
<span class="info"><%= t("polls.show.stats.total_votes") %></span>
</p>
<%= number_with_info_tags(
stats[:total_participants],
t("polls.show.stats.total_votes"),
html_class: "participants total-participants"
) %>
</div>
<div id="participants_by_gender" class="stats-group">
<h4><%= t("stats.by_gender") %></h4>
<p class="number-with-info participants male">
<span class="number"><%= stats[:total_male_participants] %></span>
<span class="info">
<%= I18n.t("stats.men_percentage",
percentage: number_to_stats_percentage(stats[:male_percentage])) %>
</span>
</p>
<%= number_with_info_tags(
stats[:total_male_participants],
t("stats.men_percentage", percentage: number_to_stats_percentage(stats[:male_percentage])),
html_class: "participants male"
) %>
<p class="number-with-info participants female">
<span class="number"><%= stats[:total_female_participants] %></span>
<span class="info">
<%= I18n.t("stats.women_percentage",
percentage: number_to_stats_percentage(stats[:female_percentage])) %>
</span>
</p>
<%= number_with_info_tags(
stats[:total_female_participants],
t("stats.women_percentage", percentage: number_to_stats_percentage(stats[:female_percentage])),
html_class: "participants female"
) %>
</div>
<div id="participants_by_age" class="stats-group">