Improved tests

spec/factories/legislations.rb

@@ -66,6 +66,18 @@ FactoryBot.define do
       result_publication_date { Date.current + 5.days }
     end
 
+    trait :in_proposals_phase do
+      proposals_phase_start_date { Date.current - 1.day }
+      proposals_phase_end_date { Date.current + 2.days }
+      proposals_phase_enabled true
+    end
+
+    trait :upcoming_proposals_phase do
+      proposals_phase_start_date { Date.current + 1.day }
+      proposals_phase_end_date { Date.current + 2.days }
+      proposals_phase_enabled true
+    end
+
     trait :published do
       published true
     end

spec/features/legislation/processes_spec.rb

@@ -240,7 +240,7 @@ feature 'Legislation' do
 
     context 'proposals phase' do
       scenario 'not open' do
-        process = create(:legislation_process, proposals_phase_start_date: Date.current + 1.day, proposals_phase_end_date: Date.current + 2.days)
+        process = create(:legislation_process, :upcoming_proposals_phase)
 
         visit legislation_process_proposals_path(process)
 
@@ -248,7 +248,7 @@ feature 'Legislation' do
       end
 
       scenario 'open' do
-        process = create(:legislation_process, proposals_phase_start_date: Date.current - 1.day, proposals_phase_end_date: Date.current + 2.days, proposals_phase_enabled: true)
+        process = create(:legislation_process, :in_proposals_phase)
 
         visit legislation_process_proposals_path(process)