From 388c1a9bd982f93f09d58e624c514b11c711b037 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mar=C3=ADa=20Checa?= Date: Tue, 31 Oct 2017 12:44:55 +0100 Subject: [PATCH] Improved tests --- spec/factories/legislations.rb | 12 ++++++++++++ spec/features/legislation/processes_spec.rb | 4 ++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/spec/factories/legislations.rb b/spec/factories/legislations.rb index 76dfb020c..526adc39e 100644 --- a/spec/factories/legislations.rb +++ b/spec/factories/legislations.rb @@ -66,6 +66,18 @@ FactoryBot.define do result_publication_date { Date.current + 5.days } end + trait :in_proposals_phase do + proposals_phase_start_date { Date.current - 1.day } + proposals_phase_end_date { Date.current + 2.days } + proposals_phase_enabled true + end + + trait :upcoming_proposals_phase do + proposals_phase_start_date { Date.current + 1.day } + proposals_phase_end_date { Date.current + 2.days } + proposals_phase_enabled true + end + trait :published do published true end diff --git a/spec/features/legislation/processes_spec.rb b/spec/features/legislation/processes_spec.rb index 61ade329c..92a78499d 100644 --- a/spec/features/legislation/processes_spec.rb +++ b/spec/features/legislation/processes_spec.rb @@ -240,7 +240,7 @@ feature 'Legislation' do context 'proposals phase' do scenario 'not open' do - process = create(:legislation_process, proposals_phase_start_date: Date.current + 1.day, proposals_phase_end_date: Date.current + 2.days) + process = create(:legislation_process, :upcoming_proposals_phase) visit legislation_process_proposals_path(process) @@ -248,7 +248,7 @@ feature 'Legislation' do end scenario 'open' do - process = create(:legislation_process, proposals_phase_start_date: Date.current - 1.day, proposals_phase_end_date: Date.current + 2.days, proposals_phase_enabled: true) + process = create(:legislation_process, :in_proposals_phase) visit legislation_process_proposals_path(process)