Refactor officing polls #final method to be cleaner

2017-09-11 17:47:14 +02:00
parent 93323cb917
commit 27d56ad104
1 changed files with 6 additions and 5 deletions
--- a/app/controllers/officing/polls_controller.rb
+++ b/app/controllers/officing/polls_controller.rb
@@ -6,10 +6,11 @@ class Officing::PollsController < Officing::BaseController
  end

  def final
-    @polls = current_user.poll_officer? ? current_user.poll_officer.final_days_assigned_polls : []
-    return unless current_user.poll_officer?
-
-    @polls = @polls.select {|poll| poll.ends_at > 1.week.ago && poll.expired?}
+    @polls = if current_user.poll_officer?
+               current_user.poll_officer.final_days_assigned_polls.select {|poll| poll.ends_at > 1.week.ago && poll.expired?}
+             else
+               []
+             end
  end

-end
+end