Revert "Use the same color for solid and hollow buttons"

Back in commit 5dbd69486, I said:

> I'm choosing to use the same color for solid and hollow buttons
> because these elements are usually isolated and so from the UX
> perspective they are similar; links, on the other hand, are often in
> the middle of some text.

However, I made a mistake. The crucial factor is that solid buttons
might have a light background if we choose the brand color to be a light
one, and in this case they automatically get black text. However, hollow
buttons always have a light background and so we can't use a light color
for the text and border of these buttons.
This commit is contained in:
Javi Martín
2022-10-29 01:50:32 +02:00
parent c1cd772ca8
commit 277f8b1ddc
2 changed files with 3 additions and 2 deletions

View File

@@ -134,8 +134,9 @@ button,
}
.button.hollow {
@include brand-text;
@include normal-selection;
border: 1px solid;
color: $anchor-color;
}
.button.hollow.error {

View File

@@ -23,7 +23,7 @@
@include base-button;
}
@mixin hollow-button($color: $brand) {
@mixin hollow-button($color: $anchor-color) {
@include button($style: hollow, $background: $color);
@include normal-selection;
@include base-button;