consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Simplify test checking multiple officing sessions

Browse Source 
We can reuse the `officing_verify_residence` method to make the test
easier to read.

We're also removing the final visit to final_officing_polls_path because
it doesn't really add anything to the test.
This commit is contained in:
Javi Martín
2025-03-13 12:29:53 +01:00
parent 7b6d6266e5
commit 2575fb316b
2 changed files with 4 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spec/support/common_actions/verifications.rb
View File

@@ -11,9 +11,9 @@ module Verifications
expect(page).to have_content I18n.t("verification.residence.create.flash.success")
end
def officing_verify_residence
def officing_verify_residence(document_number: "12345678Z")
select "DNI", from: "residence_document_type"
fill_in "residence_document_number", with: "12345678Z"
fill_in "residence_document_number", with: document_number
fill_in "residence_year_of_birth", with: "1980"
click_button "Validate document"

18
spec/system/officing_spec.rb
View File

@@ -130,12 +130,8 @@ describe "Poll Officing" do
in_browser(:one) do
visit new_officing_residence_path
select "DNI", from: "residence_document_type"
fill_in "residence_document_number", with: "12345678Z"
fill_in "residence_year_of_birth", with: "1980"
click_button "Validate document"
officing_verify_residence(document_number: "12345678Z")
expect(page).to have_content "Document verified with Census"
click_button "Confirm vote"
expect(page).to have_content "Vote introduced!"
expect(Poll::Voter.where(document_number: "12345678Z",
@@ -143,19 +139,12 @@ describe "Poll Officing" do
origin: "booth",
officer_id: officer1)
.count).to be(1)
visit final_officing_polls_path
expect(page).to have_content("Polls ready for final recounting")
end
in_browser(:two) do
visit new_officing_residence_path
select "DNI", from: "residence_document_type"
fill_in "residence_document_number", with: "12345678Y"
fill_in "residence_year_of_birth", with: "1980"
click_button "Validate document"
officing_verify_residence(document_number: "12345678Y")
expect(page).to have_content "Document verified with Census"
click_button "Confirm vote"
expect(page).to have_content "Vote introduced!"
expect(Poll::Voter.where(document_number: "12345678Y",
@@ -163,9 +152,6 @@ describe "Poll Officing" do
origin: "booth",
officer_id: officer2)
.count).to be(1)
visit final_officing_polls_path
expect(page).to have_content("Polls ready for final recounting")
end
end
end