consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

improves social cards info for proposals

Browse Source
This commit is contained in:
Juanjo Bazán
2015-09-18 12:34:44 +02:00
parent a60fdc8ccd
commit 1d2717a137
3 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
app/views/proposals/show.html.erb
View File

@@ -1,8 +1,9 @@
<% provide :title do %><%= @proposal.title %><% end %>
<% provide :social_media_meta_tags do %>
<%= render "shared/social_media_meta_tags",
url: proposal_url(@proposal),
title: @proposal.title,
description: @proposal.summary %>
social_url: proposal_url(@proposal),
social_title: @proposal.title,
social_description: @proposal.summary %>
<% end %>
<% cache [locale_and_user_status(@proposal), @proposal, @proposal.author, Flag.flagged?(current_user, @proposal), @proposal_votes] do %>
<section class="proposal-show">

10
app/views/shared/_social_media_meta_tags.html.erb
View File

@@ -1,16 +1,16 @@
<!-- Twitter -->
<meta name="twitter:card" content="summary" />
<meta name="twitter:site" content="@abriendomadrid" />
<meta name="twitter:title" content="<%= title %>" />
<meta name="twitter:description" content="<%= description %>" />
<meta name="twitter:title" content="<%= social_title %>" />
<meta name="twitter:description" content="<%= social_description %>" />
<meta name="twitter:image" content="https://decide.madrid.es/social-media-icon.png" />
<!-- Facebook OG -->
<meta id="ogtitle" property="og:title" content="<%= title %>"/>
<meta id="ogtitle" property="og:title" content="<%= social_title %>"/>
<meta property="article:publisher" content="http://decide.madrid.es"/>
<meta property="article:author" content="https://www.facebook.com/Ayuntamiento-de-Madrid-770904446353931"/>
<meta property="og:type" content="article"/>
<meta id="ogurl" property="og:url" content="<%= url %>"/>
<meta id="ogurl" property="og:url" content="<%= social_url %>"/>
<meta id="ogimage" property="og:image" content="https://decide.madrid.es/social-media-icon.png"/>
<meta property="og:site_name" content="Madrid Participación"/>
<meta id="ogdescription" property="og:description" content="<%= description %>"/>
<meta id="ogdescription" property="og:description" content="<%= social_description %>"/>
<meta property="fb:app_id" content="1662598980652932"/>

1
spec/features/proposals_spec.rb
View File

@@ -47,6 +47,7 @@ feature 'Proposals' do
expect(page).to have_content proposal.author.name
expect(page).to have_content I18n.l(proposal.created_at.to_date)
expect(page).to have_selector(avatar(proposal.author.name))
expect(page.html).to include "<title>#{proposal.title}</title>"
within('.social-share-button') do
expect(page.all('a').count).to be(3) # Twitter, Facebook, Google+