consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid using xpath in specs

Browse Source 
Using xpath is usually harder to read and more fragile.
This commit is contained in:
Javi Martín
2018-09-27 17:44:03 +02:00
parent 959270b0bb
commit 0945f046a3
2 changed files with 14 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/views/admin/legislation/proposals/_proposals.html.erb
View File

@@ -3,7 +3,7 @@
<%= render 'shared/wide_order_selector', i18n_namespace: "admin.legislation.processes.proposals" %>
<table class="stack" id="proposals_table">
<table class="stack" id="legislation_proposals_list">
<thead>
<tr>
<th class="text-center"><%= t("admin.legislation.proposals.index.id") %></th>
@@ -15,7 +15,7 @@
<tbody>
<% proposals.each do |proposal| %>
<tr id="<%= dom_id(proposal) %>">
<tr id="<%= dom_id(proposal) %>" class="legislation_proposal">
<td class="text-center"><%= proposal.id %></td>
<td><%= proposal.title %></td>
<td class="text-center"><%= proposal.cached_votes_up %></td>

36
spec/features/admin/legislation/proposals_spec.rb
View File

@@ -42,16 +42,10 @@ feature 'Admin legislation processes' do
visit admin_legislation_process_proposals_path(process.id)
select "Title", from: "order-selector-participation"
within('#proposals_table') do
within(:xpath, "//tbody/tr[1]") do
expect(page).to have_content('aaaa')
end
within(:xpath, "//tbody/tr[2]") do
expect(page).to have_content('bbbb')
end
within(:xpath, "//tbody/tr[3]") do
expect(page).to have_content('cccc')
end
within('#legislation_proposals_list') do
within all('.legislation_proposal')[0] { expect(page).to have_content('aaaa') }
within all('.legislation_proposal')[1] { expect(page).to have_content('bbbb') }
within all('.legislation_proposal')[2] { expect(page).to have_content('cccc') }
end
end
@@ -64,10 +58,10 @@ feature 'Admin legislation processes' do
visit admin_legislation_process_proposals_path(process.id)
select "Supports", from: "order-selector-participation"
within('#proposals_table') do
within(:xpath, "//tbody/tr[1]") { expect(page).to have_content('30') }
within(:xpath, "//tbody/tr[2]") { expect(page).to have_content('20') }
within(:xpath, "//tbody/tr[3]") { expect(page).to have_content('10') }
within('#legislation_proposals_list') do
within all('.legislation_proposal')[0] { expect(page).to have_content('30') }
within all('.legislation_proposal')[1] { expect(page).to have_content('20') }
within all('.legislation_proposal')[2] { expect(page).to have_content('10') }
end
end
@@ -80,16 +74,10 @@ feature 'Admin legislation processes' do
visit admin_legislation_process_proposals_path(process.id, order: :title)
select "Id", from: "order-selector-participation"
within('#proposals_table') do
within(:xpath, "//tbody/tr[1]") do
expect(page).to have_content(proposal1.id)
end
within(:xpath, "//tbody/tr[2]") do
expect(page).to have_content(proposal2.id)
end
within(:xpath, "//tbody/tr[3]") do
expect(page).to have_content(proposal3.id)
end
within('#legislation_proposals_list') do
within all('.legislation_proposal')[0] { expect(page).to have_content(proposal1.id) }
within all('.legislation_proposal')[1] { expect(page).to have_content(proposal2.id) }
within all('.legislation_proposal')[2] { expect(page).to have_content(proposal3.id) }
end
end
end