Allow toggling the column selector with a keyboard

Using a button tag, it's possible for every user to "click" the element.
Besides, we don't need to call the `preventDefault` function, because
buttons with type "button" don't do anything by default.
This commit is contained in:
Javi Martín
2021-02-05 13:38:25 +01:00
parent 945d723fef
commit 00dfa95902
3 changed files with 9 additions and 16 deletions

View File

@@ -33,8 +33,7 @@
$("#js-columns-selector-wrapper").append(item);
});
},
toggleOptions: function(event) {
event.preventDefault();
toggleOptions: function() {
$("#js-columns-selector").toggleClass("hollow");
$("#js-columns-selector-wrapper").toggleClass("hidden");
},
@@ -73,8 +72,8 @@
App.ColumnsSelector.initChecks();
App.ColumnsSelector.initColumns();
$("#js-columns-selector").on({
click: function(event) {
App.ColumnsSelector.toggleOptions(event);
click: function() {
App.ColumnsSelector.toggleOptions();
}
});
$(".column-selector-item input").on({