diff --git a/app/assets/javascripts/columns_selector.js b/app/assets/javascripts/columns_selector.js
index 2f680b7c6..4c5201cd3 100644
--- a/app/assets/javascripts/columns_selector.js
+++ b/app/assets/javascripts/columns_selector.js
@@ -33,8 +33,7 @@
$("#js-columns-selector-wrapper").append(item);
});
},
- toggleOptions: function(event) {
- event.preventDefault();
+ toggleOptions: function() {
$("#js-columns-selector").toggleClass("hollow");
$("#js-columns-selector-wrapper").toggleClass("hidden");
},
@@ -73,8 +72,8 @@
App.ColumnsSelector.initChecks();
App.ColumnsSelector.initColumns();
$("#js-columns-selector").on({
- click: function(event) {
- App.ColumnsSelector.toggleOptions(event);
+ click: function() {
+ App.ColumnsSelector.toggleOptions();
}
});
$(".column-selector-item input").on({
diff --git a/app/views/admin/shared/_columns_selector.html.erb b/app/views/admin/shared/_columns_selector.html.erb
index dfae1d808..9e8ea9926 100644
--- a/app/views/admin/shared/_columns_selector.html.erb
+++ b/app/views/admin/shared/_columns_selector.html.erb
@@ -1,7 +1,7 @@
-">
+
+
diff --git a/spec/system/admin/budget_investments_spec.rb b/spec/system/admin/budget_investments_spec.rb
index 5e4241bb6..738363ac3 100644
--- a/spec/system/admin/budget_investments_spec.rb
+++ b/spec/system/admin/budget_investments_spec.rb
@@ -1825,9 +1825,7 @@ describe "Admin budget investments", :admin do
scenario "Use column selector to display visible columns", :js do
visit admin_budget_budget_investments_path(budget)
- within("#js-columns-selector") do
- find("strong", text: "Columns").click
- end
+ click_button "Columns"
within("#js-columns-selector-wrapper") do
selectable_columns.each do |column|
@@ -1857,9 +1855,7 @@ describe "Admin budget investments", :admin do
scenario "Cookie will be updated after change columns selection", :js do
visit admin_budget_budget_investments_path(budget)
- within("#js-columns-selector") do
- find("strong", text: "Columns").click
- end
+ click_button "Columns"
within("#js-columns-selector-wrapper") do
uncheck "Title"
@@ -1889,7 +1885,7 @@ describe "Admin budget investments", :admin do
investment.update!(title: "Don't display me, please!")
visit admin_budget_budget_investments_path(budget)
- within("#js-columns-selector") { find("strong", text: "Columns").click }
+ click_button "Columns"
within("#js-columns-selector-wrapper") { uncheck "Title" }
within("#budget_investment_#{investment.id}") do
@@ -1909,9 +1905,7 @@ describe "Admin budget investments", :admin do
go_back
- within("#js-columns-selector") do
- find("strong", text: "Columns").click
- end
+ click_button "Columns"
within("#js-columns-selector-wrapper") do
selectable_columns.each do |column|