Commit Graph

20385 Commits

Author SHA1 Message Date
Javi Martín
cc3f8d682d Merge pull request #6014 from consuldemocracy/stringio-3.1.1
Upgrade default gems included in Ruby 3.3.8
2025-06-30 15:20:01 +02:00
Javi Martín
11b0b8be44 Bump irb from 1.12.0 to 1.13.1
Version 1.13.1 is the default one in Ruby 3.3.8. The reason we're
updating it is that IRB improves in every version of Ruby, making
development a bit easier.

We're also upgrading the reline gem (which IRB depends on) to the
version included in Ruby 3.3.8.
2025-06-30 14:58:02 +02:00
Javi Martín
847e8b28f5 Merge pull request #6018 from consuldemocracy/username_message
Avoid side-effects when removing username message
2025-06-27 16:08:48 +02:00
Javi Martín
9c13a331ec Avoid side-effects when removing username message
In the registration form, after changing the username, we were removing
the message about whether a username was available. However, we were
also removing every `<small>` tag on the page. This affected the demo
branch, where we add a `<small>` tag on every page.

So we're now removing a specific element instead.
2025-06-27 15:52:33 +02:00
Sebastia
93396c676b Merge pull request #5967 from consuldemocracy/update_readme
Update readme
2025-06-23 10:13:05 +02:00
Sebastia
b9fca0af98 Merge pull request #6011 from consuldemocracy/update-pr-template
Update Pull Request template
2025-06-23 10:12:19 +02:00
Lucía Luzuriaga
4ffae5a6fa Add links to OS-specific installation guides in README 2025-06-20 16:58:50 +02:00
Lucía Luzuriaga
58b3f09595 Improve Pull Request template 2025-06-20 15:36:05 +02:00
Javi Martín
edf3821cbe Bump stringio from 3.1.0 to 3.1.1
Version 3.1.1 is the one included by default in Ruby 3.3.8. We were
getting an error when running `rspec` without `bundle  exec` because we
had an earlier version of that gem in our Gemfile.
2025-06-18 16:47:27 +02:00
Sebastia
1d12974a27 Merge pull request #6006 from consuldemocracy/dependabot/bundler/rubocop-1.75.8
Bump rubocop from 1.71.2 to 1.76.1
2025-06-16 17:22:00 +02:00
Sebastia
92cb0453cc Merge pull request #6007 from consuldemocracy/dependabot/bundler/graphql-2.5.8
Bump graphql from 2.4.13 to 2.5.8
2025-06-16 16:50:12 +02:00
taitus
13dbead27d Add Style/RedundantArrayFlatten Rubocop 1.76 rule
This rule was introduced in RuboCop 1.76.0 to avoid flattening arrays
when it has no effect.
2025-06-16 16:22:43 +02:00
taitus
9763799a8c Add Style/EmptyStringInsideInterpolation Rubocop 1.76 rule
This rule was introduced in RuboCop 1.76.0 to avoid unnecessary interpolation
of empty strings.
2025-06-16 16:07:35 +02:00
taitus
b9bffeb321 Add and apply Naming/PredicateMethod RuboCop 1.76 rule
This rule was introduced in RuboCop 1.76.0 to ensure methods ending
in '?' return boolean.

This commit applies suggested renames and code cleanup:
- Renames 'is_active?' to 'active_class' since it returns a string
- Renames 'parsed_value' to 'in_favor?' and 'is_request_active' to end with '?'
  for boolean semantics
- Skips false positives like 'save', 'auto_labels' or 'save_requiring_finish_signup',
  which are not predicate methods.
2025-06-16 16:07:35 +02:00
taitus
d123297ba6 Add and apply Style/ComparableBetween RuboCop rule
This rule was introduced in RuboCop 1.74 to prefer using between?
over chained comparison operators.
2025-06-16 16:07:35 +02:00
dependabot[bot]
123c97771a Bump rubocop from 1.71.2 to 1.75.8
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.71.2 to 1.75.8.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop/compare/v1.71.2...v1.75.8)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-version: 1.75.8
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Notes:

This commit also includes several style and lint fixes required after
updating RuboCop:

- Removed redundant parentheses now detected by improved
  'Style/RedundantParentheses' (1.72 and 1.75.3).
- Replaced ternary expressions with logical OR when the ternary was
  returning 'true', as flagged by 'Style/RedundantCondition' (1.73).
- Adjusted block variables to resolve new 'Lint/ShadowingOuterLocalVariable'
  offenses (1.75), helping avoid future conflicts during upgrades with
  'rails app:updates'

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-16 16:07:32 +02:00
Sebastia
6225f01710 Merge pull request #6012 from consuldemocracy/dependabot/npm_and_yarn/brace-expansion-1.1.12
Bump brace-expansion from 1.1.11 to 1.1.12
2025-06-16 15:59:16 +02:00
Sebastia
c9b9544880 Merge pull request #6005 from consuldemocracy/dependabot/bundler/pronto-0.11.4
Bump pronto from 0.11.3 to 0.11.4
2025-06-16 15:44:57 +02:00
dependabot[bot]
ec81a397be Bump pronto from 0.11.3 to 0.11.4
Bumps [pronto](https://github.com/prontolabs/pronto) from 0.11.3 to 0.11.4.
- [Release notes](https://github.com/prontolabs/pronto/releases)
- [Changelog](https://github.com/prontolabs/pronto/blob/master/CHANGELOG.md)
- [Commits](https://github.com/prontolabs/pronto/compare/v0.11.3...v0.11.4)

---
updated-dependencies:
- dependency-name: pronto
  dependency-version: 0.11.4
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-16 15:23:11 +02:00
Sebastia
82bc9e016e Merge pull request #5976 from consuldemocracy/dependabot/bundler/sprockets-4.2.2
Bump sprockets from 4.2.1 to 4.2.2
2025-06-16 13:12:42 +02:00
dependabot[bot]
15616758b1 Bump brace-expansion from 1.1.11 to 1.1.12
Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion) from 1.1.11 to 1.1.12.
- [Release notes](https://github.com/juliangruber/brace-expansion/releases)
- [Commits](https://github.com/juliangruber/brace-expansion/compare/1.1.11...v1.1.12)

---
updated-dependencies:
- dependency-name: brace-expansion
  dependency-version: 1.1.12
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-12 09:11:01 +00:00
Sebastia
ef732732b7 Merge pull request #6004 from consuldemocracy/dependabot/bundler/knapsack_pro-8.3.0
Bump knapsack_pro from 7.8.0 to 8.3.0
2025-06-12 11:09:54 +02:00
Sebastia
06d9fd9b70 Merge pull request #5990 from consuldemocracy/imageable-specs
Regroup all tests related with imageable
2025-06-12 09:34:05 +02:00
taitus
b8583f2eae Move shared imageable specs to nested imageable specs file
In order to unify all related tests with imageable, we move shared imageable
specs and remove that file.
2025-06-12 09:14:38 +02:00
Sebastia
68445bb7fd Merge pull request #6003 from consuldemocracy/dependabot/bundler/view_component-3.23.2
Bump view_component from 3.23.1 to 3.23.2
2025-06-11 17:38:13 +02:00
dependabot[bot]
c6742f6bb2 Bump graphql from 2.4.13 to 2.5.8
Bumps [graphql](https://github.com/rmosolgo/graphql-ruby) from 2.4.13 to 2.5.8.
- [Release notes](https://github.com/rmosolgo/graphql-ruby/releases)
- [Changelog](https://github.com/rmosolgo/graphql-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rmosolgo/graphql-ruby/compare/v2.4.13...v2.5.8)

---
updated-dependencies:
- dependency-name: graphql
  dependency-version: 2.5.8
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-11 15:14:09 +00:00
Sebastia
2235315dae Merge pull request #6001 from consuldemocracy/dependabot/bundler/groupdate-6.6.0
Bump groupdate from 6.5.1 to 6.7.0
2025-06-11 17:12:45 +02:00
dependabot[bot]
cd8d3fc8d3 Bump groupdate from 6.5.1 to 6.6.0
Bumps [groupdate](https://github.com/ankane/groupdate) from 6.5.1 to 6.6.0.
- [Changelog](https://github.com/ankane/groupdate/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ankane/groupdate/compare/v6.5.1...v6.6.0)

---
updated-dependencies:
- dependency-name: groupdate
  dependency-version: 6.6.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-11 14:27:29 +00:00
dependabot[bot]
0b7e4bf49e Bump sprockets from 4.2.1 to 4.2.2
Bumps [sprockets](https://github.com/rails/sprockets) from 4.2.1 to 4.2.2.
- [Release notes](https://github.com/rails/sprockets/releases)
- [Changelog](https://github.com/rails/sprockets/blob/main/CHANGELOG.md)
- [Commits](https://github.com/rails/sprockets/compare/v4.2.1...v4.2.2)

---
updated-dependencies:
- dependency-name: sprockets
  dependency-version: 4.2.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-11 14:22:24 +00:00
dependabot[bot]
4ce272be98 Bump view_component from 3.23.1 to 3.23.2
Bumps [view_component](https://github.com/viewcomponent/view_component) from 3.23.1 to 3.23.2.
- [Release notes](https://github.com/viewcomponent/view_component/releases)
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md)
- [Commits](https://github.com/viewcomponent/view_component/compare/v3.23.1...v3.23.2)

---
updated-dependencies:
- dependency-name: view_component
  dependency-version: 3.23.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-11 14:12:09 +00:00
Sebastia
304055edbd Merge pull request #5994 from consuldemocracy/remove-legacy-ahoy-patch
Remove Ahoy ensure_uuid logic and uuidtools dependency
2025-06-11 16:10:45 +02:00
Sebastia
1d61f332c1 Merge pull request #5995 from consuldemocracy/remove-spring-gem
Remove Spring from the project
2025-06-11 15:46:24 +02:00
taitus
f45f5fe98f Remove Ahoy ensure_uuid logic and uuidtools dependency
Ahoy 2.0.0 [1] introduced automatic UUID generation for visit_token and
visitor_token. As a result, the custom ensure_uuid method is no longer
needed and can be safely removed from the initializer.

Since we aren't manually generating UUIDs anymore, we no longer need
the uuidtools dependency.

[1] https://github.com/ankane/ahoy/blob/v2.0.0/README.md#token-generation
2025-06-11 15:45:40 +02:00
Sebastia
c8c7580e25 Merge pull request #5982 from consuldemocracy/dependabot/bundler/pronto-stylelint-0.11.1
Bump pronto-stylelint from 0.11.0 to 0.11.1
2025-06-11 15:43:09 +02:00
Sebastia
0332cd3a56 Merge pull request #5996 from consuldemocracy/dependabot/bundler/selenium-webdriver-4.33.0
Bump selenium-webdriver from 4.29.1 to 4.33.0
2025-06-11 15:20:01 +02:00
taitus
11e84159d9 Remove Spring from the project
IMHO, Spring no longer provides benefits in this project and:

- Spring was already disabled in the test environment since commit e4e0cb5d47
- Rails removed Spring as a default installation option in 2021 [1]

[1] PR #42997 from https://github.com/rails/rails/
2025-06-11 15:07:17 +02:00
Sebastia
72b92b3c30 Merge pull request #5999 from consuldemocracy/dependabot/bundler/acts-as-taggable-on-12.0.0
Bump acts-as-taggable-on from 11.0.0 to 12.0.0
2025-06-11 12:27:22 +02:00
Sebastia
b986038057 Merge pull request #5998 from consuldemocracy/dependabot/bundler/wkhtmltopdf-binary-0.12.6.9
Bump wkhtmltopdf-binary from 0.12.6.8 to 0.12.6.9
2025-06-11 11:52:58 +02:00
Sebastia
c37f77aad7 Merge pull request #5997 from consuldemocracy/dependabot/bundler/exiftool_vendored-13.30.0
Bump exiftool_vendored from 12.97.0 to 13.30.0
2025-06-11 11:35:54 +02:00
dependabot[bot]
e6d1d80de1 Bump selenium-webdriver from 4.29.1 to 4.33.0
Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium) from 4.29.1 to 4.33.0.
- [Release notes](https://github.com/SeleniumHQ/selenium/releases)
- [Changelog](https://github.com/SeleniumHQ/selenium/blob/trunk/rb/CHANGES)
- [Commits](https://github.com/SeleniumHQ/selenium/commits/selenium-4.33.0)

---
updated-dependencies:
- dependency-name: selenium-webdriver
  dependency-version: 4.33.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-10 14:23:17 +00:00
dependabot[bot]
4501cc4e1c Bump pronto-stylelint from 0.11.0 to 0.11.1
Bumps [pronto-stylelint](https://github.com/kevinjalbert/pronto-stylelint) from 0.11.0 to 0.11.1.
- [Commits](https://github.com/kevinjalbert/pronto-stylelint/compare/v0.11.0...v0.11.1)

---
updated-dependencies:
- dependency-name: pronto-stylelint
  dependency-version: 0.11.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-10 15:50:51 +02:00
Sebastia
fbeae4f95e Merge pull request #5973 from consuldemocracy/dependabot/npm_and_yarn/stylelint-order-7.0.0
Bump stylelint-order from 6.0.4 to 7.0.0
2025-06-10 11:01:37 +02:00
dependabot[bot]
01f92311b7 Bump stylelint-order from 6.0.4 to 7.0.0
Bumps [stylelint-order](https://github.com/hudochenkov/stylelint-order) from 6.0.4 to 7.0.0.
- [Release notes](https://github.com/hudochenkov/stylelint-order/releases)
- [Changelog](https://github.com/hudochenkov/stylelint-order/blob/master/CHANGELOG.md)
- [Commits](https://github.com/hudochenkov/stylelint-order/compare/6.0.4...7.0.0)

---
updated-dependencies:
- dependency-name: stylelint-order
  dependency-version: 7.0.0
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-10 08:14:11 +00:00
Sebastia
887ff116ea Merge pull request #6008 from consuldemocracy/dependabot/npm_and_yarn/stylelint-16.20.0
Bump stylelint from 16.14.1 to 16.20.0
2025-06-10 10:12:05 +02:00
Sebastia
7d6bf0589d Merge pull request #5989 from consuldemocracy/nested-documentable-specs
Make nested documentable specs faster
2025-06-10 09:30:18 +02:00
taitus
49facdca7d Refactor nested document tests to simplify contexts and remove duplication 2025-06-09 17:35:40 +02:00
taitus
44cfb9bcc2 Unify lets from documentable and imageable to attachables methods 2025-06-09 17:35:40 +02:00
taitus
472e244103 Move tests related with attached documents from documentable shared specs to nested documentable file
Note that we moved some system tests to component tests, since they don't involve user interaction and can
be fully covered at the component level.
2025-06-09 17:32:41 +02:00
dependabot[bot]
09acb6afd5 Bump stylelint from 16.14.1 to 16.20.0
Bumps [stylelint](https://github.com/stylelint/stylelint) from 16.14.1 to 16.20.0.
- [Release notes](https://github.com/stylelint/stylelint/releases)
- [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md)
- [Commits](https://github.com/stylelint/stylelint/compare/16.14.1...16.20.0)

---
updated-dependencies:
- dependency-name: stylelint
  dependency-version: 16.20.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-09 14:21:32 +00:00
dependabot[bot]
8e9c3d366a Bump exiftool_vendored from 12.97.0 to 13.30.0
Bumps [exiftool_vendored](https://github.com/exiftool-rb/exiftool_vendored.rb) from 12.97.0 to 13.30.0.
- [Commits](https://github.com/exiftool-rb/exiftool_vendored.rb/compare/v12.97.0...v13.30.0)

---
updated-dependencies:
- dependency-name: exiftool_vendored
  dependency-version: 13.30.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-09 14:03:13 +00:00