Commit Graph

9394 Commits

Author SHA1 Message Date
Alberto
bc5d263a53 Merge pull request #2761 from wairbut-m2c/backport_1384-add-max-heading-number-budget-group-list
Backport 1384 add max heading number budget group list
2018-07-20 13:17:38 +02:00
Alberto
bed97347a9 Merge pull request #2762 from wairbut-m2c/backport_1208-flaky-already-voted-on-booth-cannot-vote-on-website
Backport Flaky spec: Polls Booth & Website Already voted on booth cannot vote on website
2018-07-20 13:17:24 +02:00
Raimond Garcia
593979b51a Merge pull request #2775 from consul/proposals-responsible-name
Fix validation error when creating proposals without user verification
2018-07-20 12:51:01 +02:00
Alberto
1f821a6540 Merge pull request #2714 from wairbut-m2c/fix/admin-menu-string-literal
Fix string literal warning for admin menu
2018-07-20 12:41:13 +02:00
rgarcia
2366182689 Fix specs 2018-07-20 12:28:56 +02:00
rgarcia
4cd5bb90d4 Fix validation error when creating proposals without user verification
We were getting a validation error when skipping user verification and
creating proposals

This was due to the responsible_name being empty for unverified users

As skipping user verification is a temporary setting used until Census
integration is configured, we can safely skip this validation when this
setting is active
2018-07-20 11:53:01 +02:00
rgarcia
0f287ec78d Regenerate knapsack report
This report is used to distribute specs across Travis’ build matrix
2018-07-18 23:36:55 +02:00
Alberto
3c517462e4 Merge pull request #2760 from wairbut-m2c/backport/user-recommendations
Debates and proposals recommendations for users
2018-07-16 13:54:54 +02:00
Raimond Garcia
f2c780fac6 Merge pull request #2768 from AuiDrome/add_proposal_images_on_dev_seeds
add proposal image on dev_seeds task
2018-07-16 10:35:55 +02:00
Fernando Garcia Samblas
0cf26b8770 remove add_images_to argument spaces
Sorry, at work we have a co-worker (@rochgs) that thanks this "spaced" style
because of his visual handicap. Here you are!! ;)
2018-07-16 08:48:24 +02:00
Angel Perez
1884841ffc Add Rake task to enable recommendations settings 2018-07-15 21:28:59 -04:00
Angel Perez
10efcb2029 Change I18n strings for warning when dismissing recommendations 2018-07-15 21:28:59 -04:00
Angel Perez
e194240a0a Add rake task to enable recommendations for existing users 2018-07-15 21:28:59 -04:00
Angel Perez
31c16406c0 Move disable recommendations permissions to Abilities::Common model 2018-07-15 21:28:58 -04:00
Angel Perez
54853745f0 Fix typos for Settings locales (English) 2018-07-15 21:28:58 -04:00
Angel Perez
a143fa447b Ensure recommendations are only shown when enabled 2018-07-15 21:28:58 -04:00
Angel Perez
463c753880 Recommendations are automatically disabled if dismissed by user 2018-07-15 21:28:58 -04:00
Angel Perez
0b7967440f Recommendations for users are enabled by default 2018-07-15 21:28:58 -04:00
decabeza
137078054e Fixes padding bottom on recommended index 2018-07-15 21:28:58 -04:00
decabeza
8cbc709601 Fixes margin top on recommended index 2018-07-15 21:28:58 -04:00
Angel Perez
e32387ed5b Improve CSS styles for recommendations partial 2018-07-15 21:28:58 -04:00
Angel Perez
054bc1397b Wrap recommendations settings checkboxes with label helper to improve A11y 2018-07-15 21:28:58 -04:00
Angel Perez
0ac6033ff6 Refactor recommendations specs to improve DRYness 2018-07-15 21:28:57 -04:00
Angel Perez
251441e109 Users can now hide recommendations 2018-07-15 21:28:57 -04:00
Angel Perez
fefa225f8a Add new settings for dev seeds for Debates and Proposals recommendations 2018-07-15 21:28:57 -04:00
Angel Perez
4275069a1e Include tests for recommendations feature 2018-07-15 21:28:57 -04:00
Angel Perez
a58f6a2662 Enable 'Recommended proposals' setting for users 2018-07-15 21:28:57 -04:00
Angel Perez
522c206f6d Enable 'Recommended debates' setting for users 2018-07-15 21:28:57 -04:00
decabeza
bdb3f30e40 Adds recommendations on proposals index 2018-07-15 21:28:57 -04:00
decabeza
36a5ff39b8 Adds recommendations on debates index 2018-07-15 21:28:57 -04:00
decabeza
ecb0041b7f Adds recommended index partial and styles 2018-07-15 21:28:56 -04:00
Fernando Garcia Samblas
ffbd4a08d8 add proposal image on dev_seeds task 2018-07-16 01:33:25 +02:00
Raimond Garcia
0695c2038c Merge pull request #2734 from javierv/2713-fix_flaky_update_votes_spec
Fix flaky specs: Votes Debates and Voting comments Update
2018-07-15 14:35:18 +02:00
rgarcia
225166a5eb Remove focus from specs 2018-07-15 13:58:32 +02:00
Javier Martín
32504b8840 Make Capybara check the page between votes.
As pointed out in PR #2734:

"After clicking the first link, there's an AJAX request which replaces
the existing `.in-favor a` and `.against a` links with new elements. So
if Capybara tries to click the existing `.against a` link at the same
moment it's being replaced, clicking the link won't generate a new
request".

Making Capybara check the page for new content before clicking the
second link solves the problem, in the same way 4ddc869 solved the same
problem in the comments section.
2018-07-13 22:58:12 +02:00
Angel Perez
4ddc869441 Mitigate recurrent flaky specs for voting comments 2018-07-13 22:42:41 +02:00
Alberto
38916deb0b Merge pull request #2765 from consul/budgets-polls-ui
Polls UI
2018-07-13 20:01:40 +02:00
Alberto
66020a8902 Merge pull request #2766 from consul/budget-winner-project
Budgets investment show messages
2018-07-13 19:39:46 +02:00
decabeza
230f1b1fde Removes unused i18n keys 2018-07-13 19:15:52 +02:00
decabeza
6738582029 Removes unused i18n keys 2018-07-13 19:15:13 +02:00
decabeza
bbaec57c8a Adds message in budget investment show if project is winner 2018-07-13 18:37:16 +02:00
decabeza
1116340f99 Removes participate in other polls button 2018-07-13 18:27:32 +02:00
Alberto
a10cade451 Merge pull request #2319 from wairbut-m2c/iagirre-admin-banner
Improves admin banners section
2018-07-13 18:01:54 +02:00
iagirre
ccc8d9e8ea Stub the Date and Time classes so that the test doesn't depend on the time it is run. 2018-07-13 11:59:59 +02:00
iagirre
89a3da1edf Specs modified to fit the new UI
Now, a page refresh isn't needed to see the
updated information because it is done via AJAX.
The spec has been updated to check that the
message is being correctly updated without the
refresh.
2018-07-13 11:46:09 +02:00
iagirre
f871868a2b Max headings are updated when editing heading
The max headings label is updated automatically
when updating the heading. It is done via AJAX
and a refresh isn't needed.
2018-07-13 11:46:09 +02:00
Bertocq
1f0ee32998 Add max headings label on Group list 2018-07-13 11:46:09 +02:00
Angel Perez
15f9a52035 Correct typo on English locale for banners 2018-07-12 10:17:25 -04:00
Angel Perez
306b6d8967 Fix failing admin/banners scenario 2018-07-12 10:17:25 -04:00
iagirre
0d9da5398b Fix banners in user pages
Banners were not been shown in certain pages; now
they are.

Spec to check if the banner is been shown correctly
added. Before it was in admins specs, now it has it's
own spec out of admins folder.
2018-07-12 10:17:25 -04:00