consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
6,403 Commits 1 Branch 0 Tags
2b85deabec96371f51530ca452e9011cc165f901
Commit Graph

6403 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Bertocq
2b85deabec Recalculate heading winners on incompatibility change 
Why:

* We should recalculate winners also when an incompatible investment is flagged as compatible again

How:

* Removing the condition to recalculate that was checking only for a winner investment flagged as incompatible
* Extending the Budget::Result model spec to cover that new scenario
 2017-07-10 14:24:55 +02:00
Raimond Garcia
08bc32defb Merge pull request #1728 from consul/rubocop/metrics_line_lenght 
Rubocop 🤖  The LineLength Truncation ⚡️
 2017-07-10 14:21:27 +02:00
Raimond Garcia
885d5edc3d Merge pull request #1730 from consul/chore/gemfile_cleanup 
Gemfile cleanup
 2017-07-10 14:21:16 +02:00
Bertocq
69f4e1c683 Fix all rubocop Metrics/LineLength issues (140+) 2017-07-10 13:22:49 +02:00
Bertocq
8f97bd86b7 Specify version for all gems 2017-07-10 12:52:04 +02:00
Bertocq
3f9d95f6a3 Sort all gems in Gemfile 2017-07-10 12:18:49 +02:00
Bertocq
862a30b493 Remove unnecesary comments on gemfile 2017-07-10 12:05:34 +02:00
Bertocq
100926162e Remove therubyracer gem, never used 2017-07-10 12:05:34 +02:00
Bertocq
efa2e7c774 Remove bcrypt gem, never used 2017-07-10 12:05:34 +02:00
Bertocq
5763ee03f4 Sort gem names alphabetically for dev and test groups 2017-07-10 12:05:34 +02:00
Bertocq
4e4f316f94 Reorganize development and test gems 2017-07-10 12:05:34 +02:00
Raimond Garcia
6fc5b1e8c9 Merge pull request #1735 from consul/chore/upgrade_initialjs-rails 
Upgrade initialjs-rails gem
 2017-07-10 12:03:21 +02:00
Raimond Garcia
81ac2581fb Merge pull request #1734 from consul/fix/localize_date 
Fix date localization
 2017-07-10 12:02:07 +02:00
Raimond Garcia
debb12f026 Merge pull request #1733 from consul/chore/update_code_of_conduct 
Update Code of Conduct
 2017-07-10 12:01:09 +02:00
Raimond Garcia
cd91608922 Merge pull request #1729 from consul/chore/remove_tolk 
Remove Tolk, Crowdin in use
 2017-07-10 11:51:59 +02:00
Bertocq
74e2c406d4 Upgrade initialjs-rails gem version 
In order to avoid some html validations a PR was opened https://github.com/dgilperez/initialjs-rails/pull/6 and later on merged with some extra specs coverage https://github.com/dgilperez/initialjs-rails/pull/7 Thanks @dgilperez and @decabeza!!
 2017-07-10 01:01:32 +02:00
Bertocq
51a22e8733 Fix english translation string for figcaption 2017-07-09 17:07:56 +02:00
Bertocq
824a672292 Fix spectations for localized milestone date 2017-07-09 16:44:34 +02:00
Bertocq
b1caefdf9a Use i18n to localize date on view 2017-07-09 13:44:31 +02:00
Bertocq
0b967dac89 Fix english translation for budget investment share 2017-07-09 13:37:15 +02:00
Bertocq
dd8ff5284f Update Code of Conduct to contributor covenant 1.4 2017-07-09 13:06:44 +02:00
Bertocq
3dd459f18a Fix valuation english translation to English 2017-07-09 11:59:51 +02:00
Bertocq
8b2b21c6d7 Remove Tolk, Crowdin substituted it 
Why:

* Crowdin now hosts all consul translations publicly so anyone can contribute https://crowdin.com/project/consul/invite
* Crowdin makes easy for non-tech people to contribute, once we have a demo site we'll be able to offer "on site" translation
* If you still use Tolk, we recommend removing this commit (but adding tolk gem to ./Gemfile_custom file to avoid future merge conflicts)

How:

* Reverting changes introduced with 9610a6a933
 2017-07-09 00:56:14 +02:00
Bertocq
dbc3af917a Update rubocop_todo list with rubocop --auto-gen-config 2017-07-07 21:24:45 +02:00
Bertocq
a9c928505d Fix indentation on annotator overrides scss file 2017-07-06 15:56:51 +02:00
Bertocq
631f396e75 Fix dev_seeds to comply with budget related uniqueness names 2017-07-06 11:16:53 +02:00
BertoCQ
e8e6eff679 Merge pull request #1718 from consul/migrate_locales 
Migrate localization files & Prepare Crowdin
 2017-07-05 14:29:45 +02:00
Bertocq
f58f033e1d Move existing translations into new folder structure with help of rake task 2017-07-05 13:31:50 +02:00
Bertocq
0740c3bc26 Add rake task to help migrate existing locale files to new structure 2017-07-05 13:30:05 +02:00
Bertocq
6f01db0245 Update customization guides to reflect new localization files structure 2017-07-05 13:30:05 +02:00
Bertocq
8fc2692f69 Add crowding config 2017-07-05 13:30:05 +02:00
Bertocq
355d65b998 Correct i18n tasks config file with new folder pattern, remove Spanish from i18n-task specs 2017-07-05 13:30:05 +02:00
Bertocq
552661f0e4 Add to i18n load path files in nested folders 2017-07-05 13:30:05 +02:00
BertoCQ
e990568895 Merge pull request #1721 from consul/feature/add_slugs_to_budget_related 
Add slugs to budget related
 2017-07-05 13:16:24 +02:00
BertoCQ
c439454ec7 Merge pull request #1722 from consul/chore/rubocop_cleaning 
Rubocop cleaning
 2017-07-05 13:12:09 +02:00
BertoCQ
48cc2f03a2 Merge pull request #1724 from consul/feature/add_investment_selected_checbox 
Add investment selected checbox & improve view
 2017-07-05 13:11:48 +02:00
Bertocq
512059e021 Increase Budget, Heading and Group model specs to cover slug uniqueness 
Why:

* Slug must be unique among:
 1. Budget slug: among other budgets
 2. Group slug: among other groups from its budget
 3. Heading slug: among other headings from all the groups from its budget

How:

* Adding checks for all possible scenarios on each model specs
 2017-07-05 12:33:17 +02:00
Bertocq
4068e50b33 Create rake task to generate slug for objects that use Sluggable concern 
Why:

* Once slug presence validation and usage is merged on to a code base, existing objects without it will become invalid and unusable

How:

* Running `bundle exec slugs:gnerate` will look for all models that include the concern, and generate a slug for each object
 2017-07-05 12:33:17 +02:00
Bertocq
e3d89261a6 Add Sluggable concern and unique validation to Budget, Group and Heading 
* What: We need to generate slug on Budget, Group and Heading classes, validating its unique for its scope

* How: Adding a presence and unique validation using Budget always as scope.
 2017-07-05 12:33:16 +02:00
Bertocq
4a5a164925 Ignore Style/SymbolProc rubocop cop, no strong preferences for it 2017-07-05 11:56:44 +02:00
Bertocq
2888c20489 Fix all Style/RedundantSelf rubocop issues 2017-07-05 11:55:52 +02:00
Bertocq
97d7a21791 Fix all Style/RedundantReturn rubocop issues 2017-07-05 11:55:52 +02:00
Bertocq
29b58298db Fix Style/NegatedIf rubocop issue 2017-07-05 11:55:52 +02:00
Bertocq
343da2d58e Improve admin investment view with selection/compatibility/winner flags on top 2017-07-05 11:26:59 +02:00
Bertocq
16f295ea0b Fix english translation for Heading, typo from Spanish 2017-07-04 23:54:04 +02:00
Bertocq
e35817f240 Add selected checkbox on admin investment form 2017-07-04 23:48:18 +02:00
Bertocq
39fa6ec2de Increase admin investment feature to cover selected checkbox 2017-07-04 23:47:11 +02:00
Bertocq
28970c6701 Fix all Style/UnneededInterpolation rubocop issues and remove from rubocop_tod 2017-07-04 22:44:08 +02:00
Bertocq
4535fc9345 Create Sluggable concern, generates slug using name attribute before validation 
Why:

* We need a way to generate a slug for a object given his name attribute value

How:

* A concern that generates the slug before validation
 2017-07-04 18:40:54 +02:00
Bertocq
73e0a5a88d Add to Budget Budget::Heading Budget::Group specs the sluggable shared example 
Why:

* Those classes have a slug attribute that needs to be filled

How:

* Just adding the shared example to Budget model spec, and creating the model spec file for Heading and Group to include it as well
 2017-07-04 18:40:54 +02:00