decabeza
2844c03e43
adds consistency on social media filenames
2017-07-18 11:40:19 +02:00
Bertocq
f73c0a700a
Allow social image tags to be overwritten with partial params
2017-07-17 20:35:19 +02:00
BertoCQ
6d01385e27
Merge pull request #1749 from consul/budget-results-meta
...
Budget results meta tags
2017-07-13 18:07:01 +02:00
rgarcia
c0d3ccaf46
Adds specs for loading first heading
2017-07-13 12:37:14 +02:00
rgarcia
ffb80d8c51
Loads first heading if no heading_id params present
2017-07-13 12:29:18 +02:00
rgarcia
a6baaa93ba
Adds social meta tags for budget results
2017-07-13 12:28:51 +02:00
BertoCQ
8d7a467397
Merge pull request #1746 from consul/rubocop/rails_fixes
...
Rubocop fixes 🤖 : Rails edition 💎 🛤
2017-07-11 22:28:55 +02:00
Bertocq
dd54be111d
Fix follower notifications flaky spec
2017-07-11 18:08:58 +02:00
BertoCQ
9c4eb4cef3
Merge pull request #1727 from rockandror/followable
...
Followable
2017-07-11 13:19:42 +02:00
Bertocq
fafec293e8
Remove duplicated ability for everyone
2017-07-11 12:51:39 +02:00
BertoCQ
204ea13c85
Merge branch 'master' into followable
2017-07-11 11:30:49 +02:00
Senén Rodero Rodríguez
b0ee52556c
Remove comment
2017-07-11 10:36:07 +02:00
Senén Rodero Rodríguez
503e079909
Move followable button to sidebar after social share buttons
2017-07-11 10:30:07 +02:00
Senén Rodero Rodríguez
58b1ee57cf
Set button style to followable button
2017-07-11 10:29:23 +02:00
Bertocq
5a358bce17
Fix all Rails/FilePath rubocop issues
2017-07-10 23:08:02 +02:00
Bertocq
3a54713ed0
Fix all Rails/DynamicFindBy rubocop issues
2017-07-10 23:04:27 +02:00
Bertocq
023825b4c9
Fix Rails/Present rubocop issue
2017-07-10 23:03:05 +02:00
Bertocq
beb4bc119c
Fix Rails/Delegate rubocop issue
2017-07-10 23:02:27 +02:00
Bertocq
4e0d88739d
Fix Rails/Blank rubocop issue
2017-07-10 23:02:27 +02:00
BertoCQ
6285ad3b68
Merge pull request #1738 from consul/feature/improve_budget_results
...
Improve budget results
2017-07-10 22:57:30 +02:00
Bertocq
11a793d63f
Hide incompatible and non-winner investments by default
2017-07-10 19:43:55 +02:00
Bertocq
49f48ddf4b
Highlight current heading on results list
2017-07-10 17:48:04 +02:00
Bertocq
741a342bb0
Restrict compatilibility edit on admin investment form
...
Why:
* A non-winner but compatible investment shouldn't be marked as incompatible
How:
* Show incompatilibility checkbox only if investment is winner or incompatible
2017-07-10 17:34:05 +02:00
Bertocq
2fba9de33b
Don't display incompatible investment's table if empty
2017-07-10 17:12:28 +02:00
Bertocq
3a94fe4cc2
Fix indentation on if-else assignement
2017-07-10 16:03:31 +02:00
Bertocq
efacd0def3
Make calculate_winners explicitly delayed
...
Why:
* As seen on preproduction and production environments on Madrid's fork. Budget::Result#calculate_winners is very costly when done to all headings for a given budget (as requested on Admin::BudgetsController#calculate_winners) but its not when done individually for only a heading (as requested on Budget::Investment#recalculate_heading_winners)
How:
* Removing `handle_asynchronously :calculate_winners` from bellow Budget::Result#calculate_winners definition, to avoid making any call delayed. And explicitly calling `.delay` only when needed (on Admin::BudgetsController#calculate_winners)
2017-07-10 15:12:14 +02:00
Bertocq
2b85deabec
Recalculate heading winners on incompatibility change
...
Why:
* We should recalculate winners also when an incompatible investment is flagged as compatible again
How:
* Removing the condition to recalculate that was checking only for a winner investment flagged as incompatible
* Extending the Budget::Result model spec to cover that new scenario
2017-07-10 14:24:55 +02:00
Raimond Garcia
08bc32defb
Merge pull request #1728 from consul/rubocop/metrics_line_lenght
...
Rubocop 🤖 The LineLength Truncation ⚡ ️
2017-07-10 14:21:27 +02:00
Raimond Garcia
885d5edc3d
Merge pull request #1730 from consul/chore/gemfile_cleanup
...
Gemfile cleanup
2017-07-10 14:21:16 +02:00
Bertocq
69f4e1c683
Fix all rubocop Metrics/LineLength issues (140+)
2017-07-10 13:22:49 +02:00
Bertocq
8f97bd86b7
Specify version for all gems
2017-07-10 12:52:04 +02:00
Senén Rodero Rodríguez
95630d6546
Add comment to temporary bugfix.
2017-07-10 12:46:31 +02:00
Bertocq
3f9d95f6a3
Sort all gems in Gemfile
2017-07-10 12:18:49 +02:00
Bertocq
862a30b493
Remove unnecesary comments on gemfile
2017-07-10 12:05:34 +02:00
Bertocq
100926162e
Remove therubyracer gem, never used
2017-07-10 12:05:34 +02:00
Bertocq
efa2e7c774
Remove bcrypt gem, never used
2017-07-10 12:05:34 +02:00
Bertocq
5763ee03f4
Sort gem names alphabetically for dev and test groups
2017-07-10 12:05:34 +02:00
Bertocq
4e4f316f94
Reorganize development and test gems
2017-07-10 12:05:34 +02:00
Raimond Garcia
6fc5b1e8c9
Merge pull request #1735 from consul/chore/upgrade_initialjs-rails
...
Upgrade initialjs-rails gem
2017-07-10 12:03:21 +02:00
Raimond Garcia
81ac2581fb
Merge pull request #1734 from consul/fix/localize_date
...
Fix date localization
2017-07-10 12:02:07 +02:00
Raimond Garcia
debb12f026
Merge pull request #1733 from consul/chore/update_code_of_conduct
...
Update Code of Conduct
2017-07-10 12:01:09 +02:00
Raimond Garcia
cd91608922
Merge pull request #1729 from consul/chore/remove_tolk
...
Remove Tolk, Crowdin in use
2017-07-10 11:51:59 +02:00
Bertocq
74e2c406d4
Upgrade initialjs-rails gem version
...
In order to avoid some html validations a PR was opened https://github.com/dgilperez/initialjs-rails/pull/6 and later on merged with some extra specs coverage https://github.com/dgilperez/initialjs-rails/pull/7 Thanks @dgilperez and @decabeza!!
2017-07-10 01:01:32 +02:00
Bertocq
51a22e8733
Fix english translation string for figcaption
2017-07-09 17:07:56 +02:00
Bertocq
824a672292
Fix spectations for localized milestone date
2017-07-09 16:44:34 +02:00
Bertocq
b1caefdf9a
Use i18n to localize date on view
2017-07-09 13:44:31 +02:00
Bertocq
0b967dac89
Fix english translation for budget investment share
2017-07-09 13:37:15 +02:00
Bertocq
dd8ff5284f
Update Code of Conduct to contributor covenant 1.4
2017-07-09 13:06:44 +02:00
Bertocq
3dd459f18a
Fix valuation english translation to English
2017-07-09 11:59:51 +02:00
Bertocq
8b2b21c6d7
Remove Tolk, Crowdin substituted it
...
Why:
* Crowdin now hosts all consul translations publicly so anyone can contribute https://crowdin.com/project/consul/invite
* Crowdin makes easy for non-tech people to contribute, once we have a demo site we'll be able to offer "on site" translation
* If you still use Tolk, we recommend removing this commit (but adding tolk gem to ./Gemfile_custom file to avoid future merge conflicts)
How:
* Reverting changes introduced with 9610a6a933
2017-07-09 00:56:14 +02:00
