consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
16,680 Commits 1 Branch 0 Tags
0a53f438c00b51ed98580cb0acfd3b23489a1965
Commit Graph

16680 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Javi Martín
0a53f438c0 Update Capfile to use the current capistrano 
We forgot to do so when updating Capistrano in commit c1491a7ce.
 2021-08-11 02:32:34 +02:00
dependabot[bot]
7a38ede33f Bump capistrano3-puma from 4.0.0 to 5.0.4 
Bumps [capistrano3-puma](https://github.com/seuros/capistrano-puma) from 4.0.0 to 5.0.4.
- [Release notes](https://github.com/seuros/capistrano-puma/releases)
- [Changelog](https://github.com/seuros/capistrano-puma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/seuros/capistrano-puma/compare/v4.0.0...v5.0.4)

Signed-off-by: dependabot[bot] <support@github.com>
 2021-08-10 23:54:14 +00:00
Javi Martín
3bb9275469 Merge pull request #4427 from consul/dependabot/bundler/capybara-3.35.3 
Bump capybara from 3.33.0 to 3.35.3
 2021-08-11 01:52:54 +02:00
Javi Martín
0f02116117 Merge pull request #4423 from consul/dependabot/bundler/erb_lint-0.0.37 
Bump erb_lint from 0.0.35 to 0.0.37
 2021-08-11 01:39:53 +02:00
Javi Martín
a1b4eae7d9 Merge pull request #4414 from consul/dependabot/bundler/webdrivers-4.6.0 
Bump webdrivers from 4.4.1 to 4.6.0
 2021-08-11 01:35:32 +02:00
dependabot[bot]
1bd6da4fe7 Bump erb_lint from 0.0.35 to 0.0.37 
Bumps [erb_lint](https://github.com/Shopify/erb-lint) from 0.0.35 to 0.0.37.
- [Release notes](https://github.com/Shopify/erb-lint/releases)
- [Commits](https://github.com/Shopify/erb-lint/compare/v0.0.35...v0.0.37)

Signed-off-by: dependabot[bot] <support@github.com>
 2021-08-10 23:11:50 +00:00
dependabot[bot]
e2f0e6d22f Bump capybara from 3.33.0 to 3.35.3 
Bumps [capybara](https://github.com/teamcapybara/capybara) from 3.33.0 to 3.35.3.
- [Release notes](https://github.com/teamcapybara/capybara/releases)
- [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md)
- [Commits](https://github.com/teamcapybara/capybara/compare/3.33.0...3.35.3)

Signed-off-by: dependabot[bot] <support@github.com>
 2021-08-10 23:11:49 +00:00
dependabot[bot]
f6ec007ecd Bump webdrivers from 4.4.1 to 4.6.0 
Bumps [webdrivers](https://github.com/titusfortner/webdrivers) from 4.4.1 to 4.6.0.
- [Release notes](https://github.com/titusfortner/webdrivers/releases)
- [Changelog](https://github.com/titusfortner/webdrivers/blob/master/CHANGELOG.md)
- [Commits](https://github.com/titusfortner/webdrivers/compare/v4.4.1...v4.6.0)

Signed-off-by: dependabot[bot] <support@github.com>
 2021-08-10 23:11:33 +00:00
Javi Martín
eed6697056 Merge pull request #4410 from consul/dependabot/bundler/invisible_captcha-2.0.0 
Bump invisible_captcha from 1.1.0 to 2.0.0
 2021-08-11 01:09:58 +02:00
Javi Martín
5ccf49b641 Merge pull request #4415 from consul/dependabot/bundler/audited-4.10.0 
Bump audited from 4.9.0 to 4.10.0
 2021-08-11 01:08:40 +02:00
Javi Martín
ddc2b0bfe8 Disable invisible captcha spinner 
The spinner was added in version 2.0.0, so by disabling it we're keeping
the behavior we've got in existing CONSUL installations.

The problem with the spinner is installations need to add a secret token
and share it across instances (when they've got more than one), and if
they don't, invisible captcha might report false positives.

I guess we could use `Rails.application.secrets.secret_key_base` as
secret token, but since we haven't tested this feature at all, it's
better to disable it for now.
 2021-08-11 00:53:05 +02:00
dependabot[bot]
ad17532107 Bump audited from 4.9.0 to 4.10.0 
Bumps [audited](https://github.com/collectiveidea/audited) from 4.9.0 to 4.10.0.
- [Release notes](https://github.com/collectiveidea/audited/releases)
- [Changelog](https://github.com/collectiveidea/audited/blob/master/CHANGELOG.md)
- [Commits](https://github.com/collectiveidea/audited/compare/v4.9.0...v4.10.0)

Signed-off-by: dependabot[bot] <support@github.com>
 2021-08-10 22:47:50 +00:00
dependabot[bot]
5fc927b313 Bump invisible_captcha from 1.1.0 to 2.0.0 
Bumps [invisible_captcha](https://github.com/markets/invisible_captcha) from 1.1.0 to 2.0.0.
- [Release notes](https://github.com/markets/invisible_captcha/releases)
- [Changelog](https://github.com/markets/invisible_captcha/blob/master/CHANGELOG.md)
- [Commits](https://github.com/markets/invisible_captcha/compare/v1.1.0...v2.0.0)

Signed-off-by: dependabot[bot] <support@github.com>
 2021-08-10 22:46:18 +00:00
Javi Martín
caa37975cf Merge pull request #4409 from consul/dependabot/bundler/database_cleaner-2.0.1 
Bump database_cleaner from 1.8.5 to 2.0.1
 2021-08-10 22:03:19 +02:00
dependabot[bot]
6470a8dbd0 Bump database_cleaner from 1.8.5 to 2.0.1 
Bumps [database_cleaner](https://github.com/DatabaseCleaner/database_cleaner) from 1.8.5 to 2.0.1.
- [Release notes](https://github.com/DatabaseCleaner/database_cleaner/releases)
- [Changelog](https://github.com/DatabaseCleaner/database_cleaner/blob/main/History.rdoc)
- [Commits](https://github.com/DatabaseCleaner/database_cleaner/compare/v1.8.5...v2.0.1)

Signed-off-by: dependabot[bot] <support@github.com>
 2021-08-10 19:39:41 +00:00
Javi Martín
4e6fc194cb Merge pull request #4400 from consul/dependabot/bundler/view_component-2.28.0 
Bump view_component from 2.19.1 to 2.28.0
 2021-08-10 21:19:35 +02:00
Javi Martín
405b6c80af Merge pull request #4407 from consul/dependabot/bundler/recipient_interceptor-0.3.0 
Bump recipient_interceptor from 0.2.0 to 0.3.0
 2021-08-10 15:29:46 +02:00
Javi Martín
b4bfe440bd Use with_controller_class in component tests 
This feature was introduced in view_component 2.27.0.
 2021-08-10 15:02:01 +02:00
Javi Martín
6df7f7d052 Simplify changing controllers in component tests 2021-08-10 15:00:26 +02:00
dependabot[bot]
ec7ed5496f Bump recipient_interceptor from 0.2.0 to 0.3.0 
Bumps [recipient_interceptor](https://github.com/croaky/recipient_interceptor) from 0.2.0 to 0.3.0.
- [Release notes](https://github.com/croaky/recipient_interceptor/releases)
- [Commits](https://github.com/croaky/recipient_interceptor/commits/v0.3.0)

Signed-off-by: dependabot[bot] <support@github.com>
 2021-08-10 12:46:06 +00:00
dependabot-preview[bot]
403bf87744 Bump view_component from 2.19.1 to 2.28.0 
Bumps [view_component](https://github.com/github/view_component) from 2.19.1 to 2.28.0.
- [Release notes](https://github.com/github/view_component/releases)
- [Changelog](https://github.com/github/view_component/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/view_component/compare/v2.19.1...v2.28.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2021-08-10 14:08:09 +02:00
Javi Martín
c2d16f3027 Merge pull request #4384 from consul/dependabot/bundler/rubocop-performance-1.10.1 
Bump rubocop-performance from 1.7.1 to 1.10.1
 2021-08-10 13:47:44 +02:00
Javi Martín
db4451c7c2 Add Performance/BlockGivenWithExplicitBlock rule 
We don't need to use `block_given?` since we specifically pass the block
parameter, particularly since we added the Style/ExplicitBlockArgument
rule in commit a102f3f0a.
 2021-08-10 13:31:37 +02:00
Javi Martín
e619ca992c Add and apply Performance/Sum rubocop rule 
We're not adding it for performance reasons but because it simplifies
the code.
 2021-08-10 13:30:07 +02:00
dependabot-preview[bot]
ffc8ed738d Bump rubocop-performance from 1.7.1 to 1.10.1 
Bumps [rubocop-performance](https://github.com/rubocop/rubocop-performance) from 1.7.1 to 1.10.1.
- [Release notes](https://github.com/rubocop/rubocop-performance/releases)
- [Changelog](https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-performance/compare/v1.7.1...v1.10.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2021-08-10 13:29:42 +02:00
Javi Martín
ab9e99f45c Merge pull request #4288 from consul/dependabot/bundler/rubocop-rails-2.9.1 
Bump rubocop-rails from 2.6.0 to 2.9.1
 2021-08-10 13:23:32 +02:00
Javi Martín
bab5cbf03a Merge pull request #4215 from consul/dependabot/bundler/rubocop-0.93.1 
Bump rubocop from 0.91.1 to 0.93.1
 2021-08-10 13:15:52 +02:00
Sebastia
dabe07c1c3 Merge pull request #4594 from consul/unify-budget-views 
Render investments list when budget has multiple headings
 2021-08-10 09:44:52 +02:00
Javi Martín
815de7fb37 Merge pull request #4354 from consul/dependabot/bundler/rollbar-3.1.2 
Bump rollbar from 3.0.1 to 3.1.2
 2021-08-09 23:57:15 +02:00
Javi Martín
3865225e98 Make migrations using remove_index reversible 
These issues were detected after upgrading to rubocop-rails >= 2.8.0.
 2021-08-09 23:53:21 +02:00
Javi Martín
884fd2b27b Add and apply Rails/WhereEquals rubocop rule 
We were already following this style in most places.
 2021-08-09 23:52:47 +02:00
Javi Martín
8ae138aa19 Add and apply Rails/WhereNot rubocop rule 
We simplify the code a little bit, and make it more consistent since we
were already using `where.not` in most places.
 2021-08-09 23:52:47 +02:00
Javi Martín
69dda19af7 Add and apply Rails/PluckId rubocop rule 2021-08-09 23:52:47 +02:00
Javi Martín
8d47acc12b Add and apply Rails/ActiveRecordCallbacksOrder rule 
We were already following it most of the time.
 2021-08-09 23:52:34 +02:00
dependabot-preview[bot]
33c962c63c Bump rubocop-rails from 2.6.0 to 2.9.1 
Bumps [rubocop-rails](https://github.com/rubocop-hq/rubocop-rails) from 2.6.0 to 2.9.1.
- [Release notes](https://github.com/rubocop-hq/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-rails/compare/v2.6.0...v2.9.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2021-08-09 22:41:26 +02:00
decabeza
4a9aae9806 Add groups index page 
When render the investment list component with the link "see all
investments", now we redirect to groups index page when a budget has
multiple headings.
 2021-08-09 21:45:29 +02:00
Javi Martín
469b39ffa3 Add and apply Style/RedundantInterpolation rule 
Somehow I thought we already had this rule; must have forgotten to
actually add it.
 2021-08-09 21:37:04 +02:00
Javi Martín
3cd2529791 Fix huge header in participatory budgets 
The budget header was supposed to be huge, but only in the participatory
budgets index or show actions. It was still huge, with plenty of empty
space, when there was no budget, or in the "submit my ballot" and
"select a heading" pages.
 2021-08-09 20:07:51 +02:00
Javi Martín
297956b579 Extract placeholder selector for budget header 
This way it'll be easier to reuse its main properties.
 2021-08-09 20:07:51 +02:00
taitus
c6b23bb6fa Render investments list in all budgets types 
We make this change to unify the index/show budget pages.

This way both single and multiple budgets will render the investments
list component.
 2021-08-09 20:07:51 +02:00
Javi Martín
f92796c7fa Move list of investments tests to component tests 
In general, slow system tests requiring no interaction from the user are
good candidates to be moved to component tests because component tests
are much faster.

In this case, the system tests were also updating the database after
starting the browser, which might cause concurrency issues. We could
split the test and have one system test per phase, but IMHO there's no
need.

We're still having a couple of system tests for the happy path, in order
to make sure users actually see the list of investments.
 2021-08-09 20:07:50 +02:00
Javi Martín
9328c72aaa Simplify link to see all investments test 2021-08-09 19:46:40 +02:00
Javi Martín
d39c46468a Fix typo in investments list spec 2021-08-09 19:46:40 +02:00
Javi Martín
99bbad9b1e Add and apply Style/RedundantCondition rule 
This is a rule we generally follow all the time but accidentally forgot
in one place.
 2021-08-09 19:21:31 +02:00
Javi Martín
a102f3f0a7 Add and apply Style/ExplicitBlockArgument rule 
We were already applying it in most places.
 2021-08-09 19:11:29 +02:00
Javi Martín
4e33664055 Add and apply Lint/BooleanSymbol rubocop rule 2021-08-09 18:54:44 +02:00
Javi Martín
57d8a59d10 Add an apply Style/RaiseArgs rubocop rule 
We were already applying it most of the time.
 2021-08-09 17:32:46 +02:00
dependabot-preview[bot]
8979472820 Bump rubocop from 0.91.1 to 0.93.1 
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.91.1 to 0.93.1.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.91.1...v0.93.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2021-08-09 17:11:24 +02:00
Javi Martín
71b2d62c18 Merge pull request #4221 from consul/dependabot/bundler/rubocop-rspec-1.44.1 
Bump rubocop-rspec from 1.41.0 to 1.44.1
 2021-08-09 17:05:08 +02:00
Javi Martín
535a039a31 Add and apply RSpec/FilePath rubocop rule 
This way we make sure editors which support navigating between one class
and its test file can find the alternative files.
 2021-08-09 16:51:59 +02:00