consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #3734 from consul/remove_unused_variables

Browse Source 
Fix remaining unused variables warnings
This commit is contained in:
Javier Martín
2019-09-30 16:43:45 +02:00
committed by GitHub
parent a43a313da0 7783547419
commit c6b9bcc80d
30 changed files with 349 additions and 226 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
spec/controllers/admin/api/stats_controller_spec.rb
View File

@@ -64,9 +64,9 @@ describe Admin::Api::StatsController do
time_1 = Time.zone.local(2017, 04, 01)
time_2 = Time.zone.local(2017, 04, 02)
budget_investment1 = create(:budget_investment, created_at: time_1)
budget_investment2 = create(:budget_investment, created_at: time_2)
budget_investment3 = create(:budget_investment, created_at: time_2)
create(:budget_investment, created_at: time_1)
create(:budget_investment, created_at: time_2)
create(:budget_investment, created_at: time_2)
sign_in user
get :show, params: { budget_investments: true }

2
spec/factories/budgets.rb
View File

@@ -121,7 +121,7 @@ FactoryBot.define do
valuation_finished { true }
end
trait :unfinished do
trait :open do
valuation_finished { false }
end

2
spec/features/admin/budget_investments_spec.rb
View File

@@ -334,7 +334,7 @@ describe "Admin budget investments" do
valuator = create(:valuator, user: user)
create(:budget_investment,
:with_administrator,
:unfinished,
:open,
title: "Investment without valuation",
budget: budget,
valuators: [valuator])

2
spec/features/admin/legislation/draft_versions_spec.rb
View File

@@ -69,7 +69,7 @@ describe "Admin legislation draft versions" do
context "Update" do
scenario "Valid legislation draft version", :js do
process = create(:legislation_process, title: "An example legislation process")
draft_version = create(:legislation_draft_version, title: "Version 1", process: process)
create(:legislation_draft_version, title: "Version 1", process: process)
visit admin_root_path

9
spec/features/admin/poll/booth_assigments_spec.rb
View File

@@ -175,14 +175,15 @@ describe "Admin booths assignments" do
poll = create(:poll, starts_at: 2.weeks.ago, ends_at: 1.week.ago)
booth = create(:poll_booth)
booth_assignment = create(:poll_booth_assignment, poll: poll, booth: booth)
officer_assignment_1 = create(:poll_officer_assignment, booth_assignment: booth_assignment, date: poll.starts_at)
officer_assignment_2 = create(:poll_officer_assignment, booth_assignment: booth_assignment, date: poll.ends_at)
final_officer_assignment = create(:poll_officer_assignment, :final, booth_assignment: booth_assignment, date: poll.ends_at)
create(:poll_officer_assignment, booth_assignment: booth_assignment, date: poll.starts_at)
create(:poll_officer_assignment, booth_assignment: booth_assignment, date: poll.ends_at)
create(:poll_officer_assignment, :final, booth_assignment: booth_assignment, date: poll.ends_at)
create(:poll_voter, poll: poll, booth_assignment: booth_assignment, created_at: poll.starts_at.to_date)
create(:poll_voter, poll: poll, booth_assignment: booth_assignment, created_at: poll.ends_at.to_date)
booth_assignment_2 = create(:poll_booth_assignment, poll: poll)
create(:poll_booth_assignment, poll: poll)
visit admin_poll_path(poll)
click_link "Booths (2)"

4
spec/features/admin/poll/questions/answers/answers_spec.rb
View File

@@ -24,7 +24,7 @@ describe "Answers" do
scenario "Create second answer and place after the first one" do
question = create(:poll_question)
answer = create(:poll_question_answer, title: "First", question: question, given_order: 1)
create(:poll_question_answer, title: "First", question: question, given_order: 1)
visit admin_question_path(question)
click_link "Add answer"
@@ -40,7 +40,7 @@ describe "Answers" do
scenario "Update" do
question = create(:poll_question)
answer = create(:poll_question_answer, question: question, title: "Answer title", given_order: 2)
answer2 = create(:poll_question_answer, question: question, title: "Another title", given_order: 1)
create(:poll_question_answer, question: question, title: "Another title", given_order: 1)
visit admin_answer_path(answer)

10
spec/features/admin/poll/shifts_spec.rb
View File

@@ -13,8 +13,8 @@ describe "Admin shifts" do
booth1 = create(:poll_booth)
booth2 = create(:poll_booth)
shift1 = create(:poll_shift, officer: officer, booth: booth1, date: Date.current)
shift2 = create(:poll_shift, officer: officer, booth: booth2, date: Time.zone.tomorrow)
create(:poll_shift, officer: officer, booth: booth1, date: Date.current)
create(:poll_shift, officer: officer, booth: booth2, date: Time.zone.tomorrow)
visit new_admin_booth_shift_path(booth1)
@@ -99,8 +99,8 @@ describe "Admin shifts" do
booth = create(:poll_booth, polls: [poll])
officer = create(:poll_officer)
shift1 = create(:poll_shift, :vote_collection_task, officer: officer, booth: booth, date: Date.current)
shift2 = create(:poll_shift, :recount_scrutiny_task, officer: officer, booth: booth, date: Time.zone.tomorrow)
create(:poll_shift, :vote_collection_task, officer: officer, booth: booth, date: Date.current)
create(:poll_shift, :recount_scrutiny_task, officer: officer, booth: booth, date: Time.zone.tomorrow)
vote_collection_dates = (Date.current..poll.ends_at.to_date).to_a
.reject { |date| date == Date.current }
@@ -243,7 +243,7 @@ describe "Admin shifts" do
booth = create(:poll_booth)
officer = create(:poll_officer)
shift = create(:poll_shift, officer: officer, booth: booth)
create(:poll_shift, officer: officer, booth: booth)
officer.destroy
visit new_admin_booth_shift_path(booth)

23
spec/features/budgets/ballots_spec.rb
View File

@@ -94,16 +94,21 @@ describe "Ballots" do
end
scenario "Investments" do
city_heading1 = create(:budget_heading, group: city, name: "Above the city")
city_heading2 = create(:budget_heading, group: city, name: "Under the city")
district_heading1 = create(:budget_heading, group: districts, name: "District 1")
district_heading2 = create(:budget_heading, group: districts, name: "District 2")
create(:budget_heading, group: city, name: "Under the city")
create(:budget_investment, :selected, heading: city_heading1, title: "Solar panels")
create(:budget_investment, :selected, heading: city_heading1, title: "Observatory")
create(:budget_investment, :selected, heading: district_heading1, title: "New park")
create(:budget_investment, :selected, heading: district_heading1, title: "Zero-emission zone")
create(:budget_investment, :selected, heading: district_heading2, title: "Climbing wall")
create(:budget_heading, group: city, name: "Above the city") do |heading|
create(:budget_investment, :selected, heading: heading, title: "Solar panels")
create(:budget_investment, :selected, heading: heading, title: "Observatory")
end
create(:budget_heading, group: districts, name: "District 1") do |heading|
create(:budget_investment, :selected, heading: heading, title: "New park")
create(:budget_investment, :selected, heading: heading, title: "Zero-emission zone")
end
create(:budget_heading, group: districts, name: "District 2") do |heading|
create(:budget_investment, :selected, heading: heading, title: "Climbing wall")
end
visit budget_path(budget)
click_link "City"

3
spec/features/budgets/executions_spec.rb
View File

@@ -291,8 +291,7 @@ describe "Executions" do
scenario "Milestone not yet published" do
status = create(:milestone_status)
unpublished_milestone = create(:milestone, milestoneable: investment1,
status: status, publication_date: Date.tomorrow)
create(:milestone, milestoneable: investment1, status: status, publication_date: Date.tomorrow)
visit budget_executions_path(budget, status: status.id)

4
spec/features/budgets/investments_spec.rb
View File

@@ -1259,7 +1259,7 @@ describe "Budget Investments" do
scenario "Show (unfeasible budget investment with valuation not finished)" do
investment = create(:budget_investment,
:unfeasible,
:unfinished,
:open,
budget: budget,
heading: heading,
unfeasibility_explanation: "Local government is not competent in this matter")
@@ -1377,8 +1377,8 @@ describe "Budget Investments" do
group2 = create(:budget_group, budget: budget)
another_heading1 = create(:budget_heading, group: group2)
another_heading2 = create(:budget_heading, group: group2)
create(:budget_heading, group: group2)
create(:budget_investment, heading: heading, title: "Investment", voters: [author])
create(:budget_investment, heading: another_heading1, title: "Another investment")

7
spec/features/communities_spec.rb
View File

@@ -51,9 +51,10 @@ describe "Communities" do
topic1 = create(:topic, community: community)
topic2 = create(:topic, community: community)
topic3 = create(:topic, community: community)
topic1_comment = create(:comment, commentable: topic1)
topic3_comment = create(:comment, commentable: topic3)
topic3_comment = create(:comment, commentable: topic3)
create(:comment, :with_confidence_score, commentable: topic1)
create(:comment, :with_confidence_score, commentable: topic3)
create(:comment, :with_confidence_score, commentable: topic3)
visit community_path(community, order: :most_commented)

2
spec/features/dashboard/dashboard_spec.rb
View File

@@ -133,7 +133,7 @@ describe "Proposal's dashboard" do
scenario "Dashboard progress can unexecute proposed action" do
action = create(:dashboard_action, :proposed_action, :active)
executed_action = create(:dashboard_executed_action, proposal: proposal, action: action)
create(:dashboard_executed_action, proposal: proposal, action: action)
visit progress_proposal_dashboard_path(proposal)
expect(page).to have_content(action.title)

8
spec/features/debates_spec.rb
View File

@@ -957,10 +957,10 @@ describe "Debates" do
proposal = create(:proposal, tag_list: "Sport")
user = create(:user, recommended_debates: true, followables: [proposal])
debate1 = create(:debate, title: "Show you got", cached_votes_total: 10, tag_list: "Sport")
debate2 = create(:debate, title: "Show what you got", cached_votes_total: 1, tag_list: "Sport")
debate3 = create(:debate, title: "Do not display with same tag", cached_votes_total: 100, tag_list: "Sport")
debate4 = create(:debate, title: "Do not display", cached_votes_total: 1)
create(:debate, title: "Show you got", cached_votes_total: 10, tag_list: "Sport")
create(:debate, title: "Show what you got", cached_votes_total: 1, tag_list: "Sport")
create(:debate, title: "Do not display with same tag", cached_votes_total: 100, tag_list: "Sport")
create(:debate, title: "Do not display", cached_votes_total: 1)
login_as(user)
visit debates_path

2
spec/features/notifications_spec.rb
View File

@@ -39,7 +39,7 @@ describe "Notifications" do
scenario "View single notification" do
proposal = create(:proposal)
notification = create(:notification, user: user, notifiable: proposal)
create(:notification, user: user, notifiable: proposal)
click_notifications_icon

14
spec/features/officing/voters_spec.rb
View File

@@ -37,7 +37,7 @@ describe "Voters" do
scenario "Cannot vote" do
unvotable_poll = create(:poll, :current, geozone_restricted: true, geozones: [create(:geozone, census_code: "02")])
officer_assignment = create(:poll_officer_assignment, officer: officer, poll: unvotable_poll, booth: booth)
create(:poll_officer_assignment, officer: officer, poll: unvotable_poll, booth: booth)
set_officing_booth(booth)
visit new_officing_residence_path
@@ -87,7 +87,7 @@ describe "Voters" do
scenario "Display current polls assigned to a booth" do
poll = create(:poll, :current)
officer_assignment = create(:poll_officer_assignment, officer: officer, poll: poll, booth: booth)
create(:poll_officer_assignment, officer: officer, poll: poll, booth: booth)
set_officing_booth(booth)
visit new_officing_residence_path
@@ -99,7 +99,7 @@ describe "Voters" do
scenario "Display polls that the user can vote" do
votable_poll = create(:poll, :current, geozone_restricted: true, geozones: [Geozone.first])
officer_assignment = create(:poll_officer_assignment, officer: officer, poll: votable_poll, booth: booth)
create(:poll_officer_assignment, officer: officer, poll: votable_poll, booth: booth)
set_officing_booth(booth)
visit new_officing_residence_path
@@ -111,7 +111,7 @@ describe "Voters" do
scenario "Display polls that the user cannot vote" do
unvotable_poll = create(:poll, :current, geozone_restricted: true, geozones: [create(:geozone, census_code: "02")])
officer_assignment = create(:poll_officer_assignment, officer: officer, poll: unvotable_poll, booth: booth)
create(:poll_officer_assignment, officer: officer, poll: unvotable_poll, booth: booth)
set_officing_booth(booth)
visit new_officing_residence_path
@@ -123,7 +123,7 @@ describe "Voters" do
scenario "Do not display expired polls" do
expired_poll = create(:poll, :expired)
officer_assignment = create(:poll_officer_assignment, officer: officer, poll: expired_poll, booth: booth)
create(:poll_officer_assignment, officer: officer, poll: expired_poll, booth: booth)
set_officing_booth(booth)
visit new_officing_residence_path
@@ -140,8 +140,8 @@ describe "Voters" do
booth1 = create(:poll_booth)
booth2 = create(:poll_booth)
officer_assignment1 = create(:poll_officer_assignment, officer: officer, poll: poll1, booth: booth1)
officer_assignment2 = create(:poll_officer_assignment, officer: officer, poll: poll2, booth: booth2)
create(:poll_officer_assignment, officer: officer, poll: poll1, booth: booth1)
create(:poll_officer_assignment, officer: officer, poll: poll2, booth: booth2)
set_officing_booth(booth1)
visit new_officing_residence_path

13
spec/features/polls/polls_spec.rb
View File

@@ -84,18 +84,25 @@ describe "Polls" do
expect(page).to have_css(".unverified", count: 3)
expect(page).to have_content("You must verify your account to participate")
end
poll_district = create(:poll, geozone_restricted: true)
verified = create(:user, :level_two)
login_as(verified)
scenario "Geozone poll" do
create(:poll, geozone_restricted: true)
login_as(create(:user, :level_two))
visit polls_path
expect(page).to have_css(".cant-answer", count: 1)
expect(page).to have_content("This poll is not available on your geozone")
end
scenario "Already participated in a poll", :js do
poll_with_question = create(:poll)
question = create(:poll_question, :yes_no, poll: poll_with_question)
login_as(create(:user, :level_two))
visit polls_path
vote_for_poll_via_web(poll_with_question, question, "Yes")
visit polls_path

8
spec/features/tags/debates_spec.rb
View File

@@ -168,16 +168,16 @@ describe "Tags" do
end
scenario "From show" do
debate1 = create(:debate, tag_list: "Education")
debate2 = create(:debate, tag_list: "Health")
debate = create(:debate, tag_list: "Education")
create(:debate, tag_list: "Health")
visit debate_path(debate1)
visit debate_path(debate)
click_link "Education"
within("#debates") do
expect(page).to have_css(".debate", count: 1)
expect(page).to have_content(debate1.title)
expect(page).to have_content(debate.title)
end
end

8
spec/features/tags/proposals_spec.rb
View File

@@ -202,16 +202,16 @@ describe "Tags" do
end
scenario "From show" do
proposal1 = create(:proposal, tag_list: "Education")
proposal2 = create(:proposal, tag_list: "Health")
proposal = create(:proposal, tag_list: "Education")
create(:proposal, tag_list: "Health")
visit proposal_path(proposal1)
visit proposal_path(proposal)
click_link "Education"
within("#proposals") do
expect(page).to have_css(".proposal", count: 1)
expect(page).to have_content(proposal1.title)
expect(page).to have_content(proposal.title)
end
end

12
spec/lib/graphql_spec.rb
View File

@@ -176,9 +176,9 @@ describe "Consul Schema" do
end
it "only retruns tags with kind nil or category" do
tag = create(:tag, name: "Parks")
category_tag = create(:tag, :category, name: "Health")
admin_tag = create(:tag, name: "Admin tag", kind: "admin")
create(:tag, name: "Parks")
create(:tag, :category, name: "Health")
create(:tag, name: "Admin tag", kind: "admin")
proposal = create(:proposal, tag_list: "Parks, Health, Admin tag")
@@ -244,9 +244,9 @@ describe "Consul Schema" do
end
it "only retruns tags with kind nil or category" do
tag = create(:tag, name: "Parks")
category_tag = create(:tag, :category, name: "Health")
admin_tag = create(:tag, name: "Admin tag", kind: "admin")
create(:tag, name: "Parks")
create(:tag, :category, name: "Health")
create(:tag, name: "Admin tag", kind: "admin")
debate = create(:debate, tag_list: "Parks, Health, Admin tag")

6
spec/models/budget/ballot_spec.rb
View File

@@ -115,12 +115,10 @@ describe Budget::Ballot do
it "returns nil if there are no headings with balloted investments in a group" do
budget = create(:budget)
group = create(:budget_group, budget: budget)
heading1 = create(:budget_heading, group: group)
heading2 = create(:budget_heading, group: group)
ballot = create(:budget_ballot, budget: budget)
2.times { create(:budget_heading, group: group) }
expect(ballot.heading_for_group(group)).to eq nil
end

20
spec/models/budget/heading_spec.rb
View File

@@ -308,17 +308,25 @@ describe Budget::Heading do
describe "scope allow_custom_content" do
it "returns headings with allow_custom_content order by name" do
excluded_heading = create(:budget_heading, name: "Name A")
last_heading = create(:budget_heading, allow_custom_content: true, name: "Name C")
first_heading = create(:budget_heading, allow_custom_content: true, name: "Name B")
last_heading = create(:budget_heading, allow_custom_content: true, name: "Name B")
first_heading = create(:budget_heading, allow_custom_content: true, name: "Name A")
expect(Budget::Heading.allow_custom_content).to eq [first_heading, last_heading]
end
it "returns headings with multiple translations only once" do
create(:budget_heading, allow_custom_content: true, name_en: "English", name_es: "Spanish")
it "does not return headings which don't allow custom content" do
create(:budget_heading, name: "Name A")
expect(Budget::Heading.allow_custom_content.count).to eq 1
expect(Budget::Heading.allow_custom_content).to be_empty
end
it "returns headings with multiple translations only once" do
translated_heading = create(:budget_heading,
allow_custom_content: true,
name_en: "English",
name_es: "Spanish")
expect(Budget::Heading.allow_custom_content).to eq [translated_heading]
end
end

296
spec/models/budget/investment_spec.rb
View File

@@ -336,34 +336,53 @@ describe Budget::Investment do
end
describe "by_valuator" do
it "returns investments assigned to specific valuator" do
valuator1 = create(:valuator)
valuator2 = create(:valuator)
it "returns investments assigned to a valuator" do
alfred = create(:valuator)
batman = create(:valuator)
investment1 = create(:budget_investment, valuators: [valuator1])
investment2 = create(:budget_investment, valuators: [valuator2])
investment3 = create(:budget_investment, valuators: [valuator1, valuator2])
manor = create(:budget_investment, valuators: [alfred])
batcave = create(:budget_investment, valuators: [alfred, batman])
by_valuator = Budget::Investment.by_valuator(valuator1.id)
by_valuator = Budget::Investment.by_valuator(alfred)
expect(by_valuator).to match_array [investment1, investment3]
expect(by_valuator).to match_array [manor, batcave]
end
it "does not return investments assigned to a different valuator" do
jekyll = create(:valuator)
hyde = create(:valuator)
create(:budget_investment, valuators: [hyde])
by_valuator = Budget::Investment.by_valuator(jekyll)
expect(by_valuator).to be_empty
end
end
describe "#by_valuator_group" do
let(:aquaman) { create(:valuator) }
let(:justice_league) { create(:valuator_group, valuators: [aquaman]) }
it "returns investments assigned to a valuator's group" do
valuator = create(:valuator)
valuator_group = create(:valuator_group, valuators: [valuator])
assigned_investment = create(:budget_investment, valuators: [valuator],
valuator_groups: [valuator_group])
another_assigned_investment = create(:budget_investment, valuator_groups: [valuator_group])
unassigned_investment = create(:budget_investment, valuators: [valuator], valuator_groups: [])
create(:budget_investment, valuators: [valuator], valuator_groups: [create(:valuator_group)])
water_power = create(:budget_investment, valuator_groups: [justice_league], valuators: [aquaman])
solar_power = create(:budget_investment, valuator_groups: [justice_league])
by_valuator_group = Budget::Investment.by_valuator_group(valuator.valuator_group_id)
by_valuator_group = Budget::Investment.by_valuator_group(justice_league)
expect(by_valuator_group).to contain_exactly(assigned_investment, another_assigned_investment)
expect(by_valuator_group).to contain_exactly(solar_power, water_power)
end
it "does not return investments assigned to no groups" do
create(:budget_investment, valuators: [aquaman], valuator_groups: [])
expect(Budget::Investment.by_valuator_group(justice_league)).to be_empty
end
it "does not return investments assigned to a different group" do
create(:budget_investment, valuators: [aquaman], valuator_groups: [create(:valuator_group)])
expect(Budget::Investment.by_valuator_group(justice_league)).to be_empty
end
end
@@ -392,130 +411,199 @@ describe Budget::Investment do
describe "scopes" do
describe "valuation_open" do
it "returns all investments with false valuation_finished" do
investment1 = create(:budget_investment, :finished)
investment2 = create(:budget_investment)
it "returns investments with valuation open" do
investment = create(:budget_investment, valuation_finished: false)
valuation_open = Budget::Investment.valuation_open
expect(valuation_open).to eq [investment2]
end
end
describe "without_admin" do
it "returns all open investments without assigned admin" do
investment1 = create(:budget_investment, :finished)
investment2 = create(:budget_investment, :with_administrator)
investment3 = create(:budget_investment)
without_admin = Budget::Investment.without_admin
expect(without_admin).to eq [investment3]
end
end
describe "managed" do
it "returns all open investments with assigned admin but without assigned valuators" do
investment1 = create(:budget_investment, :with_administrator, :with_valuator)
investment2 = create(:budget_investment, :with_administrator, :finished)
investment3 = create(:budget_investment, :with_administrator)
managed = Budget::Investment.managed
expect(managed).to eq [investment3]
end
end
describe "valuating" do
it "returns all investments with assigned valuator but valuation not finished" do
investment1 = create(:budget_investment)
investment2 = create(:budget_investment, :with_valuator)
investment3 = create(:budget_investment, :with_valuator, :finished)
valuating = Budget::Investment.valuating
expect(valuating).to eq [investment2]
expect(Budget::Investment.valuation_open).to eq [investment]
end
it "returns all investments with assigned valuator groups but valuation not finished" do
investment1 = create(:budget_investment)
investment2 = create(:budget_investment, valuator_groups: [create(:valuator_group)])
investment3 = create(:budget_investment, :finished, valuator_groups: [create(:valuator_group)])
it "does not return investments with valuation finished" do
create(:budget_investment, valuation_finished: true)
valuating = Budget::Investment.valuating
expect(valuating).to eq [investment2]
expect(Budget::Investment.valuation_open).to be_empty
end
end
describe "valuation_finished" do
it "returns all investments with valuation finished" do
investment1 = create(:budget_investment)
investment2 = create(:budget_investment, :with_valuator)
investment3 = create(:budget_investment, :with_valuator, :finished)
it "returns investments with valuation finished" do
investment = create(:budget_investment, valuation_finished: true)
valuation_finished = Budget::Investment.valuation_finished
expect(Budget::Investment.valuation_finished).to eq [investment]
end
expect(valuation_finished).to eq [investment3]
it "does not return investments with valuation open" do
create(:budget_investment, valuation_finished: false)
expect(Budget::Investment.valuation_finished).to be_empty
end
end
describe "without_admin" do
it "returns open investments without assigned admin" do
investment = create(:budget_investment, :open, administrator: nil)
expect(Budget::Investment.without_admin).to eq [investment]
end
it "does not return investments with valuation finished" do
create(:budget_investment, :finished)
expect(Budget::Investment.without_admin).to be_empty
end
it "does not return investment with an admin" do
create(:budget_investment, :with_administrator)
expect(Budget::Investment.without_admin).to be_empty
end
end
describe "managed" do
it "returns open investments with assigned admin but without assigned valuators" do
investment = create(:budget_investment, :with_administrator)
expect(Budget::Investment.managed).to eq [investment]
end
it "does not return investments without assigned admin" do
create(:budget_investment, administrator: nil)
expect(Budget::Investment.managed).to be_empty
end
it "does not return investments with assigned valuator" do
create(:budget_investment, :with_administrator, :with_valuator)
expect(Budget::Investment.managed).to be_empty
end
it "does not return finished investments" do
create(:budget_investment, :with_administrator, :finished)
expect(Budget::Investment.managed).to be_empty
end
end
describe "valuating" do
it "returns investments with assigned valuator but valuation not finished" do
investment = create(:budget_investment, :open, :with_valuator)
expect(Budget::Investment.valuating).to eq [investment]
end
it "returns investments with assigned valuator groups but valuation not finished" do
investment = create(:budget_investment, :open, valuator_groups: [create(:valuator_group)])
expect(Budget::Investment.valuating).to eq [investment]
end
it "does not return investments with valuation finished" do
create(:budget_investment, :finished, :with_valuator)
create(:budget_investment, :finished, valuator_groups: [create(:valuator_group)])
expect(Budget::Investment.valuating).to be_empty
end
it "does not return investments without valuator nor valuator group" do
create(:budget_investment, :open)
expect(Budget::Investment.valuating).to be_empty
end
end
describe "feasible" do
it "returns all feasible investments" do
it "returns feasible investments" do
feasible_investment = create(:budget_investment, :feasible)
create(:budget_investment)
expect(Budget::Investment.feasible).to eq [feasible_investment]
end
it "does not return unfeasible nor undecided investments" do
create(:budget_investment, :undecided)
create(:budget_investment, :unfeasible)
expect(Budget::Investment.feasible).to be_empty
end
end
describe "unfeasible" do
it "returns all unfeasible investments" do
it "returns unfeasible investments" do
unfeasible_investment = create(:budget_investment, :unfeasible)
create(:budget_investment, :feasible)
expect(Budget::Investment.unfeasible).to eq [unfeasible_investment]
end
it "does not return feasible nor undecided investments" do
create(:budget_investment, :feasible)
create(:budget_investment, :undecided)
expect(Budget::Investment.unfeasible).to be_empty
end
end
describe "not_unfeasible" do
it "returns all feasible and undecided investments" do
unfeasible_investment = create(:budget_investment, :unfeasible)
it "returns feasible and undecided investments" do
undecided_investment = create(:budget_investment, :undecided)
feasible_investment = create(:budget_investment, :feasible)
expect(Budget::Investment.not_unfeasible).to match_array [undecided_investment, feasible_investment]
end
it "does not return unfeasible investments" do
create(:budget_investment, :unfeasible)
expect(Budget::Investment.not_unfeasible).to be_empty
end
end
describe "undecided" do
it "returns all undecided investments" do
unfeasible_investment = create(:budget_investment, :unfeasible)
it "returns undecided investments" do
undecided_investment = create(:budget_investment, :undecided)
feasible_investment = create(:budget_investment, :feasible)
expect(Budget::Investment.undecided).to eq [undecided_investment]
end
it "does not return feasible nor unfeasible investments" do
create(:budget_investment, :feasible)
create(:budget_investment, :unfeasible)
expect(Budget::Investment.undecided).to be_empty
end
end
describe "selected" do
it "returns all selected investments" do
it "returns selected investments" do
selected_investment = create(:budget_investment, :selected)
unselected_investment = create(:budget_investment, :unselected)
expect(Budget::Investment.selected).to eq [selected_investment]
end
it "does not return unselected investments" do
create(:budget_investment, :unselected)
expect(Budget::Investment.selected).to be_empty
end
end
describe "unselected" do
it "returns all unselected not_unfeasible investments" do
selected_investment = create(:budget_investment, :selected)
unselected_unfeasible_investment = create(:budget_investment, :unselected, :unfeasible)
unselected_undecided_investment = create(:budget_investment, :unselected, :undecided)
unselected_feasible_investment = create(:budget_investment, :unselected, :feasible)
expect(Budget::Investment.unselected).to match_array [unselected_undecided_investment, unselected_feasible_investment]
end
it "does not return selected investments" do
create(:budget_investment, :selected)
expect(Budget::Investment.unselected).to be_empty
end
it "does not return unfeasible investments" do
create(:budget_investment, :unselected, :unfeasible)
expect(Budget::Investment.unselected).to be_empty
end
end
describe "sort_by_title" do
@@ -734,20 +822,21 @@ describe Budget::Investment do
carabanchel = create(:budget_heading, group: group)
salamanca = create(:budget_heading, group: group)
carabanchel_investment = create(:budget_investment, heading: carabanchel, voters: [user])
salamanca_investment = create(:budget_investment, heading: salamanca)
create(:budget_investment, heading: carabanchel, voters: [user])
salamanca_investment = create(:budget_investment, heading: salamanca)
expect(salamanca_investment.valid_heading?(user)).to eq(false)
end
it "accepts votes in multiple headings of the same group" do
group.update(max_votable_headings: 2)
carabanchel = create(:budget_heading, group: group)
salamanca = create(:budget_heading, group: group)
carabanchel_investment = create(:budget_investment, heading: carabanchel, voters: [user])
salamanca_investment = create(:budget_investment, heading: salamanca)
create(:budget_investment, heading: carabanchel, voters: [user])
salamanca_investment = create(:budget_investment, heading: salamanca)
expect(salamanca_investment.valid_heading?(user)).to eq(true)
end
@@ -767,35 +856,38 @@ describe Budget::Investment do
it "allows votes in a group with a single heading" do
all_city_investment = create(:budget_investment, heading: heading)
expect(all_city_investment.valid_heading?(user)).to eq(true)
end
it "allows votes in a group with a single heading after voting in that heading" do
all_city_investment1 = create(:budget_investment, heading: heading, voters: [user])
all_city_investment2 = create(:budget_investment, heading: heading)
create(:budget_investment, heading: heading, voters: [user])
expect(all_city_investment2.valid_heading?(user)).to eq(true)
investment_for_same_heading = create(:budget_investment, heading: heading)
expect(investment_for_same_heading.valid_heading?(user)).to eq(true)
end
it "allows votes in a group with a single heading after voting in another group" do
districts = create(:budget_group, budget: budget)
carabanchel = create(:budget_heading, group: districts)
all_city_investment = create(:budget_investment, heading: heading)
carabanchel_investment = create(:budget_investment, heading: carabanchel, voters: [user])
create(:budget_investment, heading: carabanchel, voters: [user])
expect(all_city_investment.valid_heading?(user)).to eq(true)
investment_from_different_group = create(:budget_investment, heading: heading)
expect(investment_from_different_group.valid_heading?(user)).to eq(true)
end
it "allows votes in a group with multiple headings after voting in group with a single heading" do
districts = create(:budget_group, budget: budget)
carabanchel = create(:budget_heading, group: districts)
salamanca = create(:budget_heading, group: districts)
2.times { create(:budget_heading, group: districts) }
all_city_investment = create(:budget_investment, heading: heading, voters: [user])
carabanchel_investment = create(:budget_investment, heading: carabanchel)
create(:budget_investment, heading: heading, voters: [user])
expect(carabanchel_investment.valid_heading?(user)).to eq(true)
investment = create(:budget_investment, heading: districts.headings.sample)
expect(investment.valid_heading?(user)).to eq(true)
end
describe "#can_vote_in_another_heading?" do
@@ -1152,7 +1244,7 @@ describe Budget::Investment do
describe "with under_valuation filter" do
let(:params) { { advanced_filters: ["under_valuation"], budget_id: budget.id } }
it "returns only investment under valuation" do
investment1 = create(:budget_investment, :with_administrator, :unfinished, :with_valuator,
investment1 = create(:budget_investment, :with_administrator, :open, :with_valuator,
budget: budget)
create(:budget_investment, :with_administrator, budget: budget)
create(:budget_investment, budget: budget)

2
spec/models/community_spec.rb
View File

@@ -19,7 +19,7 @@ RSpec.describe Community, type: :model do
topic1 = create(:topic, community: community, author: user1)
create(:comment, commentable: topic1, author: user1)
create(:comment, commentable: topic1, author: user2)
topic2 = create(:topic, community: community, author: user2)
create(:topic, community: community, author: user2)
expect(community.participants).to match_array [user1, user2, proposal.author]
end

7
spec/models/direct_message_spec.rb
View File

@@ -36,9 +36,7 @@ describe DirectMessage do
it "is not valid if above maximum" do
sender = create(:user)
direct_message1 = create(:direct_message, sender: sender)
direct_message2 = create(:direct_message, sender: sender)
direct_message3 = create(:direct_message, sender: sender)
3.times { create(:direct_message, sender: sender) }
direct_message4 = build(:direct_message, sender: sender)
expect(direct_message4).not_to be_valid
@@ -46,8 +44,7 @@ describe DirectMessage do
it "is valid if below maximum" do
sender = create(:user)
direct_message1 = create(:direct_message, sender: sender)
direct_message2 = create(:direct_message, sender: sender)
2.times { create(:direct_message, sender: sender) }
direct_message3 = build(:direct_message, sender: sender)
expect(direct_message3).to be_valid

14
spec/models/document_spec.rb
View File

@@ -6,18 +6,18 @@ describe Document do
it_behaves_like "document validations", "proposal_document"
context "scopes" do
describe "#admin" do
it "returns admin documents" do
user_document = create(:document)
admin_document1 = create(:document, :admin)
admin_document2 = create(:document, :admin)
admin_document3 = create(:document, :admin)
admin_document = create(:document, :admin)
expect(Document.admin).to match_array [admin_document1, admin_document2, admin_document3]
expect(Document.admin).to eq [admin_document]
end
it "does not return user documents" do
create(:document, admin: false)
expect(Document.admin).to be_empty
end
end
end
end

4
spec/models/notification_spec.rb
View File

@@ -105,6 +105,7 @@ describe Notification do
user = create(:user)
comment1 = create(:comment)
comment2 = create(:comment)
create(:notification, user: user, notifiable: comment1)
expect(Notification.existent(user, comment2)).to eq(nil)
@@ -114,7 +115,8 @@ describe Notification do
user1 = create(:user)
user2 = create(:user)
comment = create(:comment)
notification = create(:notification, user: user1, notifiable: comment)
create(:notification, user: user1, notifiable: comment)
expect(Notification.existent(user2, comment)).to eq(nil)
end

42
spec/models/poll/voter_spec.rb
View File

@@ -29,19 +29,21 @@ describe Poll::Voter do
end
it "is not valid if the user has already voted in the same poll or booth_assignment" do
voter1 = create(:poll_voter, user: user, poll: poll)
voter2 = build(:poll_voter, user: user, poll: poll)
create(:poll_voter, user: user, poll: poll)
expect(voter2).not_to be_valid
expect(voter2.errors.messages[:document_number]).to eq(["User has already voted"])
voter = build(:poll_voter, user: user, poll: poll)
expect(voter).not_to be_valid
expect(voter.errors.messages[:document_number]).to eq(["User has already voted"])
end
it "is not valid if the user has already voted in the same poll/booth" do
voter1 = create(:poll_voter, user: user, poll: poll, booth_assignment: booth_assignment)
voter2 = build(:poll_voter, user: user, poll: poll, booth_assignment: booth_assignment)
create(:poll_voter, user: user, poll: poll, booth_assignment: booth_assignment)
expect(voter2).not_to be_valid
expect(voter2.errors.messages[:document_number]).to eq(["User has already voted"])
voter = build(:poll_voter, user: user, poll: poll, booth_assignment: booth_assignment)
expect(voter).not_to be_valid
expect(voter.errors.messages[:document_number]).to eq(["User has already voted"])
end
it "is not valid if the user has already voted in different booth in the same poll" do
@@ -121,25 +123,29 @@ describe Poll::Voter do
describe "#web" do
it "returns voters with a web origin" do
voter1 = create(:poll_voter, :from_web)
voter2 = create(:poll_voter, :from_web)
voter3 = create(:poll_voter, :from_booth)
voter = create(:poll_voter, :from_web)
web_voters = Poll::Voter.web
expect(Poll::Voter.web).to eq [voter]
end
expect(web_voters).to match_array [voter1, voter2]
it "does not return voters with a booth origin" do
create(:poll_voter, :from_booth)
expect(Poll::Voter.web).to be_empty
end
end
describe "#booth" do
it "returns voters with a booth origin" do
voter1 = create(:poll_voter, :from_booth)
voter2 = create(:poll_voter, :from_booth)
voter3 = create(:poll_voter, :from_web)
voter = create(:poll_voter, :from_booth)
booth_voters = Poll::Voter.booth
expect(Poll::Voter.booth).to eq [voter]
end
expect(booth_voters).to match_array [voter1, voter2]
it "does not return voters with a web origin" do
create(:poll_voter, :from_web)
expect(Poll::Voter.booth).to be_empty
end
end

10
spec/models/proposal_notification_spec.rb
View File

@@ -50,21 +50,19 @@ describe ProposalNotification do
it "is not valid if below minimum interval" do
proposal = create(:proposal)
create(:proposal_notification, proposal: proposal)
notification1 = create(:proposal_notification, proposal: proposal)
notification2 = build(:proposal_notification, proposal: proposal)
notification2 = build(:proposal_notification, proposal: proposal.reload)
proposal.reload
expect(notification2).not_to be_valid
end
it "is valid if notifications above minimum interval" do
proposal = create(:proposal)
create(:proposal_notification, proposal: proposal, created_at: 4.days.ago)
notification1 = create(:proposal_notification, proposal: proposal, created_at: 4.days.ago)
notification2 = build(:proposal_notification, proposal: proposal)
notification2 = build(:proposal_notification, proposal: proposal.reload)
proposal.reload
expect(notification2).to be_valid
end

10
spec/models/widget/card_spec.rb
View File

@@ -14,13 +14,17 @@ describe Widget::Card do
end
describe "#header" do
it "returns the header card" do
it "returns header cards" do
header = create(:widget_card, header: true)
card = create(:widget_card, header: false)
expect(Widget::Card.header).to eq([header])
end
it "does not return regular cards" do
create(:widget_card, header: false)
expect(Widget::Card.header).to be_empty
end
end
describe "#body" do

25
spec/models/widget/feed_spec.rb
View File

@@ -57,20 +57,25 @@ describe Widget::Feed do
end
describe "#processes" do
let(:feed) { build(:widget_feed, kind: "processes", limit: 3) }
it "returns open and published processes" do
open_process1 = create(:legislation_process, :open, :published, title: "Open process 1")
open_process2 = create(:legislation_process, :open, :published, title: "Open process 2")
open_process3 = create(:legislation_process, :open, :published, title: "Open process 3")
open_process4 = create(:legislation_process, :open, :published, title: "Open process 4")
open_process5 = create(:legislation_process, :open, :not_published, title: "Open process 5")
past_process = create(:legislation_process, :past, title: "Past process")
it "returns a maximum number of open published processes given by the limit" do
4.times { create(:legislation_process, :open, :published) }
feed = build(:widget_feed, kind: "processes")
expect(feed.processes).to eq([open_process4, open_process3, open_process2])
expect(feed.processes.count).to be 3
end
it "does not return past processes" do
create(:legislation_process, :past)
expect(feed.processes).to be_empty
end
it "does not return unpublished processes" do
create(:legislation_process, :open, :not_published)
expect(feed.processes).to be_empty
end
end
end