consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add missing alt attribute to special avatars

Browse Source 
The `alt` attribute is mandatory in image tags. In this case, we're
leaving it empty because we also display text showing whether comments
are made by administrators, moderators or organizations.
This commit is contained in:
Javi Martín
2024-04-08 02:44:02 +02:00
parent 2c9c5d9cd4
commit c29ad265c6
2 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/components/comments/avatar_component.html.erb
View File

@@ -1,12 +1,12 @@
<% if comment.as_administrator? %> <% if comment.as_administrator? %>
<%= image_tag("avatar_admin.png", size: 32, class: "admin-avatar float-left") %> <%= image_tag("avatar_admin.png", size: 32, class: "admin-avatar float-left", alt: "") %>
<% elsif comment.as_moderator? %> <% elsif comment.as_moderator? %>
<%= image_tag("avatar_moderator.png", size: 32, class: "moderator-avatar float-left") %> <%= image_tag("avatar_moderator.png", size: 32, class: "moderator-avatar float-left", alt: "") %>
<% else %> <% else %>
<% if comment.user.hidden? || comment.user.erased? %> <% if comment.user.hidden? || comment.user.erased? %>
<span class="icon-deleted user-deleted"></span> <span class="icon-deleted user-deleted"></span>
<% elsif comment.user.organization? %> <% elsif comment.user.organization? %>
<%= image_tag("avatar_collective.png", size: 32, class: "avatar float-left") %> <%= image_tag("avatar_collective.png", size: 32, class: "avatar float-left", alt: "") %>
<% else %> <% else %>
<%= render Shared::AvatarComponent.new(comment.user, size: 32, class: "float-left") %> <%= render Shared::AvatarComponent.new(comment.user, size: 32, class: "float-left") %>
<% end %> <% end %>

12
spec/components/comments/avatar_component_spec.rb
View File

@@ -10,30 +10,30 @@ describe Comments::AvatarComponent do
expect(page).not_to have_css "img" expect(page).not_to have_css "img"
end end
it "displays the admin avatar for admin comments" do it "displays the admin avatar with an empty alt attribute for admin comments" do
admin = create(:administrator) admin = create(:administrator)
comment = create(:comment, user: admin.user, administrator_id: admin.id) comment = create(:comment, user: admin.user, administrator_id: admin.id)
render_inline Comments::AvatarComponent.new(comment) render_inline Comments::AvatarComponent.new(comment)
expect(page).to have_css "img.admin-avatar" expect(page).to have_css "img.admin-avatar[alt='']"
end end
it "displays the moderator avatar for moderator comments" do it "displays the moderator avatar with an empty alt attribute for moderator comments" do
moderator = create(:moderator) moderator = create(:moderator)
comment = create(:comment, user: moderator.user, moderator_id: moderator.id) comment = create(:comment, user: moderator.user, moderator_id: moderator.id)
render_inline Comments::AvatarComponent.new(comment) render_inline Comments::AvatarComponent.new(comment)
expect(page).to have_css "img.moderator-avatar" expect(page).to have_css "img.moderator-avatar[alt='']"
end end
it "displays the organization avatar for organization comments" do it "displays the organization avatar with an empty alt attribute for organization comments" do
comment = create(:comment, user: create(:organization).user) comment = create(:comment, user: create(:organization).user)
render_inline Comments::AvatarComponent.new(comment) render_inline Comments::AvatarComponent.new(comment)
expect(page).to have_css "img.avatar" expect(page).to have_css "img.avatar[alt='']"
end end
it "displays an empty icon for comments by hidden users" do it "displays an empty icon for comments by hidden users" do