From c29ad265c6ee4c94936d917d6771c578e709a010 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Mon, 8 Apr 2024 02:44:02 +0200 Subject: [PATCH] Add missing alt attribute to special avatars The `alt` attribute is mandatory in image tags. In this case, we're leaving it empty because we also display text showing whether comments are made by administrators, moderators or organizations. --- app/components/comments/avatar_component.html.erb | 6 +++--- spec/components/comments/avatar_component_spec.rb | 12 ++++++------ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/app/components/comments/avatar_component.html.erb b/app/components/comments/avatar_component.html.erb index ea3a2c379..9dd1c08f8 100644 --- a/app/components/comments/avatar_component.html.erb +++ b/app/components/comments/avatar_component.html.erb @@ -1,12 +1,12 @@ <% if comment.as_administrator? %> - <%= image_tag("avatar_admin.png", size: 32, class: "admin-avatar float-left") %> + <%= image_tag("avatar_admin.png", size: 32, class: "admin-avatar float-left", alt: "") %> <% elsif comment.as_moderator? %> - <%= image_tag("avatar_moderator.png", size: 32, class: "moderator-avatar float-left") %> + <%= image_tag("avatar_moderator.png", size: 32, class: "moderator-avatar float-left", alt: "") %> <% else %> <% if comment.user.hidden? || comment.user.erased? %> <% elsif comment.user.organization? %> - <%= image_tag("avatar_collective.png", size: 32, class: "avatar float-left") %> + <%= image_tag("avatar_collective.png", size: 32, class: "avatar float-left", alt: "") %> <% else %> <%= render Shared::AvatarComponent.new(comment.user, size: 32, class: "float-left") %> <% end %> diff --git a/spec/components/comments/avatar_component_spec.rb b/spec/components/comments/avatar_component_spec.rb index 173a24c44..f9e0a2857 100644 --- a/spec/components/comments/avatar_component_spec.rb +++ b/spec/components/comments/avatar_component_spec.rb @@ -10,30 +10,30 @@ describe Comments::AvatarComponent do expect(page).not_to have_css "img" end - it "displays the admin avatar for admin comments" do + it "displays the admin avatar with an empty alt attribute for admin comments" do admin = create(:administrator) comment = create(:comment, user: admin.user, administrator_id: admin.id) render_inline Comments::AvatarComponent.new(comment) - expect(page).to have_css "img.admin-avatar" + expect(page).to have_css "img.admin-avatar[alt='']" end - it "displays the moderator avatar for moderator comments" do + it "displays the moderator avatar with an empty alt attribute for moderator comments" do moderator = create(:moderator) comment = create(:comment, user: moderator.user, moderator_id: moderator.id) render_inline Comments::AvatarComponent.new(comment) - expect(page).to have_css "img.moderator-avatar" + expect(page).to have_css "img.moderator-avatar[alt='']" end - it "displays the organization avatar for organization comments" do + it "displays the organization avatar with an empty alt attribute for organization comments" do comment = create(:comment, user: create(:organization).user) render_inline Comments::AvatarComponent.new(comment) - expect(page).to have_css "img.avatar" + expect(page).to have_css "img.avatar[alt='']" end it "displays an empty icon for comments by hidden users" do