Add feature flags on budget controllers

Although we had this feature flag in most places, we forgot to add it in
some of the controllers.
This commit is contained in:
Javi Martín
2021-03-31 14:35:05 +02:00
parent 9981202c45
commit b5bc3117ac
6 changed files with 34 additions and 0 deletions

View File

@@ -1,6 +1,8 @@
module Budgets
class GroupsController < ApplicationController
include InvestmentFilters
include FeatureFlags
feature_flag :budgets
before_action :load_budget
before_action :load_group

View File

@@ -1,5 +1,8 @@
module Budgets
class StatsController < ApplicationController
include FeatureFlags
feature_flag :budgets
before_action :load_budget
authorize_resource :budget

View File

@@ -1,5 +1,8 @@
class Management::Budgets::InvestmentsController < Management::BaseController
include Translatable
include FeatureFlags
feature_flag :budgets
before_action :load_budget
load_resource :budget

View File

@@ -4,6 +4,14 @@ describe Budgets::GroupsController do
describe "GET show" do
let(:group) { create(:budget_group) }
it "raises an exception when the feature is disabled" do
Setting["process.budgets"] = false
expect do
get :show, params: { budget_id: group.budget.id, id: group.id }
end.to raise_exception(FeatureFlags::FeatureDisabled)
end
it "raises an error if budget slug is not found" do
expect do
get :show, params: { budget_id: "wrong_budget", id: group.id }

View File

@@ -2,6 +2,14 @@ require "rails_helper"
describe Budgets::StatsController do
describe "GET show" do
it "raises an exception when the feature is disabled" do
Setting["process.budgets"] = false
expect do
get :show, params: { budget_id: create(:budget).id }
end.to raise_exception(FeatureFlags::FeatureDisabled)
end
it "raises an error if budget slug is not found" do
expect do
get :show, params: { budget_id: "wrong_budget" }

View File

@@ -8,6 +8,16 @@ describe Management::Budgets::InvestmentsController do
login_managed_user(create(:user, :level_two))
end
describe "GET index" do
it "raises an exception when the feature is disabled" do
Setting["process.budgets"] = false
expect do
get :index, params: { budget_id: create(:budget).id }
end.to raise_exception(FeatureFlags::FeatureDisabled)
end
end
describe "GET show" do
let(:investment) { create(:budget_investment) }