Fix HTML closing tags

In some places, we accidentally opened the same tag twice instead of
closing it, while in some other places we closed a tag without opening
it in the first place.

We've detected these issues thanks to the HTML Beautifier gem, which
we're about to start using for indentation purposes.

app/components/budgets/ballot/ballot_component.html.erb

@@ -9,7 +9,7 @@
     </h2>
     <p class="confirmed">
       <%= t("budgets.ballots.show.voted_info") %>
-    <p>
+    </p>
     <p><%= t("budgets.ballots.show.voted_info_2") %></p>
   </div>
 </header>

app/components/layout/cookies_consent/management_component.html.erb

@@ -9,7 +9,7 @@
       <span aria-hidden="true">&times;</span>
     </button>
   </header>
-  <p><%= t("cookies_management.description") %><p>
+  <p><%= t("cookies_management.description") %></p>
   <% if more_info_link.present? %>
     <p><%= link_to t("cookies_consent.more_info_link"), more_info_link, target: "_blank" %></p>
   <% end %>

app/components/sdg/goals/targets_component.html.erb

@@ -17,8 +17,8 @@
         <% else %>
           <dl>
             <% targets.sort.each do |target| %>
-              <dt><%= target.code %><dt>
-              <dd><%= target.long_title %><dd>
+              <dt><%= target.code %></dt>
+              <dd><%= target.long_title %></dd>
             <% end %>
           </dl>
         <% end %>

app/views/admin/activity/show.html.erb

@@ -44,6 +44,7 @@
               <br>
               <%= sanitize(activity.actionable.description) %>
             <% end %>
+          </td>
           <td class="align-top">
             <%= activity.user.name %> (<%= activity.user.email %>)
           </td>

app/views/admin/moderators/search.html.erb

@@ -22,6 +22,7 @@
           </td>
         </tr>
       <% end %>
+      </tbody>
     </table>
   <% else %>
     <div class="callout alert margin">

app/views/admin/site_customization/documents/index.html.erb

@@ -37,7 +37,7 @@
         </tr>
       <% end %>
     </tbody>
-  <table>
+  </table>
 <% else %>
   <div class="callout primary">
     <%= t("admin.documents.index.no_documents") %>

app/views/debates/index.html.erb

@@ -69,7 +69,6 @@
         <p><%= t("debates.index.section_footer.help_text_1") %></p>
         <p><%= sanitize(t("debates.index.section_footer.help_text_2",
                           org: link_to(setting["org_name"], new_user_registration_path))) %></p>
-        </p>
       </div>
     <% end %>
   </div>

app/views/devise/password_expired/show.html.erb

@@ -2,9 +2,9 @@
 
 <%= form_for(resource, as: resource_name, url: [resource_name, :password_expired], html: { method: :put }) do |f| %>
 
-  <%= f.password_field :current_password %></p>
-  <%= f.password_field :password, label: t("devise.password_expired.new_password") %></p>
-  <%= f.password_field :password_confirmation %></p>
+  <%= f.password_field :current_password %>
+  <%= f.password_field :password, label: t("devise.password_expired.new_password") %>
+  <%= f.password_field :password_confirmation %>
 
   <p><%= f.submit t("devise.password_expired.change_password") %></p>
 <% end %>

app/views/legislation/annotations/_comment_header.html.erb

@@ -2,4 +2,4 @@
 
 <span id="annotation-link" data-sub-annotation-ids="8">
   <%= render "annotation_link", annotation: annotation %>
-<span>
+</span>

app/views/legislation/questions/show.html.erb

@@ -13,14 +13,14 @@
         <%= link_to legislation_process_question_path(@process, @question.next_question_id), class: "quiz-next-link" do %>
           <div class="quiz-next">
             <%= t("legislation.questions.show.next_question") %>
-            <span class="icon-angle-right" aria-hidden="true">
+            <span class="icon-angle-right" aria-hidden="true"></span>
           </div>
         <% end %>
       <% elsif @question.first_question_id %>
         <%= link_to legislation_process_question_path(@process, @question.first_question_id), class: "quiz-next-link" do %>
           <div class="quiz-next">
             <%= t("legislation.questions.show.first_question") %>
-            <span class="icon-angle-right" aria-hidden="true">
+            <span class="icon-angle-right" aria-hidden="true"></span>
           </div>
         <% end %>
       <% end %>

app/views/valuation/budget_investments/show.html.erb

@@ -17,7 +17,6 @@
 
 <hr>
 <%= render "/budgets/investments/investment_detail", investment: @investment, preview: true %>
-</hr>
 
 <hr>