consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix invalid postal code message

Browse Source 
We were using the word "registered" in English as an equivalent of the
Spanish word "empadronado". However, the term "registered" is very
confusing because it might be understood as being registered in the
CONSUL website.

In the message, we're saying "cannot participate" in order to make the
message consistent with the message regarding the required age.
This commit is contained in:
Javi Martín
2021-11-27 17:45:25 +01:00
parent c2e95f6b86
commit a79bbac894
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
config/locales/en/verification.yml
View File

@@ -55,7 +55,7 @@ en:
residence_card: Residence card residence_card: Residence card
spanish_id: DNI spanish_id: DNI
error_not_allowed_age: You don't have the required age to participate error_not_allowed_age: You don't have the required age to participate
error_not_allowed_postal_code: In order to be verified, you must be registered. error_not_allowed_postal_code: Citizens from this postal code cannot participate
error_verifying_census: The Census was unable to verify your information. Please confirm that your census details are correct by calling to City Council or visit one Citizen Support Office. error_verifying_census: The Census was unable to verify your information. Please confirm that your census details are correct by calling to City Council or visit one Citizen Support Office.
form_errors: prevented the verification of your residence form_errors: prevented the verification of your residence
postal_code_note: To verify your account you must be registered postal_code_note: To verify your account you must be registered

2
config/locales/es/verification.yml
View File

@@ -55,7 +55,7 @@ es:
residence_card: Tarjeta de residencia residence_card: Tarjeta de residencia
spanish_id: DNI spanish_id: DNI
error_not_allowed_age: No tienes la edad mínima para participar error_not_allowed_age: No tienes la edad mínima para participar
error_not_allowed_postal_code: Para verificarte debes estar empadronado. error_not_allowed_postal_code: Los ciudadanos residentes en este código postal no pueden participar
error_verifying_census: El Padrón no pudo verificar tu información. Por favor, confirma que tus datos de empadronamiento sean correctos llamando al Ayuntamiento o visitando una Oficina de Atención al Ciudadano. error_verifying_census: El Padrón no pudo verificar tu información. Por favor, confirma que tus datos de empadronamiento sean correctos llamando al Ayuntamiento o visitando una Oficina de Atención al Ciudadano.
form_errors: evitaron verificar tu residencia form_errors: evitaron verificar tu residencia
postal_code_note: Para verificar tus datos debes estar empadronado postal_code_note: Para verificar tus datos debes estar empadronado

2
spec/models/verification/residence_spec.rb
View File

@@ -142,7 +142,7 @@ describe Verification::Residence do
residence.postal_code = "28101" residence.postal_code = "28101"
expect(residence).not_to be_valid expect(residence).not_to be_valid
expect(residence.errors.count).to eq 1 expect(residence.errors.count).to eq 1
expect(residence.errors[:postal_code]).to eq ["In order to be verified, you must be registered."] expect(residence.errors[:postal_code]).to eq ["Citizens from this postal code cannot participate"]
end end
it "allows any postal code when the setting is blank" do it "allows any postal code when the setting is blank" do

2
spec/system/verification/residence_spec.rb
View File

@@ -108,7 +108,7 @@ describe "Residence" do
click_button "Verify residence" click_button "Verify residence"
expect(page).to have_content "In order to be verified, you must be registered" expect(page).to have_content "Citizens from this postal code cannot participate"
end end
scenario "Error on census" do scenario "Error on census" do