From a79bbac894289b68c4db54a8921cb2029b50e45b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Sat, 27 Nov 2021 17:45:25 +0100 Subject: [PATCH] Fix invalid postal code message We were using the word "registered" in English as an equivalent of the Spanish word "empadronado". However, the term "registered" is very confusing because it might be understood as being registered in the CONSUL website. In the message, we're saying "cannot participate" in order to make the message consistent with the message regarding the required age. --- config/locales/en/verification.yml | 2 +- config/locales/es/verification.yml | 2 +- spec/models/verification/residence_spec.rb | 2 +- spec/system/verification/residence_spec.rb | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/config/locales/en/verification.yml b/config/locales/en/verification.yml index cd0201d63..e1bdb2883 100644 --- a/config/locales/en/verification.yml +++ b/config/locales/en/verification.yml @@ -55,7 +55,7 @@ en: residence_card: Residence card spanish_id: DNI error_not_allowed_age: You don't have the required age to participate - error_not_allowed_postal_code: In order to be verified, you must be registered. + error_not_allowed_postal_code: Citizens from this postal code cannot participate error_verifying_census: The Census was unable to verify your information. Please confirm that your census details are correct by calling to City Council or visit one Citizen Support Office. form_errors: prevented the verification of your residence postal_code_note: To verify your account you must be registered diff --git a/config/locales/es/verification.yml b/config/locales/es/verification.yml index 55123724d..c3191438b 100644 --- a/config/locales/es/verification.yml +++ b/config/locales/es/verification.yml @@ -55,7 +55,7 @@ es: residence_card: Tarjeta de residencia spanish_id: DNI error_not_allowed_age: No tienes la edad mínima para participar - error_not_allowed_postal_code: Para verificarte debes estar empadronado. + error_not_allowed_postal_code: Los ciudadanos residentes en este código postal no pueden participar error_verifying_census: El Padrón no pudo verificar tu información. Por favor, confirma que tus datos de empadronamiento sean correctos llamando al Ayuntamiento o visitando una Oficina de Atención al Ciudadano. form_errors: evitaron verificar tu residencia postal_code_note: Para verificar tus datos debes estar empadronado diff --git a/spec/models/verification/residence_spec.rb b/spec/models/verification/residence_spec.rb index 26196c3ce..a33f8aaba 100644 --- a/spec/models/verification/residence_spec.rb +++ b/spec/models/verification/residence_spec.rb @@ -142,7 +142,7 @@ describe Verification::Residence do residence.postal_code = "28101" expect(residence).not_to be_valid expect(residence.errors.count).to eq 1 - expect(residence.errors[:postal_code]).to eq ["In order to be verified, you must be registered."] + expect(residence.errors[:postal_code]).to eq ["Citizens from this postal code cannot participate"] end it "allows any postal code when the setting is blank" do diff --git a/spec/system/verification/residence_spec.rb b/spec/system/verification/residence_spec.rb index f2f7e2700..285cd9d71 100644 --- a/spec/system/verification/residence_spec.rb +++ b/spec/system/verification/residence_spec.rb @@ -108,7 +108,7 @@ describe "Residence" do click_button "Verify residence" - expect(page).to have_content "In order to be verified, you must be registered" + expect(page).to have_content "Citizens from this postal code cannot participate" end scenario "Error on census" do