consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't send newsletters to unconfirmed accounts (Merge #3781)

Browse Source
This commit is contained in:
Mohsin Khan
2019-10-31 01:15:05 +05:00
committed by Javier Martín
parent bf7a8b4519
commit 9fd79cefd4
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/user_segments.rb
View File

@@ -10,7 +10,7 @@ class UserSegments
not_supported_on_current_budget].freeze not_supported_on_current_budget].freeze
def self.all_users def self.all_users
User.active User.active.where.not(confirmed_at: nil)
end end
def self.administrators def self.administrators

1
spec/models/newsletter_spec.rb
View File

@@ -50,6 +50,7 @@ describe Newsletter do
describe "#list_of_recipient_emails" do describe "#list_of_recipient_emails" do
before do before do
create(:user, newsletter: true, email: "newsletter_user@consul.dev") create(:user, newsletter: true, email: "newsletter_user@consul.dev")
create(:user, newsletter: true, email: "newsletter_unconfirmed_user@consul.dev", confirmed_at: nil)
create(:user, newsletter: false, email: "no_news_user@consul.dev") create(:user, newsletter: false, email: "no_news_user@consul.dev")
create(:user, email: "erased_user@consul.dev").erase create(:user, email: "erased_user@consul.dev").erase
newsletter.update!(segment_recipient: "all_users") newsletter.update!(segment_recipient: "all_users")