From 9fd79cefd4607f62b11f3a8eb2f5695f5d5be614 Mon Sep 17 00:00:00 2001 From: Mohsin Khan <37393666+mohsinkhansymc@users.noreply.github.com> Date: Thu, 31 Oct 2019 01:15:05 +0500 Subject: [PATCH] Don't send newsletters to unconfirmed accounts (Merge #3781) --- lib/user_segments.rb | 2 +- spec/models/newsletter_spec.rb | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/user_segments.rb b/lib/user_segments.rb index bf30f4416..ae6d345be 100644 --- a/lib/user_segments.rb +++ b/lib/user_segments.rb @@ -10,7 +10,7 @@ class UserSegments not_supported_on_current_budget].freeze def self.all_users - User.active + User.active.where.not(confirmed_at: nil) end def self.administrators diff --git a/spec/models/newsletter_spec.rb b/spec/models/newsletter_spec.rb index 275bd39fd..14fa3a454 100644 --- a/spec/models/newsletter_spec.rb +++ b/spec/models/newsletter_spec.rb @@ -50,6 +50,7 @@ describe Newsletter do describe "#list_of_recipient_emails" do before do create(:user, newsletter: true, email: "newsletter_user@consul.dev") + create(:user, newsletter: true, email: "newsletter_unconfirmed_user@consul.dev", confirmed_at: nil) create(:user, newsletter: false, email: "no_news_user@consul.dev") create(:user, email: "erased_user@consul.dev").erase newsletter.update!(segment_recipient: "all_users")