Use the whole module name for SentencesParser
In order for `include SentencesParser` to work with Zeitwerk, we'd have
to change the code slightly, so it follows Ruby conventions to resolve
constants:
```
module RemoteTranslations::Microsoft
class Client
include SentencesParser
# (...)
end
end
```
This would mean changing the indentation of the whole file. While we can
do that, changing the indentation of a file makes it harder to use
commands like `git blame` or `git log` with the file, so we're doing the
change the easy way.
This commit is contained in:
@@ -1,5 +1,5 @@
|
|||||||
class RemoteTranslations::Microsoft::Client
|
class RemoteTranslations::Microsoft::Client
|
||||||
include SentencesParser
|
include RemoteTranslations::Microsoft::SentencesParser
|
||||||
CHARACTERS_LIMIT_PER_REQUEST = 5000
|
CHARACTERS_LIMIT_PER_REQUEST = 5000
|
||||||
PREVENTING_TRANSLATION_KEY = "notranslate".freeze
|
PREVENTING_TRANSLATION_KEY = "notranslate".freeze
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user