From 919755f328695b320c4aef4a20dbcaa0a8f7de9a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Tue, 25 Jul 2023 05:06:13 +0200 Subject: [PATCH] Use the whole module name for SentencesParser In order for `include SentencesParser` to work with Zeitwerk, we'd have to change the code slightly, so it follows Ruby conventions to resolve constants: ``` module RemoteTranslations::Microsoft class Client include SentencesParser # (...) end end ``` This would mean changing the indentation of the whole file. While we can do that, changing the indentation of a file makes it harder to use commands like `git blame` or `git log` with the file, so we're doing the change the easy way. --- app/lib/remote_translations/microsoft/client.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/lib/remote_translations/microsoft/client.rb b/app/lib/remote_translations/microsoft/client.rb index ad17adccd..81ccff153 100644 --- a/app/lib/remote_translations/microsoft/client.rb +++ b/app/lib/remote_translations/microsoft/client.rb @@ -1,5 +1,5 @@ class RemoteTranslations::Microsoft::Client - include SentencesParser + include RemoteTranslations::Microsoft::SentencesParser CHARACTERS_LIMIT_PER_REQUEST = 5000 PREVENTING_TRANSLATION_KEY = "notranslate".freeze